Bug 1579102 - VM can be started while ISO is still uploading
Summary: VM can be started while ISO is still uploading
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.2.3.5
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ovirt-4.2.4
: ---
Assignee: Tal Nisan
QA Contact: Avihai
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-05-17 01:23 UTC by Germano Veit Michel
Modified: 2018-06-26 08:36 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine-4.2.4.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-26 08:36:42 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2?
gveitmic: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 91687 0 master MERGED core: Prevent a VM from running with ISO on data domain in invalid status 2018-05-30 07:31:50 UTC
oVirt gerrit 91740 0 ovirt-engine-4.2 MERGED core: Prevent a VM from running with ISO on data domain in invalid status 2018-05-30 07:32:00 UTC

Description Germano Veit Michel 2018-05-17 01:23:56 UTC
Description of problem:

1. Create a VM
2. Upload a big ISO to a Data Domain (yay!)
3. Attach the ISO to the VM
4. Start the VM

The upload did not finish yet. But the VM is running with it attached.

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.3.5-1.el7.centos.noarch

How reproducible:
100%

Actual results:
VM started with some corrupted ISO

Expected results:
Something else? warn user/block start/detach iso

Comment 1 Tal Nisan 2018-05-17 09:28:35 UTC
This is actually not a regression, you could have started a VM with a partially copied/uploaded file from an ISO domain, however, given the better control we have over data domains this can be fixed for data domains only

Comment 2 Yaniv Kaul 2018-05-17 11:22:28 UTC
(In reply to Tal Nisan from comment #1)
> This is actually not a regression, you could have started a VM with a
> partially copied/uploaded file from an ISO domain, however, given the better
> control we have over data domains this can be fixed for data domains only

I'd imagine that during upload the disk should be locked, and we should not allow attaching locked ISOs, no?

Comment 3 Germano Veit Michel 2018-05-17 23:14:43 UTC
(In reply to Yaniv Kaul from comment #2)
> (In reply to Tal Nisan from comment #1)
> > This is actually not a regression, you could have started a VM with a
> > partially copied/uploaded file from an ISO domain, however, given the better
> > control we have over data domains this can be fixed for data domains only
> 

You are right, it happens on the old ISO domains too.

This was just me playing with the new features. I see this is proposed to 4.2, the is no downstream ticket attached so I assume 4.3 is fine. Severity is set to low.

> I'd imagine that during upload the disk should be locked, and we should not
> allow attaching locked ISOs, no?

That's what I expected.

Comment 4 Tal Nisan 2018-05-21 08:44:40 UTC
(In reply to Yaniv Kaul from comment #2)
> (In reply to Tal Nisan from comment #1)
> > This is actually not a regression, you could have started a VM with a
> > partially copied/uploaded file from an ISO domain, however, given the better
> > control we have over data domains this can be fixed for data domains only
> 
> I'd imagine that during upload the disk should be locked, and we should not
> allow attaching locked ISOs, no?

Yes, exactly, since we have ISO on data domain we can mark them as locked as opposed to ISOs on an ISO domain on which we have no information about the ISO

Comment 5 Avihai 2018-06-10 12:01:43 UTC
Verified on 4.2.4.1-0.1.

Checked original scenario & saw that VM can't be started while upload is in progress(disk locked).

Checked also that after the ISO disk upload is done that the VM can indeed be started with the same ISO disk in VM boot option as CD.

Comment 6 Sandro Bonazzola 2018-06-26 08:36:42 UTC
This bugzilla is included in oVirt 4.2.4 release, published on June 26th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.