Spec URL: https://github.com/systemd/systemd-netlogd SRPM URL: https://github.com/systemd/systemd-netlogd/archive/v1.0.tar.gz Description: Forwards messages from the journal to other hosts over the network using the Syslog Protocol (RFC 5424). It can be configured to send messages to both unicast and multicast addresses. systemd-netlogd runs with own user systemd-journal-netlog. Starts sending logs when network is up and stops sending as soon as network is down (uses sd-network). Forwards messages from the journal to other hosts over the network using the Syslog Protocol (RFC 5424). It can be configured to send messages to both unicast and multicast addresses. systemd-netlogd runs with own user systemd-journal-netlog. Starts sending logs when network is up and stops sending as soon as network is down (uses sd-network). Fedora Account System Username:ssahani
spec file :https://github.com/systemd/systemd-netlogd/blob/master/systemd-netlogd.spec
>Group: Applications/Internet Drop this. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections >License: LGPLv2+ and MIT+ Taking a short look at the repo, I think this should be "GPLv2 and LGPLv2+ and CC0". >URL: https://github.com/systemd/systemd-netlogd >Source0: https://github.com/systemd/systemd-netlogd/archive/v%{version}.tar.gz You can use %{URL} as part of Source0 to reduce repetition. >/usr/share/man/man1/systemd-netlogd.1.gz Do not specify ".gz" explicitly; use a wildcard that can match any compression method. https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages You should use macro forms of system directories: >/etc/systemd/... %{_sysconfdir}/systemd >/usr/share/man/man1/systemd-netlogd.1.gz %{_mandir}/man1/... https://fedoraproject.org/wiki/Packaging:RPMMacros Also, the spec link goes to a syntax-highlighted HTML rendering of the spec. Next time please provide a direct link (the "Raw" button in GitHub).
>/usr/share/man/man1/systemd-netlogd.1.gz Do not specify ".gz" explicitly; use a wildcard that can match any compression method. I think this does not work as spectool -g systemd-netlogd.spec Getting https://github.com/systemd/systemd-netlogd/archive/v1.1.* to ./v1.1.* % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- 0:00:03 --:--:-- 0 curl: (22) The requested URL returned error: 404 Not Found I have updated
https://raw.githubusercontent.com/systemd/systemd-netlogd/master/systemd-netlogd.spec
>License: GPLv2 LGPLv2+ 1) You should use the words "and" & "or" to describe the relationship between the licences. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios 2) src/siphash24.c seems to be subject to the Creative Commons Zero licence. https://raw.githubusercontent.com/systemd/systemd-netlogd/master/src/siphash24.c Given 1) and 2), I think the License tag should say "GPLv2 and LGPLv2+ and CC0". Also, like I wrote previously - do not specify ".gz" for man pages; use a wildcard that can match any compression method.
LGPLv2+ and Creative Commons Zero licence
>Also, like I wrote previously - do not specify ".gz" for man pages; use a wildcard that can match any compression method. Did you tested. It did not worked with me . If you can you give me a working example
Please, note that this is an informal review, and I'm not familiar with the Meson build system. > https://raw.githubusercontent.com/systemd/systemd-netlogd/master/systemd-netlogd.spec Please, also provide the srpm file. A koji build would be helpful too. > Summary: Forwards messages from the journal to other hosts over the network using syslog format RFC 5424 The summary is too long. I would consider a shorter one if possible. > License: GPLv2 and LGPL-2.1+ and CC0 It should be "GPLv2 and LGPLv2+ and CC0". The ".1" should not be specified. And the license breakdown should be included in the spec as comments (i.e., which files correspond to which license). Also, license files should be included using the %license macro. > Getting https://github.com/systemd/systemd-netlogd/archive/v1.1.* to ./v1.1.* > Did you tested. It did not worked with me. If you can you give me a working example The URL is ok. Artur was referring to the *man* page. The line %{_mandir}/man1/systemd-netlogd.1.gz should be instead %{_mandir}/man1/systemd-netlogd.1* Note also that you can use %{name} to replace every appearance of "systemd-netlogd" (except for the first one, of course). > %{_sysconfdir}/systemd/system/systemd-netlogd.conf These directories (%{_sysconfdir}/systemd, %{_sysconfdir}/systemd/system, etc.) are not owned by your package, because they are owned by systemd, but you didn't include systemd as a requirement. You should use the macro %{?systemd_requires} to solve this. For more information about systemd macros that you may need, see https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd > * Mon May 21 2018 Susant Sahani <susant> - 1.1 Note that the version number in the changelog should include the Fedora release number, i.e., 1.1-1.
You did not provide SRPM, it simplifies testing. Okay, I cannot find any reasonable documentation how to produce it. Let's say it is here: mkdir systemd-netlogd cd systemd-netlogd git init curl -O https://raw.githubusercontent.com/systemd/systemd-netlogd/master/systemd-netlogd.spec spectool -g *.spec fedpkg --release master srpm Now your spec references v1.2, which was never released. spectool cannot find it and you did not provide it.
This is an automatic action taken by review-stats script. The submitter account doesn't exist anymore, therefore this ticket will be closed.