Bug 1580354 - [3.6] upgrade_control_plane.yml removes OPENSHIFT_DEFAULT_REGISTRY=docker-registry.default.svc:5000 from /etc/sysconfig/atomic-openshift-master-{api,controllers}
Summary: [3.6] upgrade_control_plane.yml removes OPENSHIFT_DEFAULT_REGISTRY=docker-reg...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cluster Version Operator
Version: 3.6.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 3.6.z
Assignee: Vadim Rutkovsky
QA Contact: Gaoyun Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-05-21 10:53 UTC by Kenjiro Nakayama
Modified: 2021-09-09 14:08 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: openshift_push_via_dns option was not respected during upgrade Consequence: OPENSHIFT_DEFAULT_REGISTRY was always removed during upgrade Fix: openshift_push_via_dns option is being set if existing registry DC has OPENSHIFT_DEFAULT_REGISTRY env var Result: existing OPENSHIFT_DEFAULT_REGISTRY env var is not being removed during upgrade
Clone Of:
Environment:
Last Closed: 2019-01-30 15:12:36 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 3588631 0 None None None 2018-08-28 04:43:54 UTC
Red Hat Product Errata RHBA-2019:0101 0 None None None 2019-01-30 15:12:39 UTC

Description Kenjiro Nakayama 2018-05-21 10:53:48 UTC 
Description of problem:

- When upgrading from 3.6.x to latest 3.6, OPENSHIFT_DEFAULT_REGISTRY=docker-registry.default.svc:5000 was dropped from /etc/sysconfig/atomic-openshift-master-{api,controllers}.

Version-Release number of the following components:
- openshift-ansible-3.6.173.0.117-1.git.0.8c22c43.el7.noarch

How reproducible: 100%

Steps to Reproduce:
1. Run upgrade_control_plane.yml

  # ansible-playbook -i </path/to/inventory/file> \
      /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_6/upgrade_control_plane.yml

2. Check /etc/sysconfig/atomic-openshift-master-{api,controllers}

Actual results:
- Playbook completes withtout error. However, OPENSHIFT_DEFAULT_REGISTRY=docker-registry.default.svc:5000 in /etc/sysconfig/atomic-openshfit-master-* is dropped.

Expected results:
- Keep OPENSHIFT_DEFAULT_REGISTRY=docker-registry.default.svc:5000 in /etc/sysconfig/atomic-openshfit-master-*

Additional info:
- Attached entire logs in private.
Comment 2 Kenjiro Nakayama 2018-05-21 11:04:47 UTC 
Proposed patch: https://github.com/openshift/openshift-ansible/pull/8454
Comment 3 Russell Teague 2018-11-20 19:11:29 UTC 
Fixed in openshift-ansible-3.6.173.0.132-1
Comment 4 Gaoyun Pei 2018-11-22 10:00:17 UTC 
Verify this bug with openshift-ansible-3.6.173.0.139-1.git.0.cf96f27.el7.noarch.rpm

After upgrading an 3.6.173.0.96 cluster to v3.6.173.0.139, OPENSHIFT_DEFAULT_REGISTRY=docker-registry.default.svc:5000 still there.


[root@ip-172-18-15-252 ~]# grep OPENSHIFT_DEFAULT_REGISTRY /etc/sysconfig/atomic-openshift-master*
/etc/sysconfig/atomic-openshift-master:OPENSHIFT_DEFAULT_REGISTRY=docker-registry.default.svc:5000
/etc/sysconfig/atomic-openshift-master.636.2018-11-22@02:18:54~:OPENSHIFT_DEFAULT_REGISTRY=docker-registry.default.svc:5000
Comment 6 errata-xmlrpc 2019-01-30 15:12:36 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0101
Note You need to log in before you can comment on or make changes to this bug.