odltools is a python package that contains a bunch of user/operator tools for debugging OpenDaylight: https://github.com/shague/odltools Requesting package reviewed/accepted by Rocky MS2.
Will add spec files and source rpm
spec file here: https://gist.githubusercontent.com/trozet/e5c6cd30036f0dfa4c59d1b4b24413fe/raw/b0ee7dced006741727081f8fde3d35e9401d2044/python-odltools.spec
Initial licensecheck output: $ licensecheck -r . ./.travis.yml: *No copyright* UNKNOWN ./CONTRIBUTING.rst: *No copyright* UNKNOWN ./LICENSE: *No copyright* Apache (v2.0) ./README.rst: *No copyright* UNKNOWN ./requirements.txt: *No copyright* UNKNOWN ./setup.cfg: *No copyright* Apache ./setup.py: Apache (v2.0) ./test-requirements.txt: *No copyright* UNKNOWN ./tox.ini: *No copyright* UNKNOWN ./docs/Makefile: *No copyright* UNKNOWN ./docs/conf.py: *No copyright* GENERATED FILE ./docs/contributing.rst: *No copyright* UNKNOWN ./docs/examples.rst: *No copyright* UNKNOWN ./docs/index.rst: *No copyright* UNKNOWN ./docs/new-release.rst: *No copyright* UNKNOWN ./odltools/__init__.py: *No copyright* UNKNOWN ./odltools/__main__.py: Apache (v2.0) ./odltools/cli.py: Apache (v2.0) ./odltools/cli_utils.py: *No copyright* UNKNOWN ./odltools/logg.py: Apache (v2.0) ./.github/ISSUE_TEMPLATE/Bug_report.md: *No copyright* UNKNOWN ./.github/ISSUE_TEMPLATE/Feature_request.md: *No copyright* UNKNOWN ./docs/_static/logo.png: UNKNOWN ./odltools/csit/cli.py: Apache (v2.0) ./odltools/csit/robotfiles.py: Apache (v2.0) ./odltools/mdsal/cli.py: Apache (v2.0) ./odltools/mdsal/request.py: Apache (v2.0) ./odltools/monitor/cli.py: *No copyright* UNKNOWN ./odltools/netvirt/analyze.py: Apache (v2.0) ./odltools/netvirt/cli.py: Apache (v2.0) ./odltools/netvirt/config.py: Apache (v2.0) ./odltools/netvirt/flow_parser.py: Apache (v2.0) ./odltools/netvirt/flows.py: Apache (v2.0) ./odltools/netvirt/ovs_flows.py: Apache (v2.0) ./odltools/netvirt/request.py: Apache (v2.0) ./odltools/netvirt/show.py: Apache (v2.0) ./odltools/netvirt/tables.py: *No copyright* UNKNOWN ./odltools/netvirt/utils.py: Apache (v2.0) ./odltools/tests/test_cli.py: Apache (v2.0) ./odltools/csit/tests/test_robotfiles.py: Apache (v2.0) ./odltools/mdsal/models/Modules.py: *No copyright* UNKNOWN ./odltools/mdsal/models/constants.py: *No copyright* UNKNOWN ./odltools/mdsal/models/elan.py: Apache (v2.0) ./odltools/mdsal/models/id_manager.py: Apache (v2.0) ./odltools/mdsal/models/ietf_interfaces.py: Apache (v2.0) ./odltools/mdsal/models/interface_service_bindings.py: Apache (v2.0) ./odltools/mdsal/models/itm_state.py: Apache (v2.0) ./odltools/mdsal/models/l3vpn.py: Apache (v2.0) ./odltools/mdsal/models/mip.py: Apache (v2.0) ./odltools/mdsal/models/model.py: Apache (v2.0) ./odltools/mdsal/models/models.py: Apache (v2.0) ./odltools/mdsal/models/network_topology.py: Apache (v2.0) ./odltools/mdsal/models/neutron.py: Apache (v2.0) ./odltools/mdsal/models/odl_fib.py: Apache (v2.0) ./odltools/mdsal/models/odl_interface_meta.py: Apache (v2.0) ./odltools/mdsal/models/odl_l3vpn.py: Apache (v2.0) ./odltools/mdsal/models/opendaylight_inventory.py: Apache (v2.0) ./odltools/mdsal/tests/__init__.py: Apache (v2.0) ./odltools/mdsal/tests/test_cli.py: Apache (v2.0) ./odltools/mdsal/tests/test_id_manager.py: Apache (v2.0) ./odltools/mdsal/tests/test_ietf_interfaces.py: Apache (v2.0) ./odltools/mdsal/tests/test_itm_state.py: Apache (v2.0) ./odltools/mdsal/tests/test_network_topology.py: Apache (v2.0) ./odltools/mdsal/tests/test_neutron.py: Apache (v2.0) ./odltools/mdsal/tests/test_odl_fib.py: Apache (v2.0) ./odltools/mdsal/tests/test_opendaylight_inventory.py: Apache (v2.0) ./odltools/mdsal/tests/test_request.py: Apache (v2.0) ./odltools/netvirt/tests/__init__.py: Apache (v2.0) ./odltools/netvirt/tests/capture.py: Apache (v2.0) ./odltools/netvirt/tests/test_analyze.py: Apache (v2.0) ./odltools/netvirt/tests/test_config.py: Apache (v2.0) ./odltools/netvirt/tests/test_ovs_flows.py: Apache (v2.0) ./odltools/netvirt/tests/test_request.py: Apache (v2.0) ./odltools/netvirt/tests/test_show.py: Apache (v2.0) ./odltools/netvirt/tests/test_tables.py: Apache (v2.0) ./odltools/tests/resources/config___elan__elan-instances.json: *No copyright* UNKNOWN ./odltools/tests/resources/config___elan__elan-interfaces.json: *No copyright* UNKNOWN ./odltools/tests/resources/config___id-manager__id-pools.json: *No copyright* UNKNOWN ./odltools/tests/resources/config___ietf-interfaces__interfaces.json: *No copyright* UNKNOWN ./odltools/tests/resources/config___interface-service-bindings__service-bindings.json: *No copyright* UNKNOWN ./odltools/tests/resources/config___itm-state__dpn-endpoints.json: *No copyright* UNKNOWN ./odltools/tests/resources/config___l3vpn__vpn-interfaces.json: *No copyright* UNKNOWN ./odltools/tests/resources/config___network-topology__network-topology___topology___ovsdb__1.json: *No copyright* UNKNOWN ./odltools/tests/resources/config___neutron__neutron.json: *No copyright* UNKNOWN ./odltools/tests/resources/config___odl-fib__fibEntries.json: *No copyright* UNKNOWN ./odltools/tests/resources/config___odl-l3vpn__vpn-instance-to-vpn-id.json: *No copyright* UNKNOWN ./odltools/tests/resources/config___opendaylight-inventory__nodes.json: *No copyright* UNKNOWN ./odltools/tests/resources/flow_dumps.1.txt: *No copyright* UNKNOWN ./odltools/tests/resources/flow_dumps.2.txt: *No copyright* UNKNOWN ./odltools/tests/resources/flow_dumps.3.txt: *No copyright* UNKNOWN ./odltools/tests/resources/operational___ietf-interfaces__interfaces-state.json: *No copyright* UNKNOWN ./odltools/tests/resources/operational___itm-state__tunnels_state.json: *No copyright* UNKNOWN ./odltools/tests/resources/operational___network-topology__network-topology___topology___ovsdb__1.json: *No copyright* UNKNOWN ./odltools/tests/resources/operational___odl-interface-meta__if-indexes-interface-map.json: *No copyright* UNKNOWN ./odltools/tests/resources/operational___opendaylight-inventory__nodes.json: *No copyright* UNKNOWN The package is licensed using the Apache 2.0 license.
I can't find any open review at review.rdoproject.org referencing this bz. Could you open it following step 2 from https://www.rdoproject.org/documentation/add-packages/ ? Thanks!
I'm not sure RDO is the right place for this package. Some questions: - Will this be a requirement for other OpenStack packages/repos? - Are these tools specific for OpenStack deployments using ODL or it could be use for any ODL deploment out of OpenStack? - I see ODL is packaged by nfv SIG in CentOS [1]. Could that be the right place to get this packaged instead of RDO?. [1] https://cbs.centos.org/koji/buildinfo?buildID=22697
(In reply to Alfredo Moralejo from comment #5) > I'm not sure RDO is the right place for this package. Some questions: > > - Will this be a requirement for other OpenStack packages/repos? No > - Are these tools specific for OpenStack deployments using ODL or it could > be use for any ODL deploment out of OpenStack? It could be used outside of OpenStack for other ODL use cases. > - I see ODL is packaged by nfv SIG in CentOS [1]. Could that be the right > place to get this packaged instead of RDO?. > > [1] https://cbs.centos.org/koji/buildinfo?buildID=22697 I see your point. I don't think we use those builds from CBS anymore for ODL, but I'll do some digging and try to figure out if there is a better place to build this. Either way, we need to pull it into the undercloud so it needs to be available (even if not built in) RDO right?
Is there a way to configure the checker to ignore certain files? The *.json files are resource files used for testing. The rst, md and txt files are also just doc files so we didn't add license headers there either.
Any reason, not to submit this in Fedora? (It can be imported later in RDO) Anyway, I can review it.
(In reply to Tim Rozet from comment #6) > (In reply to Alfredo Moralejo from comment #5) > > I'm not sure RDO is the right place for this package. Some questions: > > > > - Will this be a requirement for other OpenStack packages/repos? > No > > - Are these tools specific for OpenStack deployments using ODL or it could > > be use for any ODL deploment out of OpenStack? > It could be used outside of OpenStack for other ODL use cases. > > - I see ODL is packaged by nfv SIG in CentOS [1]. Could that be the right > > place to get this packaged instead of RDO?. > > > > [1] https://cbs.centos.org/koji/buildinfo?buildID=22697 > > I see your point. I don't think we use those builds from CBS anymore for > ODL, but I'll do some digging and try to figure out if there is a better > place to build this. Either way, we need to pull it into the undercloud so > it needs to be available (even if not built in) RDO right? Yes, if you need to get it installed in the undercloud you'll probably need to configure the repo where the package is and install it as part of undercloud install. I think there are some similar cases already so probably TrpleO folks can help you to find out the best way to do it.
I think we have decided to build this package in ODL. Then we will need to get it pulled into the undercloud. I don't think there is anything required in RDO for that.
I think the right way is to create this package in fedora and then we will import it in RDO, as done for non-OpenStack packages. The process to get it into fedora first https://fedoraproject.org/wiki/New_package_process_for_existing_contributors
Alfredo, I think we should build it in ODL, as we build ODL RPMs there as well, then import it in RDO.