Bug 1580547 - tripleo-ansible-inventory returns {} when creating the ansible inventory
Summary: tripleo-ansible-inventory returns {} when creating the ansible inventory
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-validations
Version: 13.0 (Queens)
Hardware: All
OS: All
medium
medium
Target Milestone: z2
: 13.0 (Queens)
Assignee: Carlos Camacho
QA Contact: Udi Kalifon
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-05-21 18:55 UTC by Carlos Camacho
Modified: 2018-12-24 11:40 UTC (History)
8 users (show)

Fixed In Version: openstack-tripleo-validations-8.4.2-1.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-29 16:36:37 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenDaylight gerrit 565201 0 None None None 2018-05-21 18:55:53 UTC
OpenStack gerrit 566881 0 None stable/queens: MERGED tripleo-validations: Fail if the Overcloud inventory is empty (I76fe01b7f2ec84db8a8aeaa749cb7b961667b3c9) 2018-07-19 01:52:02 UTC
OpenStack gerrit 596684 0 None None None 2018-08-27 13:00:24 UTC
Red Hat Product Errata RHBA-2018:2574 0 None None None 2018-08-29 16:37:23 UTC

Description Carlos Camacho 2018-05-21 18:55:16 UTC
If tripleo-ansible-inventory returns empty, the script should fail
and display an error message for the users to
fix the plan or stack name before continuing.

Reproducible: 100%

How to reproduce:
Run:
  tripleo-ansible-inventory --stack overcloasdfud

Expected result:
  Error showing that the inventory is empty
Actual result:
  '{}' it finish with a status code of 0 instead of 1

Comment 10 Joanne O'Flynn 2018-08-15 08:05:23 UTC
This bug is marked for inclusion in the errata but does not currently contain draft documentation text. To ensure the timely release of this advisory please provide draft documentation text for this bug as soon as possible.

If you do not think this bug requires errata documentation, set the requires_doc_text flag to "-".


To add draft documentation text:

* Select the documentation type from the "Doc Type" drop down field.

* A template will be provided in the "Doc Text" field based on the "Doc Type" value selected. Enter draft text in the "Doc Text" field.

Comment 11 Florian Fuchs 2018-08-27 13:00:24 UTC
This change is causing a regression in validation and has already been reverted in tripleo-validations master branch. I addes a backport patch of the revert:

  https://review.openstack.org/#/c/596684/

As discussed with Carlos Camacho, a follow up patch should address this issue in a slightly different way that leaves the inventory intact if there is no overcloud deployed. The initial solution made the inventory exit with an error if there was no overcloud deployed, but validations need an inventory with at least the undercloud host info to run pre-deployment validations.

Comment 13 errata-xmlrpc 2018-08-29 16:36:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2574


Note You need to log in before you can comment on or make changes to this bug.