RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1581722 - libsmbios-devel: remove c++ pkgconfig file and headers
Summary: libsmbios-devel: remove c++ pkgconfig file and headers
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libsmbios
Version: 7.5
Hardware: x86_64
OS: Linux
high
high
Target Milestone: rc
: 7.6
Assignee: Peter Jones
QA Contact: Erico Nunes
URL:
Whiteboard:
Depends On:
Blocks: 1507957 1526256
TreeView+ depends on / blocked
 
Reported: 2018-05-23 13:45 UTC by Carl George
Modified: 2021-03-01 07:36 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-01 07:36:34 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Current patch work (15.95 KB, patch)
2018-05-30 18:28 UTC, Peter Jones
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1562440 1 None None None 2021-12-10 15:53:48 UTC
Red Hat Bugzilla 1581831 0 medium CLOSED Review Request: libsmbios-cpp - Libsmbios C++ shared libraries 2021-02-22 00:41:40 UTC

Internal Links: 1562440 1581831

Description Carl George 2018-05-23 13:45:48 UTC
Description of problem:
This package previously existed in EPEL.  Red Hat added it to RHEL 7.5, but without the C++ interface.  While working on a new libsmbios-cpp package, I discovered that although the new libsmbios disables the C++ interface, libsmbios-devel still includes the C++ pkgconfig file and headers.

/usr/lib64/pkgconfig/libsmbios_c++.pc
/usr/include/smbios/

Please remove those so my new libsmbios-cpp-devel package doesn't have file conflicts.

Version-Release number of selected component (if applicable):
libsmbios-2.3.3-6.el7

Comment 2 Carl George 2018-05-23 14:10:27 UTC
While you're at it, you might as well update the summary as well.

-Summary: Libsmbios C/C++ shared libraries
+Summary: Libsmbios C shared libraries

Comment 3 Peter Jones 2018-05-30 18:28:54 UTC
Created attachment 1445971 [details]
Current patch work

Thanks, here's what I've got queued up currently.

Comment 4 Carl George 2018-05-30 21:53:59 UTC
As is, those changes don't build.  Just removing the files from %files isn't enough, because they are still being installed in the buildroot.

-----------------------------------------------------------------------------------

/usr/lib64/pkgconfig/libsmbios_c++.pc

You can either rm the file at then end of %install, or patch Makefile.am to remove it.

https://github.com/dell/libsmbios/blob/v2.3.3/Makefile.am#L58

-pc_DATA = pkg/libsmbios_c.pc pkg/libsmbios_c++.pc
+pc_DATA = pkg/libsmbios_c.pc

While you're patching that file, it may be worth removing these lines as well.

https://github.com/dell/libsmbios/blob/v2.3.3/Makefile.am#L37-L39

-if BUILD_LIBSMBIOS_CXX
-include src/libsmbios_c++/Makefile.am
-endif

-----------------------------------------------------------------------------------

/usr/include/smbios and /usr/include/smbios/*

These are still being copied into the buildroot in the spec file during %install.  Changing these globs to explicit directory names should take care of it.

-cp -a $TOPDIR/src/include/*  %{buildroot}/%{_includedir}/
-cp -a out/public-include/*  %{buildroot}/%{_includedir}/
+cp -a $TOPDIR/src/include/smbios_c  %{buildroot}/%{_includedir}/
+cp -a out/public-include/smbios_c  %{buildroot}/%{_includedir}/

Comment 5 Carl George 2018-10-01 20:06:15 UTC
Looks like this is handled in libsmbios-devel-2.3.3-8.el7.x86_64.rpm from the 7.6 beta.

    %exclude %{_includedir}/smbios/
    %exclude %{_libdir}/pkgconfig/libsmbios_c++.pc

Thanks!

Comment 9 RHEL Program Management 2021-03-01 07:36:34 UTC
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.


Note You need to log in before you can comment on or make changes to this bug.