RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1582570 - Security vulnerability icon doesn't work
Summary: Security vulnerability icon doesn't work
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: cockpit
Version: 7.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 7.5
Assignee: Martin Pitt
QA Contact: Leos Pol
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-05-25 15:30 UTC by Andreas Nilsson
Modified: 2018-06-26 18:39 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-26 18:38:52 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
screenshot (96.39 KB, image/png)
2018-05-25 15:30 UTC, Andreas Nilsson 		no flags Details
screenshot with fa-shield (40.42 KB, image/png)
2018-05-28 07:47 UTC, Martin Pitt 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:2026 0 None None None 2018-06-26 18:38:59 UTC

Description Andreas Nilsson 2018-05-25 15:30:21 UTC 
Created attachment 1441625 [details]
screenshot

It seems the security level shield doesn't render as it should on 7.5.
I tried to build a local copy of master, and it worked as it should, although a fedora system doesn't have the security level variants, so not sure if that plays into it or not.
Comment 2 Martin Pitt 2018-05-28 07:14:26 UTC 
I first tried master on current Fedora 28, with a new (fake) "moderate" classification; this was missing in our mock updates. But it works fine.

But I can reproduce the issue on a RHEL 7.5 VM, with Cockpit running on the same client.
Comment 3 Martin Pitt 2018-05-28 07:33:26 UTC 
The issue is that our Cockpit pages use the bundled patternfly from cockpit-bridge. But RHEL 7.5's cockpit-system version 154 still has an older version which does not have pficon-security yet.

Unfortunately just adding (backporting) the desired Unicode char to our CSS isn't sufficient, as the corresponding glyph is also missing in the shipped patternfly.woff font.

This will be fixed cleanly with rebasing cockpit for RHEL 7.6 (bug 1568728). I'll check if cockpit-packagekit can ship its own copy in the meantime, but this is ugly for all other distros :(
Comment 4 Martin Pitt 2018-05-28 07:47:25 UTC 
Created attachment 1442758 [details]
screenshot with fa-shield

I'll apply this downstream for 7.5.x:

--- a/pkg/lib/packagekit.es6
+++ b/pkg/lib/packagekit.es6
@@ -288,7 +288,7 @@ export function cancellableTransaction(method, arglist, progress_cb, signalHandl
  */
 export function getSeverityIcon(info, secSeverity) {
     if (info == Enum.INFO_SECURITY)
-        return "pficon pficon-security" + (secSeverity ? " severity-" + secSeverity : "");
+        return "fa fa-shield" + (secSeverity ? " severity-" + secSeverity : "");
     else if (info >= Enum.INFO_NORMAL)
         return "fa fa-bug";
     else

That's the icon that we had before the redesign in https://github.com/cockpit-project/cockpit/issues/8379. It doesn't match the current design guidelines, but it's better than nothing.
Comment 5 Andreas Nilsson 2018-05-28 08:59:18 UTC 
Makes sense to me. It's better information than no icon at all.
Thanks for the fix!
Comment 6 Martin Pitt 2018-05-28 12:33:01 UTC 
Garrett and I now figured out how to backport that pficon-security glyph: https://github.com/cockpit-project/cockpit/pull/9249 . This patch is a bit more intrusive, but not overly so, so it's fine to backport.
Comment 7 Martin Pitt 2018-05-28 21:36:12 UTC 
Fix landed, will be in Wednesday's 169 release.
Comment 10 errata-xmlrpc 2018-06-26 18:38:52 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2026
Note You need to log in before you can comment on or make changes to this bug.