Bug 1582704 - rpc_transport_unref() called for an unregistered socket fd
Summary: rpc_transport_unref() called for an unregistered socket fd
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: rpc
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1582286 1583734
TreeView+ depends on / blocked
 
Reported: 2018-05-26 06:57 UTC by Milind Changire
Modified: 2018-10-23 15:10 UTC (History)
1 user (show)

Fixed In Version: glusterfs-5.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1583734 (view as bug list)
Environment:
Last Closed: 2018-10-23 15:10:12 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Milind Changire 2018-05-26 06:57:07 UTC
Description of problem:
socket_server_event_handler() may call rpc_transport_unref() for a socket which may fail registration with the event sub-system. This causes an assert to fail in event_unregister_epoll_common()

Comment 1 Worker Ant 2018-05-26 07:08:24 UTC
REVIEW: https://review.gluster.org/20091 (rpc: conditionally cleanup event slot) posted (#1) for review on master by Milind Changire

Comment 2 Worker Ant 2018-05-29 04:14:26 UTC
COMMIT: https://review.gluster.org/20091 committed in master by "Raghavendra G" <rgowdapp> with a commit message- rpc: conditionally cleanup event slot

Problem:
socket_server_event_handler() may call rpc_transport_unref() for a
socket which may fail registration with the event sub-system.
This causes an assert to fail in event_unregister_epoll_common()

Solution:
Conditionally cleanup event slot only if slot index >= 0

Change-Id: I6ca7c133712e894adc335c7763879691b7e4b213
fixes: bz#1582704
BUG: 1582704
Signed-off-by: Milind Changire <mchangir>

Comment 3 Shyamsundar 2018-10-23 15:10:12 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.