Hide Forgot
Spec URL: http://michael.cronenworth.com/RPMS/vkd3d.spec SRPM URL: http://michael.cronenworth.com/RPMS/vkd3d-1.0-1.fc28.src.rpm Description: D3D12 to Vulkan translation library Fedora Account System Username: mooninite
Taking this review.
Quick notes: - package seems to be LGPLv2+ licensed: https://source.winehq.org/git/vkd3d.git/blob/020c119e2da0786d8be0615cff961c190b00d62d:/LICENSE - devel should require the main package and libs-devel should require libs
The naming of the packages is somewhat misleading. For example, I expect that if there's vkd3d and vkd3d-libs, that only the latter has libraries. The splits for devel are equally odd. From what I can tell in the source tree, it can actually produce binaries, but the Makefile.am is currently set to not install any produced programs. That's perfectly fine, of course. A suggestion: Produce the following subpackage layout: * libvkd3d - main libvkd3d library * libvkd3d-devel - devel content associated with it * libvkd3d-utils - utility library for libvkd3d * libvkd3d-utils-devel - devel content associated with it libvkd3d-utils would "Requires: libvkd3d%{?_isa} = %{version}-%{release}" libvkd3d-utils-devel would "Requires: libvkd3d-devel%{?_isa} = %{version}-%{release}" And as Robert-André Mauchin said, libvkd3d-devel should require libvkd3d and libvkd3d-utils-devel should require libvkd3d-utils in a similar manner.
I'm following Debian's naming of this package. https://ftp-master.debian.org/new/vkd3d_1.0-1.html As far as "vkd3d-libs" vs "libvkd3d" is there a specific Fedora policy to name it one way or the other? Example: krb5 uses "krb5-libs", dbus uses "dbus-libs", openssl uses... "openssl-libs".
Actually, there is such a (recently revised) policy: https://fedoraproject.org/wiki/Packaging:Guidelines#Libraries_and_Applications
An example of following the (newer) policy is pkgconf: https://src.fedoraproject.org/rpms/pkgconf/blob/master/f/pkgconf.spec
Well, that's exactly not what we discussed when updating the Packaging Guidelines. The current recommendation is: mainly used as application: use vkd3d vkd3d-libs mainly used as library: use libvkd3d libvkd3d-utils
> mainly used as application: use > vkd3d > vkd3d-libs IIRC, it's permitted to use the naming convention in pkgconf too. Mir would be an example of one that does the "-libs" stuff instead: https://src.fedoraproject.org/rpms/mir/blob/master/f/mir.spec
(In reply to Fabio Valentini from comment #5) > Actually, there is such a (recently revised) policy: > > https://fedoraproject.org/wiki/Packaging: > Guidelines#Libraries_and_Applications Thanks, this was the answer I was looking for. New Spec: http://michael.cronenworth.com/RPMS/vkd3d.spec New SRPM: http://michael.cronenworth.com/RPMS/vkd3d-1.0-2.fc28.src.rpm
> make %{?_smp_mflags} Please consider using "%make_build" instead. > #Remove static libraries > rm -f %{buildroot}%{_libdir}/libvkd3d.{a,la} > rm -f %{buildroot}%{_libdir}/libvkd3d-utils.{a,la} Consider using the following instead: """" # Remove libtool archives find %{buildroot} -name '*.la' -delete # Remove static libraries find %{buildroot} -name '*.a' -delete """"
New spec: http://michael.cronenworth.com/RPMS/vkd3d.spec New SRPM: http://michael.cronenworth.com/RPMS/vkd3d-1.0-3.fc28.src.rpm
Please remove the empty %files section, as `vkd3d` is not a metapackage or anything.
New spec: http://michael.cronenworth.com/RPMS/vkd3d.spec New SRPM: http://michael.cronenworth.com/RPMS/vkd3d-1.0-4.fc28.src.rpm
Review notes: * Package is named correctly * Package follows guidelines for libraries * Package builds and installs correctly * No errors of note from rpmlint or fedora-review PACKAGE APPROVED.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vkd3d
Package imported and built for Rawhide. Thanks.