Created attachment 1443100 [details] Log files Description of problem: "nodectl check" failed after mount NFS storage via cockpit UI. [root@dhcp-9-130 ~]# nodectl check Status: FAILED Bootloader ... OK Layer boot entries ... OK Valid boot entries ... OK Mount points ... FAILED - This can happen if the installation was performed incorrectly Separate /var ... OK Discard is used ... ERROR Exception in '<function check_discard at 0x7f460f0f2398>': ValueError('need more than 4 values to unpack',) need more than 4 values to unpack Basic storage ... OK Initialized VG ... OK Initialized Thin Pool ... OK Initialized LVs ... OK Thin storage ... OK Checking available space in thinpool ... OK Checking thinpool auto-extend ... OK vdsmd ... OK Version-Release number of selected component (if applicable): redhat-virtualization-host-4.2-20180525.0 cockpit-system-165-3.el7.noarch cockpit-storaged-165-3.el7.noarch cockpit-165-3.el7.x86_64 cockpit-ws-165-3.el7.x86_64 imgbased-1.0.17-0.1.el7ev.noarch How reproducible: 100% Steps to Reproduce: 1.Clean install redhat-virtualization-host-4.2-20180525.0. 2. Login to cockpit UI with root account in https://<host IP>:9090 3. Mount NFS storage in cockpit storage page. 4. #nodectl check Actual results: "nodectl check" status is failed after mount NFS storage via cockpit UI. Expected results: "nodectl check" status should be ok after mount NFS storage via cockpit UI. Additional info: After removing the mounted NFS storage via cockpit UI, the status of CLI "nodectl check" is ok.
This is an easy entry point to the codebase. Nodectl actually calls imgbased for this, so the root cause is likely to be in imgbased/src/imgbased/plugins/core.py when checking fstab.
Got a customer case with the same issue. The issue here is cockpit adds fsab entry while adding the NFS mount without the last two fields like below. 10.74.130.144:/nfs/rhev-export /tmp/test nfs defaults The last two filed is not mandatory in fstab file and if not provided, it will take the default value of 0. If a fstab contains such a line, it would fail with "ValueError('need more than 4 values to unpack',)" in the below line while parsing the file. source, target, fs, options, _, _ = shlex.split(line)
Merged on master, pending backport to 4.2 branch
Test Version: rhvh-4.2.5.0-0.20180702.0 cockpit-system-169-1.el7.noarch cockpit-ws-169-1.el7.x86_64 cockpit-dashboard-169-1.el7.x86_64 cockpit-ovirt-dashboard-0.11.29-1.el7ev.noarch cockpit-169-1.el7.x86_64 cockpit-machines-ovirt-169-1.el7.noarch cockpit-bridge-169-1.el7.x86_64 cockpit-storaged-169-1.el7.noarch imgbased-1.0.21-1.el7ev.noarch Test Steps: According to comment 0 steps. Test Result: "nodectl check" status displays ok after mount NFS storage via cockpit UI. The bug is fixed, so I will change the status to VERIFIED after devel change it to ON_QA
According to comment 4, change bug status to VERIFIED.
This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018. Since the problem described in this bug report should be resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.