Bug 1583516 - [AutoDefine] - The external sync of the AutoSyncCommand attaching all external_networks to all clusters type
Summary: [AutoDefine] - The external sync of the AutoSyncCommand attaching all externa...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.2.3.5
Hardware: x86_64
OS: Linux
medium
high
Target Milestone: ovirt-4.2.5
: ---
Assignee: Ales Musil
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks: 1530027
TreeView+ depends on / blocked
 
Reported: 2018-05-29 07:23 UTC by Michael Burman
Modified: 2018-07-31 15:32 UTC (History)
5 users (show)

Fixed In Version: ovirt-engine-4.2.5.2_SNAPSHOT-79.gffafd93.0.scratch.master.el7ev.noarch.rpm
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-31 15:32:02 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)
engine log (600.75 KB, application/x-gzip)
2018-05-29 07:29 UTC, Michael Burman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 90682 0 master MERGED core: Add custom physnet parameters into ProviderNetwork 2020-11-03 12:22:49 UTC
oVirt gerrit 90684 0 master MERGED core: Map physical network properties from external network 2020-11-03 12:22:32 UTC
oVirt gerrit 92480 0 master MERGED core: Prevent attaching physnets to non OVS clusters 2020-11-03 12:22:32 UTC
oVirt gerrit 92930 0 ovirt-engine-4.2 MERGED core: Add custom physnet parameters into ProviderNetwork 2020-11-03 12:22:32 UTC
oVirt gerrit 92931 0 ovirt-engine-4.2 MERGED core: Map physical network properties from external network 2020-11-03 12:22:33 UTC
oVirt gerrit 92932 0 ovirt-engine-4.2 MERGED core: Prevent attaching physnets to non OVS clusters 2020-11-03 12:22:33 UTC

Description Michael Burman 2018-05-29 07:23:08 UTC
Description of problem:
[AutoDefine] - The external sync of the AutoSyncCommand attaching all external_networks to all clusters types.

As requested in BZ 1530027 - the external_net that is created with auto-define should be attached only to OVS type clusters. The external sync of the provider, attaching the external_net to legacy clusters as well if auto sync enabled on provider and the cluster has external provider enabled.

Version-Release number of selected component (if applicable):
4.2.4-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. Have ovn provider with auto sync enabled
2. Create DC with 2 clusters, ovs and legacy
3. Enable ovn external provider on both clusters
4. Create net1 in DC

Actual results:
external_net is auto defined and created, on creation the external_net is  attached only to ovs type cluster. But on the next sync cycly, it is attached to the legacy type cluster.

Expected results:
external_net is auto defined and created, remain attached only to ovs type clusters. 

Additional info:
See also - BZ 1530027

Comment 1 Michael Burman 2018-05-29 07:29:08 UTC
Created attachment 1445194 [details]
engine log

Comment 2 Alona Kaplan 2018-06-03 11:13:59 UTC
It is a bit problematic to solve the bug.
We don't have an indication whether the network was auto-defined or not. Once auto-syncing, the network is added to all the clusters that have the provider defined.
We don't have a way to differentiate between a regular network to a one that was auto-defined.

Let's schedule a meeting to decide how to solve the issue.
One possibility may be to change the requirements and define the auto-defined network in all the clusters and not just the ovs ones.

Meanwhile, moving the bug to 4.2.5.

Comment 3 Alona Kaplan 2018-06-04 11:27:42 UTC
Another option is to change the auto sync provider process so that external networks with a physical network will be automatically attached only to ovs clusters.

Comment 4 Ales Musil 2018-06-04 11:37:08 UTC
 (In reply to Alona Kaplan from comment #3)
> Another option is to change the auto sync provider process so that external
> networks with a physical network will be automatically attached only to ovs
> clusters.

That is actually what we have discussed with Dominik and I am trying to implement this.

Comment 5 Michael Burman 2018-07-12 08:18:06 UTC
FailedQa on - 4.2.5.2_SNAPSHOT-76.g2d45cde.0.scratch.master.el7ev

Comment 6 Dan Kenigsberg 2018-07-12 13:04:18 UTC
2d45cde is https://code.engineering.redhat.com/gerrit/#/c/143700/ which is upstream 20e078765 which is ovirt-engine-4.2.5.1 which is does not have the code yet.

This is a bug in the nightly builds: 4.2.5.2_SNAPSHOT-76.g2d45cde.0.scratch.master.el7ev is based on a code that is older than that of ovirt-engine-4.2.5.1_SNAPSHOT-75.gde294d4.0.scratch.master (9199da9 restapi: Fix APIv3 deprecated/removed message)

Comment 9 Dan Kenigsberg 2018-07-12 14:12:09 UTC
comment 6 is incorrect. 
build: post ovirt-engine-4.2.5.1  is three commits after restapi:
Fix APIv3 deprecated/removed
as is evident on
https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/heads/ovirt-engine-4.2

Comment 10 Michael Burman 2018-07-16 11:47:29 UTC
Verified on - 4.2.5.2_SNAPSHOT-79.gffafd93.0.scratch.master.el7ev

Comment 11 Sandro Bonazzola 2018-07-31 15:32:02 UTC
This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.