Spec URL: http://file.brq.redhat.com/mskalick/review/golang-github-10gen-escaper.spec SRPM URL: http://file.brq.redhat.com/mskalick/review/golang-github-10gen-escaper-0-0.1.20180528git17fe61c658dcbdcbf246c783f4f7dc97efde3a8b.20180528git17fe61c.fc27.src.rpm Description: escaper lets you create your own formatting syntax Fedora Account System Username: mskalick
That website is inaccessible for me. Could you please repost the files on your Fedorapeople space?
I would like to, but I accidentally broke it so I'm getting Permission denied on fedorapeople.org . And no response on email from admins yet. That's the reason I had to use different file server (sorry, I thought is is accessible). Now I using my google drive - sorry for that. If you have in mind something better, I'm open to it. Spec URL: https://drive.google.com/open?id=17PNjzuGUljAGOHnlKYLmRWUkYo8Vh8Y4 SRPM URL: https://drive.google.com/open?id=13ga9W0GJNmJNLjM9fAuxKP_UM1b5G0fI Description: escaper lets you create your own formatting syntax Fedora Account System Username: mskalick
Please use the new Golang packaging guidelines. Your SPEC looks like a mix of the old and new way: Instead of %global provider_prefix github.com/10gen/escaper %global import_path %{provider_prefix} %global goipath %{import_path} %global commit 17fe61c658dcbdcbf246c783f4f7dc97efde3a8b %global commitdate 20180528 Simply use: %global goipath github.com/10gen/escaper %global commit 17fe61c658dcbdcbf246c783f4f7dc97efde3a8b - Not needed, it is set by gometa: %global debug_package %{nil} - The Release tag is automatically calculated, simply use Release: 0.1%{?dist} - Use URL: %{gourl} - Not needed, it is set by %gometa # e.g. el6 has ppc64 arch without gcc-go, so EA tag is required ExclusiveArch: %{ix86} x86_64 %{arm} aarch64 ppc64le s390x # If go_compiler is not set to 1, there is no virtual provide. Use golang instead. BuildRequires: %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang} - Remove the unnecessary condition: %if 0%{?with_devel} - Not needed it is set automatically: Provides: golang(%{import_path}) = %{version}-%{release} - Use the %gochecks macro for the tests: %check %gochecks - Not needed: #define license tag if not already defined %{!?_licensedir:%global license %doc} - %changelog should be: * Mon May 28 2018 mskalick - 0-0.1.20180528git17fe61c - Capitalize the initial letter of the summary.
Thanks for the feedback. (In reply to Robert-André Mauchin from comment #3) > - Not needed, it is set by gometa: > > %global debug_package %{nil} > Without this I'm getting error: Empty %files file /builddir/build/BUILD/escaper-17fe61c658dcbdcbf246c783f4f7dc97efde3a8b/debugsourcefiles.list error from mock build and scratch-build [1]. So I've left it in spec. Update Spec URL: https://drive.google.com/open?id=1iLmsFcVRoXvvyIIWlSeNoUN9aUE9Vg59 SRPM URL: https://drive.google.com/open?id=1NqqgQgCMzq2uIRQycW-0qD2vkcWlwFep Description: Escaper lets you create your own formatting syntax Fedora Account System Username: mskalick https://drive.google.com/open?id=1iLmsFcVRoXvvyIIWlSeNoUN9aUE9Vg59 [1] https://koji.fedoraproject.org/koji/taskinfo?taskID=27320873
The issue seems to be you don't put the files into the devel subpackage, but in the main package, which is not noarched. Fix it by placing them in the correct devel subpackage: %files devel -f devel.file-list %license LICENSE %doc README.md Thus you should be able to remove %global debug_package %{nil}.
It seems find-debuginfo.sh is automatically run when there is a %build section. Remove the extraneous %build section and it will work. Successful Koji run: https://koji.fedoraproject.org/koji/taskinfo?taskID=27326855 Fix the two aforementioned issues and I'll approve your package.
Fixed. Spec URL: https://drive.google.com/open?id=1CDqalO0jT7DeV4LXXnHI8Akf7vWt5sx- SRPM URL: https://drive.google.com/open?id=1WkH8sZDA4UOhBbW_MXOKHY2T2rPCHn0S Description: Escaper lets you create your own formatting syntax Fedora Account System Username: mskalick
Note: Bugzilla added Spec URL: hyperlink wrong (it's needed to copy also the last "-")
- Latest version packaged - License ok - Builds in Mock - No rpmlint errors - Conforms to the Packaging Guidelines Package approved.
Thanks for quick review and useful comments.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-10gen-escaper