Bug 1583670 – Backport NFP PMD's "net/nfp: fix lock file usage"

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1583670 - Backport NFP PMD's "net/nfp: fix lock file usage"

Summary:	Backport NFP PMD's "net/nfp: fix lock file usage"

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	openvswitch (Show other bugs)
Sub Component:
Version:	7.6
Hardware:	Unspecified Unspecified

Priority	unspecified Severity high
Target Milestone:	rc
Target Release:	---
Assigned To:	Timothy Redaelli
QA Contact:	Jean-Tsung Hsiao
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:	1568301
	Show dependency tree / graph

Reported:	2018-05-29 08:46 EDT by Pablo Cascon
Modified:	2018-07-09 12:44 EDT (History)
CC List:	6 users (show)

See Also:
Fixed In Version:	openvswitch-2.9.0-43.el7fdn
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-06-21 09:36:37 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2018:1962	None	None	None	2018-06-21 09:36 EDT

Groups: None (edit)

Description Pablo Cascon 2018-05-29 08:46:45 EDT

Please backport the following DPDK commit:

http://dpdk.org/browse/dpdk/commit/?id=5f6ed2f4e0cb79580c0bedba2bd764a39923d7ec

commit 5f6ed2f4e0cb79580c0bedba2bd764a39923d7ec
Author: Alejandro Lucero <alejandro.lucero@netronome.com>
Date:   Wed May 23 13:28:56 2018 +0100

    net/nfp: fix lock file usage
    
    DPDK apps can be executed as non-root users but current NFP lock
    file for avoiding concurrent accesses to CPP interface is precluding
    this option or requires to modify system file permissions.
    
    When the NFP device is bound to VFIO, this driver does not allow this
    concurrent access, so the lock file is not required at all.
    
    OVS-DPDK as executed in RedHat distributions is the main NFP user
    needing this fix.
    
    Fixes: c7e9729da6b5 ("net/nfp: support CPP")
    
    Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>

Comment 5 Jean-Tsung Hsiao 2018-06-18 20:35:05 EDT

Hi Tim,

I am using OVS 2.9.0-47. But, as a non-root user, still got "A CPP handle can not be obtained" ERR.

So, need your advice here as how to verify the fix.

Thanks!

Jean

Comment 6 Timothy Redaelli 2018-06-19 04:26:30 EDT

Hi,
there is another bug for root usage (bz#1568301) and so you need to run OVS as root (just comment the OVS_USER_ID in /etc/sysconfig/openvswitch as usual) in order to verify this bug

Comment 7 Jean-Tsung Hsiao 2018-06-19 09:40:27 EDT

(In reply to Timothy Redaelli from comment #6)
> Hi,
> there is another bug for root usage (bz#1568301) and so you need to run OVS
> as root (just comment the OVS_USER_ID in /etc/sysconfig/openvswitch as
> usual) in order to verify this bug

Commenting out the OVS_USER_ID in /etc/sysconfig/openvswitch is the workaround, and we've been testing that for a while.

So, what's the fix for ?

Please clarify.

Thanks!

Jean

Comment 8 Jean-Tsung Hsiao 2018-06-19 10:16:06 EDT

The bug fix has been verified with many netperf test runs over OVS-dpdk/{vxlan,geneve}/nfp tunnel.

Comment 10 errata-xmlrpc 2018-06-21 09:36:37 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:1962

Note You need to log in before you can comment on or make changes to this bug.