Bug 1584406 - prov.set_vlan() method didn't set the vnicprofiles identifier
Summary: prov.set_vlan() method didn't set the vnicprofiles identifier
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.9.3
Assignee: Alona Kaplan
QA Contact: Ilanit Stein
URL:
Whiteboard: rhev
Depends On: 1574351
Blocks: 1609809
TreeView+ depends on / blocked
 
Reported: 2018-05-30 20:03 UTC by Satoe Imaishi
Modified: 2022-07-09 09:53 UTC (History)
11 users (show)

Fixed In Version: 5.9.3.1
Doc Type: If docs needed, set a value
Doc Text:
Bug #1449157 doc text was extended to include the fix in this bug. Copying the doc text of bug #1449157 The purpose of the 'vm_fields.vlan' field was changed for v4 RHV providers. * In the v3 API it represents the 'network name'. * In the v4 API (if 'use_ovirt_engine_sdk' is specified in the setting as 'true') it represents the 'vnic profile id' or 'profile name (network name)'. Example: /api/provision_requests 1. Provision a virtual machine with one vNic where the 'profile_id' of the vNic is '9c61ef19-f8aa-4ce3-bc24-49d211c1d019'. "vm_fields" : { ... "vlan" : "9c61ef19-f8aa-4ce3-bc24-49d211c1d019" } 2. Provision a virtual machine with one vNic where the 'profile_name' of the vNic is 'ovirtmgmt' and the network name is 'ovirtmgmt'. "vm_fields" : { ... "vlan" : "ovirtmgmt (ovirtmgmt)" } 3. Provision a virtual machine with one vNic where the vNic has no profile. "vm_fields" : { ... "vlan" : "<Empty>" } 4. Provision a virtual machine keeping the source template vNics. "vm_fields" : { ... "vlan" : "<Template>" }
Clone Of: 1574351
: 1609809 (view as bug list)
Environment:
5.9.1
Last Closed: 2018-07-12 13:15:53 UTC
Category: ---
Cloudforms Team: RHEVM
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github ManageIQ manageiq-providers-ovirt pull 254 0 None None None 2018-05-30 20:03:48 UTC
Red Hat Knowledge Base (Solution) 3618311 0 None None None 2018-10-09 01:52:37 UTC
Red Hat Product Errata RHSA-2018:2184 0 None None None 2018-07-12 13:16:43 UTC

Comment 2 CFME Bot 2018-05-30 20:16:41 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:

https://github.com/ManageIQ/manageiq/commit/fdd5b2e568e52042ccb233cff19b0dd08b3e5482
commit fdd5b2e568e52042ccb233cff19b0dd08b3e5482
Author:     Adam Grare <agrare>
AuthorDate: Wed May 30 11:49:19 2018 -0400
Commit:     Adam Grare <agrare>
CommitDate: Wed May 30 11:49:19 2018 -0400

    Merge pull request #17495 from AlonaKaplan/required_description

    Adding the profile description option to the provision error message
    (cherry picked from commit f27749569895ad0249877debf246bdfa2b5134c3)

    https://bugzilla.redhat.com/show_bug.cgi?id=1578393
    https://bugzilla.redhat.com/show_bug.cgi?id=1584406

 product/dialogs/miq_dialogs/miq_provision_redhat_dialogs_clone_to_vm.yaml | 1 +
 product/dialogs/miq_dialogs/miq_provision_redhat_dialogs_template.yaml | 3 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

Comment 3 CFME Bot 2018-05-30 20:36:40 UTC
New commit detected on ManageIQ/manageiq-providers-ovirt/gaprindashvili:

https://github.com/ManageIQ/manageiq-providers-ovirt/commit/946a17fe35a444a26113a15c463ff0f95179771f
commit 946a17fe35a444a26113a15c463ff0f95179771f
Author:     Boris Od <boris.od>
AuthorDate: Wed May 30 08:07:03 2018 -0400
Commit:     Boris Od <boris.od>
CommitDate: Wed May 30 08:07:03 2018 -0400

    Merge pull request #254 from AlonaKaplan/profile_description

    Profile description
    (cherry picked from commit 1c70679ac8b5ffb5163df217848c98447bc8a795)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1584406

 app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb | 40 +-
 app/models/manageiq/providers/redhat/infra_manager/provision_workflow.rb | 11 +
 spec/models/manageiq/providers/redhat/infra_manager/provision/configuration/network_spec.rb | 30 +-
 3 files changed, 68 insertions(+), 13 deletions(-)

Comment 4 Ilanit Stein 2018-06-07 11:08:59 UTC
Verified on 5.9.3.1/RHV-4.2.3

POST
Content-Type: application/json

URL: https://<cfme ip address>/api/provision_requests

Body:

{"additional_values": {"request_id": "1001"}, "ems_custom_attributes": {}, "miq_custom_attributes": {}, "requester": {"auto_approve": true, "owner_email": "jdoe", "owner_first_name": "John", "owner_last_name": "Doe", "user_name": "admin"}, "tags": {"cc": "001", "network_location": "Internal"}, "template_fields": {"guid": "53dd9846-5462-4be9-ac0c-cea53e1d6c5a"}, "version": "1.1", "vm_fields": {"number_of_cpus": 1, "provision_type": "native_clone", "vlan": "ovirt-mgmt (ovirtmgmt)", "vm_memory": "2048", "vm_name": "2_vm"}}


VM was provisioned successfully, with network interface ovirtmgmt.

Also tested the same, request, but with 
vlan: "vnic profile ID" = Taken from RHV via restapi:
GET
https://<RHV fqdn>/ovirt-engine/api/networks/<Network GUID>/vnicprofiles

VM was provisioned successfully, with network interface ovirtmgmt.


@Alona,

Would you please add a doc text to this bug for this addition of vlan field supporting now also "profile name (network name)".
Need to emphasize that a space is required between the "profile name" and 
"(network name)", otherwise request will fail.

This doc will be an extension to this doc text:
https://bugzilla.redhat.com/1449157 

Thanks.

Comment 5 Alona Kaplan 2018-06-07 12:16:27 UTC
(In reply to Ilanit Stein from comment #4)
> Verified on 5.9.3.1/RHV-4.2.3
> 
> POST
> Content-Type: application/json
> 
> URL: https://<cfme ip address>/api/provision_requests
> 
> Body:
> 
> {"additional_values": {"request_id": "1001"}, "ems_custom_attributes": {},
> "miq_custom_attributes": {}, "requester": {"auto_approve": true,
> "owner_email": "jdoe", "owner_first_name": "John",
> "owner_last_name": "Doe", "user_name": "admin"}, "tags": {"cc": "001",
> "network_location": "Internal"}, "template_fields": {"guid":
> "53dd9846-5462-4be9-ac0c-cea53e1d6c5a"}, "version": "1.1", "vm_fields":
> {"number_of_cpus": 1, "provision_type": "native_clone", "vlan": "ovirt-mgmt
> (ovirtmgmt)", "vm_memory": "2048", "vm_name": "2_vm"}}
> 
> 
> VM was provisioned successfully, with network interface ovirtmgmt.
> 
> Also tested the same, request, but with 
> vlan: "vnic profile ID" = Taken from RHV via restapi:
> GET
> https://<RHV fqdn>/ovirt-engine/api/networks/<Network GUID>/vnicprofiles
> 
> VM was provisioned successfully, with network interface ovirtmgmt.
> 
> 
> @Alona,
> 
> Would you please add a doc text to this bug for this addition of vlan field
> supporting now also "profile name (network name)".
> Need to emphasize that a space is required between the "profile name" and 
> "(network name)", otherwise request will fail.
> 
> This doc will be an extension to this doc text:
> https://bugzilla.redhat.com/1449157 
> 
> Thanks.

Done

Comment 6 Alona Kaplan 2018-06-07 12:23:00 UTC
(In reply to Alona Kaplan from comment #5)
> (In reply to Ilanit Stein from comment #4)
> > Verified on 5.9.3.1/RHV-4.2.3
> > 
> > POST
> > Content-Type: application/json
> > 
> > URL: https://<cfme ip address>/api/provision_requests
> > 
> > Body:
> > 
> > {"additional_values": {"request_id": "1001"}, "ems_custom_attributes": {},
> > "miq_custom_attributes": {}, "requester": {"auto_approve": true,
> > "owner_email": "jdoe", "owner_first_name": "John",
> > "owner_last_name": "Doe", "user_name": "admin"}, "tags": {"cc": "001",
> > "network_location": "Internal"}, "template_fields": {"guid":
> > "53dd9846-5462-4be9-ac0c-cea53e1d6c5a"}, "version": "1.1", "vm_fields":
> > {"number_of_cpus": 1, "provision_type": "native_clone", "vlan": "ovirt-mgmt
> > (ovirtmgmt)", "vm_memory": "2048", "vm_name": "2_vm"}}
> > 
> > 
> > VM was provisioned successfully, with network interface ovirtmgmt.
> > 
> > Also tested the same, request, but with 
> > vlan: "vnic profile ID" = Taken from RHV via restapi:
> > GET
> > https://<RHV fqdn>/ovirt-engine/api/networks/<Network GUID>/vnicprofiles
> > 
> > VM was provisioned successfully, with network interface ovirtmgmt.
> > 
> > 
> > @Alona,
> > 
> > Would you please add a doc text to this bug for this addition of vlan field
> > supporting now also "profile name (network name)".
> > Need to emphasize that a space is required between the "profile name" and 
> > "(network name)", otherwise request will fail.
> > 
> > This doc will be an extension to this doc text:
> > https://bugzilla.redhat.com/1449157

I've updated the doc text of bug #1449157

> > 
> > Thanks.
> 
> Done

Comment 8 errata-xmlrpc 2018-07-12 13:15:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2184


Note You need to log in before you can comment on or make changes to this bug.