Bug 1584651 - RFE: iface-dumpxml should include all active and --inactive conifg
Summary: RFE: iface-dumpxml should include all active and --inactive conifg
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libvirt
Version: unspecified
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-05-31 11:40 UTC by ricky.tigg
Modified: 2024-12-17 12:49 UTC (History)
10 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-17 12:49:57 UTC
Embargoed:


Attachments (Terms of Use)
Sample – virt-manager v. 1.5.1-1 – enp0s25 interface (23.66 KB, image/png)
2018-05-31 11:40 UTC, ricky.tigg
no flags Details

Description ricky.tigg 2018-05-31 11:40:00 UTC
Created attachment 1446243 [details]
Sample – virt-manager v. 1.5.1-1 – enp0s25 interface

Enhancements request – Noticeable: 
– Outputs resulting from 'iface-dumpxml <network_interface>' are incomplete.
– Outputs associated to network interfaces to be available in a non-xml format in order to improve readability.

Version-Release number of component: libvirt-client.x86_64 4.1.0-2.fc28 @fedora

Actual results (e.g target: enp0s25): 
virsh # iface-dumpxml enp0s25
<interface type='ethernet' name='enp0s25'>
  <protocol family='ipv4'>
    <ip address='192.168.0.3' prefix='24'/>
  </protocol>
  <protocol family='ipv6'>
    <ip address='2a02:2788:7c8:4dd:224:e8ff:fecc:f327' prefix='64'/>
    <ip address='fe80::224:e8ff:fecc:f327' prefix='64'/>
  </protocol>
  <link speed='1000' state='up'/>
  <mac address='00:24:e8:cc:f3:27'/>
</interface>

Improved results: All information produced by virt-manager component (virt-manager.noarch 1.5.1-1.fc28 @fedora) and then visible in Virtual Machine Manager –attachment– to be as well present from above virsh output. For instance mentions of 'onboot','DHCP', 'wired'.

Additional info: Interactive virsh run. Active system language: Finnish.

Comment 1 Cole Robinson 2018-06-05 18:18:06 UTC
I don't think we will be adding a mode to virsh to output prettier info than XML... virsh isn't really the place for those types of things, it's largely just a dumb tool around libvirt APIs, which only returns this data in XML format

If I recall iface/netcf APIs do have an annoying habit of requiring two commands to get all data about an interface: 'iface-dumpxml' and 'iface-dumpxml --inactive'. Does the latter command show you onboot status? If not virt-manager might just be reflecting the default value here

Comment 2 ricky.tigg 2018-06-05 19:43:37 UTC
virsh # iface-list --all
 Name                 State      MAC Address
---------------------------------------------------
 enp0s25              active     00:24:e8:cc:f3:27
 lo                   active     00:00:00:00:00:00
 wlp12s0              inactive   66:42:be:aa:52:8f

virsh # iface-dumpxml --inactive enp0s25
<interface type='ethernet' name='enp0s25'>
  <start mode='onboot'/>
  <protocol family='ipv4'>
    <dhcp/>
  </protocol>
  <mac address='00:24:e8:cc:f3:27'/>
</interface>

It appears that the purpose of option '--inactive' along with the command 'iface-dumpxml' is named inadequately since it allows for the validation of an active interface and even returns an output. Outputs resulting from commands 'iface-dumpxml' and 'iface-dumpxml --inactive' do not achieve output illustrated in attachment 1446243 [details] even combined together; Mode 'Static' regarding IPv6 is still missing. Obviously a command that combines both CLI outputs would be appropriate.

Comment 3 Daniel Berrangé 2024-12-17 12:49:57 UTC
Thank you for reporting this issue to the libvirt project. Unfortunately we have been unable to resolve this issue due to insufficient maintainer capacity and it will now be closed. This is not a reflection on the possible validity of the issue, merely the lack of resources to investigate and address it, for which we apologise. If you none the less feel the issue is still important, you may choose to report it again at the new project issue tracker https://gitlab.com/libvirt/libvirt/-/issues The project also welcomes contribution from anyone who believes they can provide a solution.


Note You need to log in before you can comment on or make changes to this bug.