Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1585815

Summary:	[starter-ca-central-1] during 3.9->3.10 upgrade, unquoted options in /etc/sysconfig/atomic-openshift-master-api cause atomic-openshift-node crash loop
Product:	OpenShift Container Platform	Reporter:	Justin Pierce <jupierce>
Component:	Installer	Assignee:	Michael Gugino <mgugino>
Status:	CLOSED ERRATA	QA Contact:	liujia <jiajliu>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.10.0	CC:	aos-bugs, jokerman, mmccomas
Target Milestone:	---
Target Release:	3.10.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: systemd sysconfig env file parsed differently than how master api/controller parses native env file. Consequence: sysconfig env file migrated to master.env file. Lack of quotes around values that contain spaces in env file causes master processes to be misconfigured when values contain spaces. Fix: Created custom parser to ensure items with unescaped or unquoted strings are properly quoted. Result: Migrated env files are properly quoted and master processes are configured properly	Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-01-10 09:27:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Justin Pierce 2018-06-04 20:02:43 UTC

Description of problem:
During 3.9->3.10 upgrade, unquoted OPTIONS in /etc/sysconfig/atomic-openshift-master-api. e.g.
OPTIONS=--loglevel=2 --listen=https://0.0.0.0:443 --master=https://somehost.internal

get migrated into master.env during the control plan upgrade. The line gets placed verbatim into master.env and subsequently sourced by the master. In this case, the lack of quotes makes the source of master.env fail.


Version-Release number of the following components:
v3.10.0-0.54.0

How reproducible:
100%

Steps to Reproduce:
1. In a 3.9 cluster, include unquoted OPTIONS var like example in Description
2. Upgrade to 3.10 control plane
3. Observe crash loop in atomic-openshift-node service

Actual results:
Crash loop during control-plane upgrade.

Expected results:
Several options:
(1) Quote the key value pairs moving into master.env if quotes are missing
(2) source /etc/sysconfig/atomic-openshift-master-* as a test and stop the install if the file cannot be consumed
(3) Require values in the inventory.

Comment 2 Michael Gugino 2018-07-06 18:02:06 UTC

PR Merged in master: https://github.com/openshift/openshift-ansible/pull/8733

Backport to 3.10 created: https://github.com/openshift/openshift-ansible/pull/9095#issuecomment-403087087

Comment 7 errata-xmlrpc 2019-01-10 09:27:09 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0026