Bug 1586018 - (f)Setxattr and (f)removexattr invalidates the stat cache in md-cache
Summary: (f)Setxattr and (f)removexattr invalidates the stat cache in md-cache
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: md-cache
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-05 10:24 UTC by Poornima G
Modified: 2018-10-23 15:10 UTC (History)
1 user (show)

Fixed In Version: glusterfs-5.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-23 15:10:44 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Poornima G 2018-06-05 10:24:33 UTC
Description of problem:
The (f)Setxattr and (f)removexattr do not carry prestat and poststat, hence the stat cache is invalidated after every (f)Setxattr and (f)removexattr fop.
With 4.0 the dictionary has been XDR encoded, hence send the prestat and poststat in dictionary.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2018-06-05 10:37:11 UTC
REVIEW: https://review.gluster.org/16101 (md-cache: Do not invalidate cache post set/remove xattr) posted (#6) for review on master by Poornima G

Comment 2 Worker Ant 2018-07-11 04:12:32 UTC
COMMIT: https://review.gluster.org/16101 committed in master by "Amar Tumballi" <amarts> with a commit message- md-cache: Do not invalidate cache post set/remove xattr

Since setxattr and removexattr fops cbk do not carry poststat,
the stat cache was being invalidated in setxatr/remoxattr cbk.
Hence the further lookup wouldn't be served from cache.
To prevent this invalidation, md-cache is modified to get
the poststat in set/removexattr_cbk in dict.

Co-authored with Xavi Hernandez.

Change-Id: I6b946be2d20b807e2578825743c25ba5927a60b4
fixes: bz#1586018
Signed-off-by: Xavi Hernandez <xhernandez>
Signed-off-by: Poornima G <pgurusid>

Comment 3 Shyamsundar 2018-10-23 15:10:44 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.