Created attachment 1447846 [details]
Patch against 3.12.2
this is a backport request into RHEL 7.5:
pmdammv: resolve an instance domain setup problem
Several people (marko, lzap, tallpaul) have reported this
one, finally got to the bottom of it. The symptoms are
"Unknown or illegal instance domain identifier" errors on
indom lookups, sometimes. Root cause was a logic error
in pmdammv indom setup code incorrectly overwriting count
and offset local variables while parsing mappings.
To exercise the fix I've modernized qa/src/indom.c and
used it in new test qa/1422 to tickle the problem using
a canned MMV mapping which is known to expose it.
The original bug report (against Parfait) is this one:
I have successfully backported the patch and made a build:
I am currently testing it. Attaching the patch:
qa/1422 | 68 ++++++++++
qa/1422.out | 33 +++++
qa/GNUmakefile | 4 +-
qa/GNUmakefile.install | 3 +-
qa/group | 1 +
qa/mmv/GNUmakefile | 16 +++
qa/mmv/GNUmakefile.install | 6 +
qa/mmv/KeyboardReader.xz | Bin 0 -> 1220 bytes
qa/mmv/pytest.xz | Bin 0 -> 416 bytes
qa/src/indom.c | 253 +++++++++----------------------------
src/pmdas/mmv/src/mmv.c | 48 ++++---
11 files changed, 216 insertions(+), 216 deletions(-)
The binary files are not part of the patch.
installing pcp-zeroconf makes some logging configuration changes:
- changing the default PMLOGGER_INTERVAL to 10 seconds in /etc/sysconfig/pmlogger
- making more pmlogconf clauses included in default logs (esp: proc metrics)
I don't think any of the default logger configurations record mmv.* metrics though, so that part would have come from somewhere. As far as I know, your pmlc instruction would -add- new mmv logging rather than modify a previous mmv logging. You may need to first send a 'log mandatory off mmv' to kill that ... not sure.
For googlers, the error will be fixed in the next upcoming version of PCP, it will not be backported into 7.5 however.
Just to make things clear - the bug was fixed in PCP version 4.1 or above.