Bug 1588260 - Review Request: golang-github-cosmos72-gomacro - Interactive Go interpreter and debugger
Summary: Review Request: golang-github-cosmos72-gomacro - Interactive Go interpreter a...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-07 01:41 UTC by Elliott Sales de Andrade
Modified: 2018-06-20 14:46 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-06-20 14:46:58 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2018-06-07 01:41:58 UTC
Spec URL: http://qulogic.fedorapeople.org//gomacro.spec
SRPM URL: http://qulogic.fedorapeople.org//gomacro-2.7-1.fc28.src.rpm

Description:

gomacro is an almost complete Go interpreter, implemented in pure Go. It offers
both an interactive REPL and a scripting mode, and does not require a Go
toolchain at runtime (except in one very specific case: import of a third party
package at runtime).

Comment 1 Elliott Sales de Andrade 2018-06-07 01:52:52 UTC
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=27463893

I'm not sure why I need to disable debugsource packages; it seems to be something to do with Go packaging macros.

I also don't know why the source package is inconsistent between arches. These files exist in the tarball, but seem to disappear in the resulting package. This seems like a bug in the %goinstall macro.

Comment 2 Elliott Sales de Andrade 2018-06-07 03:10:31 UTC
OK, managed to fix the latter problem by explicitly passing a few more paths to %goinstall. Updated original link.

New scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=27464225

Comment 3 Robert-André Mauchin 🐧 2018-06-09 22:21:24 UTC
(In reply to Elliott Sales de Andrade from comment #1)
> I also don't know why the source package is inconsistent between arches.
> These files exist in the tarball, but seem to disappear in the resulting
> package. This seems like a bug in the %goinstall macro.

This is normal. See https://github.com/cosmos72/gomacro/tree/master/imports/syscall there are files which are installed only for some architectures

_amd64 for x86_64
_386 fox x86
_arm for ARM devices

When that is the case just make your package arched, not noarch.

(In reply to Elliott Sales de Andrade from comment #2)
> OK, managed to fix the latter problem by explicitly passing a few more paths
> to %goinstall. Updated original link.
> 
Remove this and make your package noarch.


I would name this package golang-github-cosmos72-gomacro and make a gomacro subpackage for the binary.


I don't know why the debug infos is not extnacted, it should work. You should use %global debug_package %{nil} to disable debug info.

Comment 4 Elliott Sales de Andrade 2018-06-10 02:35:20 UTC
Spec URL: https://qulogic.fedorapeople.org/golang-github-cosmos72-gomacro.spec
SRPM URL: https://qulogic.fedorapeople.org/golang-github-cosmos72-gomacro-2.7-1.fc28.src.rpm
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=27520537

(In reply to Robert-André Mauchin from comment #3)
> (In reply to Elliott Sales de Andrade from comment #1)
> > I also don't know why the source package is inconsistent between arches.
> > These files exist in the tarball, but seem to disappear in the resulting
> > package. This seems like a bug in the %goinstall macro.
> 
> This is normal. See
> https://github.com/cosmos72/gomacro/tree/master/imports/syscall there are
> files which are installed only for some architectures
> 
> _amd64 for x86_64
> _386 fox x86
> _arm for ARM devices
> 
> When that is the case just make your package arched, not noarch.
> 

OK, made it arched.

> (In reply to Elliott Sales de Andrade from comment #2)
> > OK, managed to fix the latter problem by explicitly passing a few more paths
> > to %goinstall. Updated original link.
> > 
> Remove this and make your package noarch.
> 

I assume you mean the other way.

> 
> I would name this package golang-github-cosmos72-gomacro and make a gomacro
> subpackage for the binary.
> 

Done.

> 
> I don't know why the debug infos is not extnacted, it should work. You
> should use %global debug_package %{nil} to disable debug info.

Debug info is extracted; it's debug sources that are broken. In any case, the %undefine at the beginning fixes it.

Comment 5 Robert-André Mauchin 🐧 2018-06-10 12:46:38 UTC
Package approved.

Comment 6 Gwyn Ciesla 2018-06-11 03:46:01 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-cosmos72-gomacro

Comment 7 Fedora Update System 2018-06-11 05:38:34 UTC
golang-github-cosmos72-gomacro-2.7-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ec1de95e1

Comment 8 Fedora Update System 2018-06-11 16:32:25 UTC
golang-github-cosmos72-gomacro-2.7-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ec1de95e1

Comment 9 Fedora Update System 2018-06-20 14:46:58 UTC
golang-github-cosmos72-gomacro-2.7-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.