Bug 1588461
| Summary: | [backup-api] Amend of snapshot disk that attached to a backup VM failed when updating the snapshot disk | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Eyal Shenitzky <eshenitz> |
| Component: | BLL.Storage | Assignee: | Tal Nisan <tnisan> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Evelina Shames <eshames> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.3.0 | CC: | bugs |
| Target Milestone: | ovirt-4.3.0 | Flags: | rule-engine:
ovirt-4.3+
|
| Target Release: | 4.3.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ovirt-engine-4.3.0_alpha | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-02-13 07:43:44 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1583046 | ||
Verified on engine 4.3.0-0.8.rc2.el7. This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019. Since the problem described in this bug report should be resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Description of problem: When having a backup VM with another VM snapshot attached to it as a disk, if the user will try to update the disk (edit) via the UI the update will succeed but the engine will try to amend the disk and the operation will fail. Version-Release number of selected component (if applicable): 4.3.0_master - from commit 817759dfe6a2e04c4b67f9036069d3cec6cac6cf How reproducible: 100% Steps to Reproduce: 1. Create a VM with disk [BASE-VM] 2. Create a snapshot to BASE-VM 3. Create another VM [BACKUP-VM] 3. Via rest-api, attach BASE-VM snapshot to BACKUP-VM 4. Try to edit the BACKUP-VM snapshot disk via the UI (press on 'edit' and 'ok') Actual results: Update operation succeeds but the amend operation initiated and failed Expected results: The amend operation should not occur in this flow. Additional info: engine.log: 2018-06-07 14:52:52,054+03 INFO [org.ovirt.engine.core.bll.storage.disk.UpdateVmDiskCommand] (default task-42) [0ce4f102-9362-4ebe-907c-ff186f715be0] Lock Acquired to object 'EngineLock:{exclusiveLocks='', sharedLocks='[c5fda079-a356-4124-8112-288b4f6ecc21=VM, 4921da27-04a2-4f39-b957-d214ac7e8067=VM]'}' 2018-06-07 14:52:52,155+03 INFO [org.ovirt.engine.core.bll.storage.disk.UpdateVmDiskCommand] (default task-42) [0ce4f102-9362-4ebe-907c-ff186f715be0] Running command: UpdateVmDiskCommand internal: false. Entities affected : ID: bd12ff13-2503-43ac-89af-d4325d90af79 Type: DiskAction group EDIT_DISK_PROPERTIES with role type USER 2018-06-07 14:52:56,983+03 INFO [org.ovirt.engine.core.bll.storage.disk.image.AmendImageGroupVolumesCommand] (default task-42) [4a7bc4a1] Lock Acquired to object 'EngineLock:{exclusiveLocks='[bd12ff13-2503-43ac-89af-d4325d90af79=DISK]', sharedLocks='[c5fda079-a356-4124-8112-288b4f6ecc21=VM, 4921da27-04a2-4f39-b957-d214ac7e8067=VM]'}' 2018-06-07 14:52:57,106+03 INFO [org.ovirt.engine.core.bll.storage.disk.image.AmendImageGroupVolumesCommand] (default task-42) [4a7bc4a1] Running command: AmendImageGroupVolumesCommand internal: true. Entities affected : ID: bd12ff13-2503-43ac-89af-d4325d90af79 Type: DiskAction group EDIT_DISK_PROPERTIES with role type USER 2018-06-07 14:52:57,136+03 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (default task-42) [4a7bc4a1] EVENT_ID: USER_AMEND_IMAGE_START(1,328), Started to amend base_vm_Disk1 2018-06-07 14:52:57,145+03 INFO [org.ovirt.engine.core.bll.storage.disk.image.AmendImageGroupVolumesCommand] (default task-42) [4a7bc4a1] Lock freed to object 'EngineLock:{exclusiveLocks='[bd12ff13-2503-43ac-89af-d4325d90af79=DISK]', sharedLocks='[c5fda079-a356-4124-8112-288b4f6ecc21=VM, 4921da27-04a2-4f39-b957-d214ac7e8067=VM]'}' 2018-06-07 14:52:57,145+03 INFO [org.ovirt.engine.core.bll.storage.disk.UpdateVmDiskCommand] (default task-42) [4a7bc4a1] Lock freed to object 'EngineLock:{exclusiveLocks='', sharedLocks='[c5fda079-a356-4124-8112-288b4f6ecc21=VM, 4921da27-04a2-4f39-b957-d214ac7e8067=VM]'}' 2018-06-07 14:52:57,170+03 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (default task-42) [4a7bc4a1] EVENT_ID: USER_UPDATE_VM_DISK(88), VM vm1 base_vm_Disk1 disk was updated by admin@internal-authz. 2018-06-07 14:52:57,284+03 INFO [org.ovirt.engine.core.bll.storage.disk.image.AmendImageGroupVolumesCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] Starting child command 1 of 1, image '5c463df7-65bf-409a-837c-8aeffb3cee8a' 2018-06-07 14:52:57,352+03 INFO [org.ovirt.engine.core.bll.storage.disk.image.AmendVolumeCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] Running command: AmendVolumeCommand internal: true. 2018-06-07 14:52:57,360+03 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVolumeInfoVDSCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] START, GetVolumeInfoVDSCommand(HostName = h1, GetVolumeInfoVDSCommandParameters:{hostId='8edde004-8086-4f01-b1d8-dc31e25f67d6', storagePoolId='6c477009-de73-4d0c-99f2-3b2da3eedb08', storageDomainId='16cf9c6c-ba0b-4c52-b254-f948c021f52a', imageGroupId='bd12ff13-2503-43ac-89af-d4325d90af79', imageId='5c463df7-65bf-409a-837c-8aeffb3cee8a'}), log id: 65999f5 2018-06-07 14:52:57,384+03 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVolumeInfoVDSCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] FINISH, GetVolumeInfoVDSCommand, return: org.ovirt.engine.core.common.businessentities.storage.DiskImage@68c688b0, log id: 65999f5 2018-06-07 14:52:57,430+03 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.AmendVolumeVDSCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] START, AmendVolumeVDSCommand(HostName = h1, AmendVolumeVDSCommandParameters:{hostId='8edde004-8086-4f01-b1d8-dc31e25f67d6', storageDomainId='16cf9c6c-ba0b-4c52-b254-f948c021f52a', jobId='20d77111-9e21-4908-bccc-12e1208e1f3d', imageId='bd12ff13-2503-43ac-89af-d4325d90af79', volumeId='5c463df7-65bf-409a-837c-8aeffb3cee8a', generation='9', qcowCompat='Undefined'}), log id: 610cd375 2018-06-07 14:52:57,433+03 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.AmendVolumeVDSCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] Failed in 'AmendVolumeVDS' method 2018-06-07 14:52:57,437+03 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] EVENT_ID: VDS_BROKER_COMMAND_FAILURE(10,802), VDSM h1 command AmendVolumeVDS failed: Unsupported qcow2 compat Undefined 2018-06-07 14:52:57,438+03 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.AmendVolumeVDSCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] Command 'org.ovirt.engine.core.vdsbroker.vdsbroker.AmendVolumeVDSCommand' return value 'StatusOnlyReturn [status=Status [code=100, message=Unsupported qcow2 compat Undefined]]' 2018-06-07 14:52:57,438+03 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.AmendVolumeVDSCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] HostName = h1 2018-06-07 14:52:57,438+03 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.AmendVolumeVDSCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] Command 'AmendVolumeVDSCommand(HostName = h1, AmendVolumeVDSCommandParameters:{hostId='8edde004-8086-4f01-b1d8-dc31e25f67d6', storageDomainId='16cf9c6c-ba0b-4c52-b254-f948c021f52a', jobId='20d77111-9e21-4908-bccc-12e1208e1f3d', imageId='bd12ff13-2503-43ac-89af-d4325d90af79', volumeId='5c463df7-65bf-409a-837c-8aeffb3cee8a', generation='9', qcowCompat='Undefined'})' execution failed: VDSGenericException: VDSErrorException: Failed to AmendVolumeVDS, error = Unsupported qcow2 compat Undefined, code = 100 2018-06-07 14:52:57,438+03 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.AmendVolumeVDSCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] FINISH, AmendVolumeVDSCommand, return: , log id: 610cd375 2018-06-07 14:52:57,439+03 ERROR [org.ovirt.engine.core.bll.storage.disk.image.AmendVolumeCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-97) [4a7bc4a1] Command 'org.ovirt.engine.core.bll.storage.disk.image.AmendVolumeCommand' failed: EngineException: org.ovirt.engine.core.vdsbroker.vdsbroker.VDSErrorException: VDSGenericException: VDSErrorException: Failed to AmendVolumeVDS, error = Unsupported qcow2 compat Undefined, code = 100 (Failed with error GeneralException and code 100) 2018-06-07 14:52:58,480+03 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.GetHostJobsVDSCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-47) [4a7bc4a1] START, GetHostJobsVDSCommand(HostName = h1, GetHostJobsVDSCommandParameters:{hostId='8edde004-8086-4f01-b1d8-dc31e25f67d6', type='storage', jobIds='[20d77111-9e21-4908-bccc-12e1208e1f3d]'}), log id: 2653a061