Bug 1588589 - Allow to ignore the Postgres config auto-fixing
Summary: Allow to ignore the Postgres config auto-fixing
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Setup.Engine
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.3.0
: 4.3.0
Assignee: Roy Golan
QA Contact: Lucie Leistnerova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-07 14:57 UTC by Roy Golan
Modified: 2019-02-13 07:48 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-4.3.0_alpha
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-13 07:48:09 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.3+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 92026 0 master MERGED setup: Allow to ignore DB config-fixes suggestion 2018-06-25 08:06:50 UTC

Description Roy Golan 2018-06-07 14:57:40 UTC
Description of problem:
With Developers in mind, I want to allow quick installation without blowing up
on the postgres configuration fixes. Sometimes we want to try new versions, new configurations and this simply is a hurdle. I just want to ignore it and keep going.

Since dev installation are usually unprivilleged, we can expose the ignore only
for those installation. And that will keep non dev installation on the recommended path. 

Version-Release number of selected component (if applicable):


How reproducible:
Run engine-setup

Steps to Reproduce:
1. Spin db from a container, or with default conf
2. Run engine-setup as non-root user


Actual results:
You get:
 "The database requires these configurations values to be changed. Setup can fix them for you or abort. Fix automatically? (Yes, No) [Yes]: "

Expected results:
" The database requires these configurations values to be changed. Setup can fix them for you or abort. Fix automatically? (Yes, No, Ignore) [Yes]: "

And by saying 'Ignore' (case insensitive) you just continue the installation,
By saying 'Yes' it will try to amend the postgres.conf
Saying 'No' will abort the installation

Comment 1 Yedidyah Bar David 2018-06-10 09:47:51 UTC
Isn't bug 1573091 comment 6 enough?

Comment 2 Roy Golan 2018-06-10 10:37:09 UTC
No and really isn't what you want. It makes you work hard for something trivial.

Comment 3 Yedidyah Bar David 2018-06-13 10:23:07 UTC
How hard is it to run, once:

echo 'OVESETUP_CONFIG/forceInvalidPGConf=bool:True' > $PREFIX/ovirt-engine-setup.conf.d/ignore-pg-checks.conf

?

And why isn't this what I want?

Comment 4 Roy Golan 2018-06-13 10:30:40 UTC
(In reply to Yedidyah Bar David from comment #3)
> How hard is it to run, once:
> 
> echo 'OVESETUP_CONFIG/forceInvalidPGConf=bool:True' >
> $PREFIX/ovirt-engine-setup.conf.d/ignore-pg-checks.conf
> 
> ?
> 
Instead of just hitting "Ignore"? very hard, won't you agree? 

> And why isn't this what I want?

Comment 5 Lucie Leistnerova 2018-09-06 06:38:46 UTC
Ignore option added in DEVELOPER_MODE:

The database requires these configurations values to be changed. Setup can fix them for you or abort. Fix automatically? (Yes, No, Ignore) [Yes]:

and it doesn't change postgres configuration.

Otherwise Yes/No works as expected.

verified in ovirt-engine-setup-4.3.0-0.0.master.20180903111244.git94dce75.el7.noarch

Comment 6 Sandro Bonazzola 2018-11-02 14:33:26 UTC
This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 7 Sandro Bonazzola 2018-11-02 15:00:34 UTC
Closed by mistake, moving back to qa -> verified

Comment 8 Sandro Bonazzola 2019-02-13 07:48:09 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.