Bug 1588634 - Hosts: UI exception is thrown when trying to open New Host dialog before hosts table is loaded
Summary: Hosts: UI exception is thrown when trying to open New Host dialog before host...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.4.1
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.3.0
: 4.3.0
Assignee: Vojtech Szocs
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-07 16:14 UTC by Pavel Novotny
Modified: 2019-02-13 07:46 UTC (History)
6 users (show)

Fixed In Version: ovirt-engine-4.3.0_alpha
Clone Of:
Environment:
Last Closed: 2019-02-13 07:46:45 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-4.3?
rule-engine: blocker?
pnovotny: testing_plan_complete+
pnovotny: planning_ack?
rule-engine: devel_ack+
pnovotny: testing_ack+


Attachments (Terms of Use)
screencast: new host UI exception (771.52 KB, application/ogg)
2018-06-07 16:14 UTC, Pavel Novotny
no flags Details
ui.log (3.08 KB, text/plain)
2018-06-07 16:14 UTC, Pavel Novotny
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 92111 0 master MERGED webadmin: Fix HostListModel NPE 2018-06-11 07:38:32 UTC

Description Pavel Novotny 2018-06-07 16:14:01 UTC
Created attachment 1448783 [details]
screencast: new host UI exception

Description of problem:
When clicking on New button before the host table is loaded, UI exception is thrown.
See the attached screencast.

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.4.1-0.1.el7.noarch
ovirt-engine-webadmin-portal-4.2.4.1-0.1.el7.noarch

Browsers:
Firefox 52 ESR, 61.b11
Chromium 65

How reproducible:
always

Steps to Reproduce:
1. Go to Compute / Hosts view.
2. Before the host data grid is loaded, click on New button (for New Host dialog) (*).
3.

(*) A more comfortable way to reproduce it is to move the mouse pointer over New button, then reload the page (F5), wait for the action menu bar to load and then click before the host table is loaded.

Actual results:
UI exception is thrown and New Host dialog is not opened.

Expected results:
No UI exception, just New Host dialog is opened.

Additional info:
ui.log excerpt, full exception is attached:
~~~
Caused by: com.google.gwt.core.client.JavaScriptException: (TypeError) : a.Db is undefined
        at org.ovirt.engine.ui.uicommonweb.models.hosts.HostListModel.$isHeSystem(HostListModel.java:2147)
        at org.ovirt.engine.ui.uicommonweb.models.hosts.HostListModel.$newEntity(HostListModel.java:698)
~~~

Comment 1 Red Hat Bugzilla Rules Engine 2018-06-07 16:14:06 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 2 Pavel Novotny 2018-06-07 16:14:25 UTC
Created attachment 1448784 [details]
ui.log

Comment 3 Greg Sheremeta 2018-06-08 11:35:43 UTC
Is only the hosts grid affected?

Comment 4 Vojtech Szocs 2018-06-08 16:02:12 UTC
> Caused by: com.google.gwt.core.client.JavaScriptException: (TypeError) : a.Db is undefined

Looks like NPE, will check.

Comment 5 Vojtech Szocs 2018-06-08 16:57:41 UTC
@Pavel, I can reproduce the error but the alert box is still positioned correctly.

Caused by: java.lang.NullPointerException: null
  at org.ovirt.engine.ui.uicommonweb.models.hosts.HostListModel.isHeSystem(HostListModel.java:2149)
  ... stuff ...

Comment 6 Vojtech Szocs 2018-06-08 17:00:18 UTC
(In reply to Greg Sheremeta from comment #3)
> Is only the hosts grid affected?

The error I found (see above comment) indicates that this issue is scoped to host grid only.

Comment 7 Pavel Novotny 2018-06-11 12:00:55 UTC
(In reply to Greg Sheremeta from comment #3)
> Is only the hosts grid affected?

Yes, just the hosts grid. I haven't reproduced it with the other grids.

Comment 8 Raz Tamir 2018-11-27 09:06:44 UTC
Verified on 4.3.0-0.5.alpha1.el7

Comment 9 Sandro Bonazzola 2019-02-13 07:46:45 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.