Spec URL: https://mprahl.fedorapeople.org/python-neotime.spec SRPM URL: https://mprahl.fedorapeople.org/python-neotime-1.0.0-1.fc28.src.rpm Description: Nanosecond resolution temporal types Fedora Account System Username: mprahl I maintain python-neo4j-driver and the latest version requires this package which isn't already packaged.
I'll take it.
Please remove the shebang from all python files in /usr/lib/python3.6/site-packages/neotime in the %prep section to make rpmlint happy. A "find" call with "sed" should do it. Also, please file an issue with upstream asking them to include the full text of the license in their next tarball release (include it in MANIFEST.in, usually). Neither of these are blocking concerns. +1 to the review. These can be fixed after import to dist-git. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [-]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 7 files have unknown license. Detailed output of licensecheck in /home/threebean/1588797 -python-neotime/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [X]: %build honors applicable compiler flags or justifies otherwise. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-neotime , python2-neotime [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Note: tests are not present. [X]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-neotime-1.0.0-1.fc27.x86_64.rpm python2-neotime-1.0.0-1.fc27.x86_64.rpm python-neotime-1.0.0-1.fc27.src.rpm python3-neotime.x86_64: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/neotime/__init__.py /usr/bin/env python python3-neotime.x86_64: E: non-executable-script /usr/lib/python3.6/site-packages/neotime/__init__.py 644 /usr/bin/env python python3-neotime.x86_64: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/neotime/__main__.py /usr/bin/env python python3-neotime.x86_64: E: non-executable-script /usr/lib/python3.6/site-packages/neotime/__main__.py 644 /usr/bin/env python python3-neotime.x86_64: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/neotime/arithmetic.py /usr/bin/env python python3-neotime.x86_64: E: non-executable-script /usr/lib/python3.6/site-packages/neotime/arithmetic.py 644 /usr/bin/env python python3-neotime.x86_64: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/neotime/clock_implementations.py /usr/bin/env python python3-neotime.x86_64: E: non-executable-script /usr/lib/python3.6/site-packages/neotime/clock_implementations.py 644 /usr/bin/env python python3-neotime.x86_64: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/neotime/metaclasses.py /usr/bin/env python python3-neotime.x86_64: E: non-executable-script /usr/lib/python3.6/site-packages/neotime/metaclasses.py 644 /usr/bin/env python python2-neotime.x86_64: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/neotime/__init__.py /usr/bin/env python python2-neotime.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/neotime/__init__.py 644 /usr/bin/env python python2-neotime.x86_64: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/neotime/__main__.py /usr/bin/env python python2-neotime.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/neotime/__main__.py 644 /usr/bin/env python python2-neotime.x86_64: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/neotime/arithmetic.py /usr/bin/env python python2-neotime.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/neotime/arithmetic.py 644 /usr/bin/env python python2-neotime.x86_64: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/neotime/clock_implementations.py /usr/bin/env python python2-neotime.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/neotime/clock_implementations.py 644 /usr/bin/env python python2-neotime.x86_64: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/neotime/metaclasses.py /usr/bin/env python python2-neotime.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/neotime/metaclasses.py 644 /usr/bin/env python 3 packages and 0 specfiles checked; 20 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- python3-neotime (rpmlib, GLIBC filtered): python(abi) python3-pytz python3-six python2-neotime (rpmlib, GLIBC filtered): python(abi) python2-pytz python2-six Provides -------- python3-neotime: python3-neotime python3-neotime(x86-64) python3.6dist(neotime) python3dist(neotime) python2-neotime: python-neotime python-neotime(x86-64) python2-neotime python2-neotime(x86-64) python2.7dist(neotime) python2dist(neotime) Source checksums ---------------- https://files.pythonhosted.org/packages/source/n/neotime/neotime-1.0.0.tar.gz : CHECKSUM(SHA256) this package : 849f2e7a67204d67d4cb57c523b6e1cf4d36baf105197294fee6585e76ebc632 CHECKSUM(SHA256) upstream package : 849f2e7a67204d67d4cb57c523b6e1cf4d36baf105197294fee6585e76ebc632 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1588797 Buildroot used: fedora-27-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-neotime
python-neotime-1.0.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d97647d730
python-neotime-1.0.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fcb1c3e927
python-neotime-1.0.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-87ef985548
python-neotime-1.0.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
python-neotime-1.0.0-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
python-neotime-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-87ef985548
python-neotime-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.