Bug 1588932 - [RFE] Update "virtual-host" tuned profile with "latency-performance" profile settings
Summary: [RFE] Update "virtual-host" tuned profile with "latency-performance" profile ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.3.7
: ---
Assignee: Ori Liel
QA Contact: Petr Matyáš
URL:
Whiteboard:
: 1408934 1588657 (view as bug list)
Depends On: 1656744
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-08 07:06 UTC by Martin Perina
Modified: 2019-12-12 10:37 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-12 10:36:34 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github redhat-performance tuned pull 132 0 None None None 2018-12-06 08:52:21 UTC
Red Hat Product Errata RHBA-2019:4229 0 None None None 2019-12-12 10:37:02 UTC

Description Martin Perina 2018-06-08 07:06:00 UTC
Description of problem:

The default tuned profile for the hypervisor is currently set to virtual-host.

Testing at customer sites and in the performance labs have shown that setting the tuned-profile to Latency-Performance improves performance for a variety of workloads.

We need to consider changing the default profile to latency-performance. This is a placeholder BZ. The results were shared with the RHV team.

Version-Release number of selected component (if applicable):

RHEL7.5 / RHV 4.2

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Martin Perina 2018-06-08 07:08:11 UTC
*** Bug 1588657 has been marked as a duplicate of this bug. ***

Comment 4 Roy Golan 2018-10-02 07:10:06 UTC
I think instead of changing to a profile which works better we should consider changing the virtual-host config items or alias it to the profile mentioned. Else it will be a source for confusion for good. Correct me if I'm wrong here, there is no justification to maintain virtual-host profile if we are not going to use it.

Comment 5 Martin Perina 2018-10-02 08:37:29 UTC
(In reply to Roy Golan from comment #4)
> I think instead of changing to a profile which works better we should
> consider changing the virtual-host config items or alias it to the profile
> mentioned. Else it will be a source for confusion for good. Correct me if
> I'm wrong here, there is no justification to maintain virtual-host profile
> if we are not going to use it.

I don't agree, both latency-performance and virtual-host profiles are part of tuned package, so unless really necessary I don't wan to provide oVirt specific profile.

Comment 6 Roy Golan 2018-10-02 08:43:50 UTC
(In reply to Martin Perina from comment #5)
> (In reply to Roy Golan from comment #4)
> > I think instead of changing to a profile which works better we should
> > consider changing the virtual-host config items or alias it to the profile
> > mentioned. Else it will be a source for confusion for good. Correct me if
> > I'm wrong here, there is no justification to maintain virtual-host profile
> > if we are not going to use it.
> 
> I don't agree, both latency-performance and virtual-host profiles are part
> of tuned package, so unless really necessary I don't wan to provide oVirt
> specific profile.

That is my point - if virtual-host is not good for its main user, why maintain it?

Comment 7 Martin Perina 2018-10-02 08:59:51 UTC
(In reply to Roy Golan from comment #6)
> (In reply to Martin Perina from comment #5)
> > (In reply to Roy Golan from comment #4)
> > > I think instead of changing to a profile which works better we should
> > > consider changing the virtual-host config items or alias it to the profile
> > > mentioned. Else it will be a source for confusion for good. Correct me if
> > > I'm wrong here, there is no justification to maintain virtual-host profile
> > > if we are not going to use it.
> > 
> > I don't agree, both latency-performance and virtual-host profiles are part
> > of tuned package, so unless really necessary I don't wan to provide oVirt
> > specific profile.
> 
> That is my point - if virtual-host is not good for its main user, why
> maintain it?

AFAIK we don't maintain it, it's part of platform tuned package. In theory we could try post patches upstream to align virtual-host with latency-performance, then get this change to RHEL 8 and then try to force backport to RHEL 7, but that's too much work with unknown result (for example wouldn't be aligning virtual-host with latency-performance considered as breaking backward compatibility change?).

So I think it's more valuable to add administrators the ability to change tuned profile of the cluster ...

Comment 8 Roy Golan 2018-10-02 09:48:56 UTC
Of course we don't maintain it, but we are the main customer. We can modify it downstream if there is a clear benefit. 
What kind of backward compatibility breakage you see? those are kernel parameters. Unless I'm missing something.

Again if there is no parity between them, admins shouldn't be bother by the change at all, nothing. I see an advantage in keeping the profile updated, instead of changing to a different profile. Its far more intuitive, and the message you convey here is that we keep updating. With switching into a new profile we say that we don't care about it. Who will use it if its not recommended by the virtualization management itself? we will end with an outdated profile - is it worth it?

Comment 9 Ori Liel 2018-10-04 12:03:07 UTC
Roy's point is valid, and to elaborate on it - there's the possibility that latency-performance profile will be tweaked in the future and suddenly become unsuitable for the default profile for oVirt nodes.

Comment 10 Ori Liel 2018-10-04 12:05:59 UTC
A design document for changing the default value has been written, here it is even though it may become obsolete due to the above discussion:

https://docs.google.com/document/d/1MwmQKOeLo26C_SNcV4NQ7XyW_PPKSY92dTrH2iAdEA0/

Comment 11 Kaustav Majumder 2018-11-16 12:58:55 UTC
*** Bug 1408934 has been marked as a duplicate of this bug. ***

Comment 12 Ori Liel 2018-11-26 07:37:18 UTC
Done. Notice, the patch is to tuned github, not ovirt

https://github.com/redhat-performance/tuned/pull/132

Comment 13 Martin Perina 2018-12-06 08:52:21 UTC
Moving back to MODIFIED, we need to wait until upstream changes will be included in RHEL 7 release

Comment 15 Petr Matyáš 2019-01-23 08:52:44 UTC
Still not part of current tuned in RHEL 7.

Comment 18 Martin Perina 2019-01-29 09:16:59 UTC
Moving to 4.3.3, but we may move even further as the fix for tuned package in RHEL should be delivered in RHEL 7.7, details in BZ1656744

Comment 19 Martin Perina 2019-04-01 07:36:59 UTC
Moving to 4.3.5 as it's blocked by BZ1656744 which will be part of RHEL 7.7

Comment 20 Martin Perina 2019-05-15 07:01:51 UTC
Moving to 4.3.6, it needs to wait for RHEL 7.7

Comment 21 Petr Matyáš 2019-08-27 07:56:35 UTC
Verified on ovirt-engine-4.3.6.3-0.1.el7.noarch with tuned-2.11.0-5.el7.noarch

Comment 25 errata-xmlrpc 2019-12-12 10:36:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4229


Note You need to log in before you can comment on or make changes to this bug.