Spec URL: https://smani.fedorapeople.org/review/mmg.spec SRPM URL: https://smani.fedorapeople.org/review/mmg-5.3.10-1.fc29.src.rpm Description: Surface and volume remeshers Fedora Account System Username: smani
- Use %ldconfig_scriptlets instead of ldconfig, see https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets#Upgrade.2Fcompatibility_impact %ldconfig_scriptlets %ldconfig_scriptlets -n mmg2d %ldconfig_scriptlets -n mmgs %ldconfig_scriptlets -n mmg3d - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 33136640 bytes in 7529 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Please make noarch -devel-doc subpackages for the documentation of each devel packages. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 33136640 bytes in 7529 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v3 or later)", "GPL (v3)", "Unknown or generated". 87 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/mmg/review-mmg/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mmg2d , mmg2d-devel , mmgs , mmgs-devel , mmg3d , mmg3d-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 39639040 bytes in /usr/share mmgs- devel-5.3.10-1.fc29.x86_64.rpm:10496000, mmg3d- devel-5.3.10-1.fc29.x86_64.rpm:17715200, mmg2d- devel-5.3.10-1.fc29.x86_64.rpm:11182080 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mmg-5.3.10-1.fc29.x86_64.rpm mmg-devel-5.3.10-1.fc29.x86_64.rpm mmg2d-5.3.10-1.fc29.x86_64.rpm mmg2d-devel-5.3.10-1.fc29.x86_64.rpm mmgs-5.3.10-1.fc29.x86_64.rpm mmgs-devel-5.3.10-1.fc29.x86_64.rpm mmg3d-5.3.10-1.fc29.x86_64.rpm mmg3d-devel-5.3.10-1.fc29.x86_64.rpm mmg-debuginfo-5.3.10-1.fc29.x86_64.rpm mmg-debugsource-5.3.10-1.fc29.x86_64.rpm mmg-5.3.10-1.fc29.src.rpm mmg.x86_64: W: spelling-error Summary(en_US) remeshers -> refreshers, refresher mmg.x86_64: W: spelling-error %description -l en_US bidimensional -> bi dimensional, bi-dimensional, dimensional mmg.x86_64: W: spelling-error %description -l en_US tridimensional -> multidimensional, dimensional mmg.x86_64: W: spelling-error %description -l en_US remeshing -> re meshing, re-meshing, refreshing mmg.x86_64: W: spelling-error %description -l en_US isovalue -> overvalue mmg.x86_64: W: spelling-error %description -l en_US discretization -> discretionary, discretion, discrimination mmg.x86_64: W: invalid-url URL: https://www.mmgtools.org/ <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:858)> mmg.x86_64: W: shared-lib-calls-exit /usr/lib64/libmmg.so.5.0.0 exit.5 mmg-devel.x86_64: W: invalid-url URL: https://www.mmgtools.org/ <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:858)> mmg-devel.x86_64: W: no-documentation mmg2d.x86_64: W: spelling-error Summary(en_US) remesher -> refresher, thresher, mesosphere mmg2d.x86_64: W: spelling-error %description -l en_US bidimensional -> bi dimensional, bi-dimensional, dimensional mmg2d.x86_64: W: invalid-url URL: https://www.mmgtools.org/ <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:858)> mmg2d.x86_64: W: shared-lib-calls-exit /usr/lib64/libmmg2d.so.5.0.0 exit.5 mmg2d.x86_64: W: no-manual-page-for-binary mmg2d mmg2d.x86_64: W: no-manual-page-for-binary mmg2d_O3 mmg2d-devel.x86_64: W: invalid-url URL: https://www.mmgtools.org/ <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:858)> mmgs.x86_64: W: spelling-error Summary(en_US) remesher -> refresher, thresher, mesosphere mmgs.x86_64: W: spelling-error %description -l en_US isovalue -> overvalue mmgs.x86_64: W: spelling-error %description -l en_US discretization -> discretionary, discretion, discrimination mmgs.x86_64: W: invalid-url URL: https://www.mmgtools.org/ <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:858)> mmgs.x86_64: W: shared-lib-calls-exit /usr/lib64/libmmgs.so.5.0.0 exit.5 mmgs.x86_64: W: no-manual-page-for-binary mmgs mmgs.x86_64: W: no-manual-page-for-binary mmgs_O3 mmgs-devel.x86_64: W: invalid-url URL: https://www.mmgtools.org/ <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:858)> mmg3d.x86_64: W: spelling-error Summary(en_US) remesher -> refresher, thresher, mesosphere mmg3d.x86_64: W: invalid-url URL: https://www.mmgtools.org/ <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:858)> mmg3d.x86_64: W: shared-lib-calls-exit /usr/lib64/libmmg3d.so.5.0.0 exit.5 mmg3d.x86_64: W: no-manual-page-for-binary mmg3d mmg3d.x86_64: W: no-manual-page-for-binary mmg3d_O3 mmg3d-devel.x86_64: W: invalid-url URL: https://www.mmgtools.org/ <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:858)> mmg-debuginfo.x86_64: W: invalid-url URL: https://www.mmgtools.org/ <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:858)> mmg-debugsource.x86_64: W: invalid-url URL: https://www.mmgtools.org/ <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:858)> mmg.src: W: spelling-error Summary(en_US) remeshers -> refreshers, refresher mmg.src: W: spelling-error %description -l en_US bidimensional -> bi dimensional, bi-dimensional, dimensional mmg.src: W: spelling-error %description -l en_US tridimensional -> multidimensional, dimensional mmg.src: W: spelling-error %description -l en_US remeshing -> re meshing, re-meshing, refreshing mmg.src: W: spelling-error %description -l en_US isovalue -> overvalue mmg.src: W: spelling-error %description -l en_US discretization -> discretionary, discretion, discrimination mmg.src: W: invalid-url URL: https://www.mmgtools.org/ <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:858)> 11 packages and 0 specfiles checked; 0 errors, 40 warnings.
Spec URL: https://smani.fedorapeople.org/review/mmg.spec SRPM URL: https://smani.fedorapeople.org/review/mmg-5.3.10-2.fc29.src.rpm %changelog * Sun Jun 10 2018 Sandro Mani <manisandro> - 5.3.10-2 - Use %%ldconfig_scriptlets - Move documentation to separate subpackages - Install man pages
Perfect, package approved.
Thanks for the review!
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mmg