Bug 1589381 - perl-Cflow not actually linked to flow-tools since -17
Summary: perl-Cflow not actually linked to flow-tools since -17
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: perl-Cflow
Version: epel7
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-08 20:49 UTC by Chris Tracy
Modified: 2018-09-11 14:44 UTC (History)
3 users (show)

Fixed In Version: perl-Cflow-1.053-35.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-11 14:44:10 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Basic spec file patch to restore the necessary CCFLAGS/LIBS for linking to flow-tools (587 bytes, patch)
2018-06-08 20:49 UTC, Chris Tracy
no flags Details | Diff

Description Chris Tracy 2018-06-08 20:49:16 UTC
Created attachment 1449269 [details]
Basic spec file patch to restore the necessary CCFLAGS/LIBS for linking to flow-tools

Description of problem:
perl-Cflow isn't actually linked against flow-tools (libft) and doesn't seem to have been since release -17.  It works in the EPEL6 version (-11)

In -17, it seems the spec file was changed such that the Makefile creation line changed from:

[Working, 1.053-11]
%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" \
   CCFLAGS='-DOSU' LIBS='-lft'

[Broken, 1.053-32]
%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"

where the manual set of CCFLAGS and LIBS was removed.  The problem is, the upstream source won't detect and build against flow-tools otherwise.  (It's autodetection logic expects perl-Cflow to be inside the build tree for flow-tools itself)

Restoring the CCFLAGS/LIBS override in the spec file results in a build that works as expected.  (Consistent with the EPEL6 build)

Version-Release number of selected component (if applicable):
perl-Cflow-1.053-32.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1. yum -y install flow-tools perl-Cflow
2. Run flow-capture to gather some netflow data into flow files
3. flowdumper -v ft-v05.whatever

Actual results:
$ flowdumper -v ft-v05.2018-06-08.144801-0500
ft-v05.2018-06-08.144801-0500: Invalid index in cflowd flow file: 0xCF100103! Version 5 flow-export is required with *all* fields being saved.

Expected results:
$ flowdumper -v ft-v05.2018-06-08.144801-0500
FLOW
  index:          0xc7ffff
  router:         127.0.0.1
<snip>

Additional info:
I've attached a very basic diff of the spec file, incremented to -33, that makes the change suggested above.

Comment 1 Orion Poplawski 2018-06-17 22:57:12 UTC
So, I actually fixed this a while back, but never built and pushed the update.  I'll do that shortly.

Comment 2 Fedora Update System 2018-06-17 23:07:00 UTC
perl-Cflow-1.053-35.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-2bdc70542a

Comment 3 Fedora Update System 2018-06-18 17:08:27 UTC
perl-Cflow-1.053-35.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-2bdc70542a

Comment 4 Chris Tracy 2018-06-19 18:45:15 UTC
Still waiting for perl-Cflow-1.053-35.el7 to actually show up in the epel-testing mirrors so I can test it...

Comment 5 Chris Tracy 2018-06-19 18:51:17 UTC
Figured out how to pull the updated package out of koji.  Works here, thanks.  Look forward to it moving into EPEL.

Comment 6 Fedora Update System 2018-09-11 14:44:10 UTC
perl-Cflow-1.053-35.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.