Bug 1589665 - WebAdmin: Upload image dialog - not informative enough when image is too small
Summary: WebAdmin: Upload image dialog - not informative enough when image is too small
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.3.2.1
Hardware: x86_64
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.3.2
: 4.3.2.1
Assignee: Daniel Erez
QA Contact: Shir Fishbain
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-11 06:29 UTC by Yosi Ben Shimon
Modified: 2019-03-19 10:03 UTC (History)
5 users (show)

Fixed In Version: ovirt-engine-4.3.2.1
Clone Of:
Environment:
Last Closed: 2019-03-19 10:03:21 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.3+


Attachments (Terms of Use)
Upload image dialog (281.27 KB, image/png)
2018-06-11 06:29 UTC, Yosi Ben Shimon
no flags Details
Empty raw image (243.16 KB, image/png)
2019-03-17 13:54 UTC, Yosi Ben Shimon
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 98114 0 master MERGED webadmin: upload image remove alignment check 2019-03-07 18:40:43 UTC

Description Yosi Ben Shimon 2018-06-11 06:29:02 UTC
Created attachment 1449899 [details]
Upload image dialog

Description of problem:
The upload image dialog is not informative enough when the image is too small (e.g. when the image size ~200Kb).
The error message only says: "The selected file is not a valid image (please refer to the documentation for more information)."

Note that when the image is not compatible with the storage format version, the message is ok: "Uploading an image with qcow2 compat 1.1 is unsupported for storage format type V3."

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.4.2-0.1.el7_3.noarch

How reproducible:
always.

Steps to Reproduce:
1. Create an image on a local machine using qemu-img:
# qemu-img create -f qcow2 -o compat=0.10 test_img.qcow2 10G
# qemu-img info test_img.qcow2
image: test_img.qcow2
file format: qcow2
virtual size: 10G (10737418240 bytes)
disk size: 196K
cluster_size: 65536
Format specific information:
    compat: 0.10
    refcount bits: 16
2. In WebAdmin: go to "Disks" tab under "Storage".
3. Click on "Upload" -> "Start".
4. Select the newly created image
5. Click "Start"

Actual results:
See attached screenshot

Expected results:
The error message should be more informative and explain that the image is too small.

Additional info:

Comment 1 Sandro Bonazzola 2019-01-28 09:42:06 UTC
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 2 Daniel Erez 2019-03-07 18:50:21 UTC
Removed the alignment to 512 bytes validation, as uploading unaligned images is still supported by the daemon.
I.e. uploading and empty cow image is feasible, uploading a blank raw image (0 bytes) is still blocked.

Comment 3 Yosi Ben Shimon 2019-03-17 13:52:49 UTC
Tested using:
ovirt-engine-4.3.2.1-0.1.el7.noarch

The cow image mentioned in the bug description uploaded successfully.
An empty raw image failed to open (attaching screenshot)

Moving to VERIFIED

Comment 4 Yosi Ben Shimon 2019-03-17 13:54:37 UTC
Created attachment 1544989 [details]
Empty raw image

Comment 5 Sandro Bonazzola 2019-03-19 10:03:21 UTC
This bugzilla is included in oVirt 4.3.2 release, published on March 19th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.