Bug 1589875 - [RFE] allow a parameter to be passed in the StorageClass to target the disk being created in a different Azure resource group
Summary: [RFE] allow a parameter to be passed in the StorageClass to target the disk b...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Storage
Version: 3.7.0
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
: 3.11.0
Assignee: Jan Safranek
QA Contact: Wenqi He
URL:
Whiteboard:
: 1595736 (view as bug list)
Depends On:
Blocks: 1596319 1596668 1596673
TreeView+ depends on / blocked
 
Reported: 2018-06-11 15:04 UTC by Paul Dwyer
Modified: 2020-02-20 02:24 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1596319 1596668 1596673 (view as bug list)
Environment:
Last Closed: 2018-10-11 07:20:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:2652 0 None None None 2018-10-11 07:21:34 UTC

Description Paul Dwyer 2018-06-11 15:04:09 UTC
1. Proposed title of this feature request

allow a parameter to be passed in the StorageClass to target the disk being created in a different Azure resource group

Comment 6 Jan Safranek 2018-06-29 12:03:25 UTC
Wenqi, the test case in polarion needs some updates.

- I indeed picked PR https://github.com/kubernetes/kubernetes/pull/65217 that introduces annotation for resource group, however, I picked also https://github.com/kubernetes/kubernetes/pull/65443 that moves it from annotation to StorageClass.parameters:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: jsafrane
provisioner: kubernetes.io/azure-disk
parameters:
    kind: Managed
    resourceGroup: jsafrane-test


- Please test also provisioning into non-existing resource group ("resourceGroup: non-existing").

Comment 7 Wenqi He 2018-07-02 03:41:17 UTC
(In reply to Jan Safranek from comment #6)
> Wenqi, the test case in polarion needs some updates.
> 
Sure, updated and added a new case. Please tell me if still any issue.

Comment 8 Fabio Bertinatto 2018-07-02 09:06:00 UTC
*** Bug 1595736 has been marked as a duplicate of this bug. ***

Comment 9 Jan Safranek 2018-07-10 10:11:17 UTC
Origin PR: https://github.com/openshift/origin/pull/20268

Comment 10 Jan Safranek 2018-07-30 08:21:16 UTC
The fix was part of the last kubernetes rebase in Origin.

Comment 12 Wenqi He 2018-08-27 07:59:34 UTC
Tested on below version:
openshift v3.11.0-0.22.0
kubernetes v1.11.0+d4cacc0

# uname -a
Linux wehe-master-etcd-nfs-1 3.10.0-862.10.2.el7.x86_64 #1 SMP Wed Jul 4 09:41:38 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux
# cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.5 (Maipo)

$ oc get pvc
NAME      STATUS    VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
azpvc     Bound     pvc-3ceda773-a9cd-11e8-902d-000d3a1b9719   1Gi        RWO            externalsc     10m
$ oc describe sc externalsc
Name:                  externalsc
IsDefaultClass:        No
Annotations:           <none>
Provisioner:           kubernetes.io/azure-disk
Parameters:            kind=Managed,resourceGroup=openshift-qe-eastus2
AllowVolumeExpansion:  <unset>
MountOptions:          <none>
ReclaimPolicy:         Delete
VolumeBindingMode:     Immediate
Events:                <none>
$ oc get pods
NAME      READY     STATUS    RESTARTS   AGE
pod       1/1       Running   0          1m
$ oc exec -it pod bash
bash-4.2$ ls /mnt/azure/
bash-4.2$ touch /mnt/azure/wehe
bash-4.2$ ls /mnt/azure/
wehe
bash-4.2$ exit
exit
$ oc exec -it pod bash
bash-4.2$ ls 
anaconda-post.log  dev	hello		 home  lib64	   media  opt	root  sbin  sys  usr
bin		   etc	hello-openshift  lib   lost+found  mnt	  proc	run   srv   tmp  var
bash-4.2$ cp hello /mnt/azure/
bash-4.2$ ./mnt/azure/hello 
Hello OpenShift Storage
bash-4.2$ exit
exit

Comment 14 errata-xmlrpc 2018-10-11 07:20:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2652


Note You need to log in before you can comment on or make changes to this bug.