Description of problem: bodhi FTBFS on Python 3.7, it uses async as name (it's a keyword now) Version-Release number of selected component (if applicable): 3.8.0-1.fc29 File "/usr/lib/python3.7/site-packages/bodhi/server/util.py", line 1003 sync, async = [], [] ^ SyntaxError: invalid syntax https://docs.python.org/3.7/whatsnew/3.7.html Please rename the thing ASAP.
https://github.com/fedora-infra/bodhi/pull/2436
Note that even with my patch, there are test failures: https://copr.fedorainfracloud.org/coprs/g/python/python3.7/build/765569/
Strange, so it seems that the trailing commas in the calls to two exceptions are the cause of failure. For example, E AssertionError: Expected call: warn('"recipient refused" for \'lana\', SMTPRecipientsRefused(\'nooope!\',)') E Actual call: warn('"recipient refused" for \'lana\', SMTPRecipientsRefused(\'nooope!\')')
I filed https://github.com/fedora-infra/bodhi/issues/2438 about the two other tests.
I successfully built the package with: .test-virtualenv-3/bin/python3 /usr/bin/py.test-3 -k "not test_exception and not test_recipients_refused" Should I send a PR or would you rather get this fixed properly before that?
I'm working on a 3.8.1 release upstream that'll include both of your patches. Thanks!