Bug 1590109 - refresh caps events are not sent on network dhcp attachment or update
Summary: refresh caps events are not sent on network dhcp attachment or update
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.2.4.1
Hardware: x86_64
OS: Linux
medium
high
Target Milestone: ovirt-4.2.6
: 4.2.6.2
Assignee: Alona Kaplan
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks: 1517638
TreeView+ depends on / blocked
 
Reported: 2018-06-12 05:38 UTC by Michael Burman
Modified: 2018-09-03 15:09 UTC (History)
6 users (show)

Fixed In Version: ovirt-engine-4.2.6.2
Clone Of:
Environment:
Last Closed: 2018-09-03 15:09:28 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+
mburman: testing_plan_complete-


Attachments (Terms of Use)
screenshot (91.02 KB, image/png)
2018-06-12 05:51 UTC, Michael Burman
no flags Details
logs (1.65 MB, application/x-gzip)
2018-06-12 05:53 UTC, Michael Burman
no flags Details
logs set2 (1.87 MB, application/x-gzip)
2018-06-13 07:02 UTC, Michael Burman
no flags Details
logs set3 (1.87 MB, application/x-gzip)
2018-06-13 10:39 UTC, Michael Burman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 93535 0 master MERGED engine: GetCaps should be executed with waiting lock in case of event 2020-04-16 11:43:38 UTC
oVirt gerrit 93584 0 master MERGED engine: Network events form vdsm should invoke the correct subscriber 2020-04-16 11:43:38 UTC
oVirt gerrit 93594 0 ovirt-engine-4.2 MERGED engine: GetCaps should be executed with waiting lock in case of event 2020-04-16 11:43:38 UTC
oVirt gerrit 93595 0 ovirt-engine-4.2 MERGED engine: Network events form vdsm should invoke the correct subscriber 2020-04-16 11:43:38 UTC

Description Michael Burman 2018-06-12 05:38:02 UTC
Description of problem:
refresh caps events are not sent on network dhcp attachment or update

It's not clear yet who is not sending the event, does vdsm send event when attaching or setting network with dhcp to host and then engine doesn't sending a refresh caps to the host or maybe vdsm is not sending such event to the engine. Any how when attaching a network with dhcp bootproto or updating a network with dhcp, an event from vdsm should go to the host once network get the IP and then engine should invoke refresh caps on the host and IP should be visible in UI without any manual intervention.

Now, DEV saying that was suppose to work or used to work, but in fact this was never working and me personally was never aware of such code(there is no bug which tracking such code). I'm using rhv product for almost 4 years now and i never got an event when was setting a dhcp network on the host, i always needed to do a manual refresh caps in order to see the IP from dhcp in the UI webadmin. 

There is a confuse here between DEV and QE on this matter, further investigation is needed. And this is now may explain some of the out-of-sync bugs we have in the product. 


Version-Release number of selected component (if applicable):
4.2.4.2-0.1.el7_3
vdsm-4.20.30-1.el7ev.x86_64

How reproducible:
100% 

Steps to Reproduce:
1. Attach network with dhcp bootproto or update an attached network with dhcp
2. Approve operation

Actual results:
Nothing changes in the UI, no IP is visible. On the host dhcp allready gave an address to the network, but no event was coming, not sure from which side, engine or vdsm?
Need to do a manual refresh caps

Expected results:
When setting a network with dhcp, vdsm should send an event to the engine once network get the IP address and then engine should invoke caps in order to display the IP in the UI.

Additional info:
This maybe affecting BZ 1517638 and some other out-of-sync bugs we have.

Comment 1 Michael Burman 2018-06-12 05:51:55 UTC
Created attachment 1450321 [details]
screenshot

Comment 2 Michael Burman 2018-06-12 05:53:02 UTC
Created attachment 1450322 [details]
logs

Comment 5 Dan Kenigsberg 2018-06-13 06:37:54 UTC
Michael, can you `ifdown ovirt-device-with-dhcp`, refresh caps, see the host out-of-sync, follow with `ifup ovirt-device-with-dhcp`, and check {super,}vdsm and engine logs?

Comment 6 Michael Burman 2018-06-13 07:02:15 UTC
Created attachment 1450805 [details]
logs  set2

Comment 7 Michael Burman 2018-06-13 10:39:35 UTC
Created attachment 1450839 [details]
logs  set3

Please ignore previous attachment

Comment 8 Edward Haas 2018-07-31 06:07:20 UTC
Further investigation revealed that the notification is sent from VDSM but it is most probably ignored at the Engine side.
The notification is sent while Engine is in the process of a post setup caps refresh, and it seems it will ignore notifications to issue another caps if the previous one has not completed yet.

Comment 9 Dan Kenigsberg 2018-08-14 06:13:41 UTC
also available in nightly ovirt-engine-0:4.2.6.3_SNAPSHOT-93.g584f531.0.scratch.master.el7ev

Comment 10 Michael Burman 2018-08-15 08:37:03 UTC
Verified on - 4.2.6.3_SNAPSHOT-94.gbbcd5cb.0.scratch.master.el7ev and vdsm-4.20.37-1.el7ev.x86_64


Note You need to log in before you can comment on or make changes to this bug.