Bug 1590308 - texinfo's tests fail with Perl 5.28
Summary: texinfo's tests fail with Perl 5.28
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: texinfo
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vitezslav Crhonek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-12 12:07 UTC by Jitka Plesnikova
Modified: 2018-06-21 12:12 UTC (History)
4 users (show)

Fixed In Version: texinfo-6.5-6.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-21 12:12:28 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Fix for unescaped left brace (865 bytes, patch)
2018-06-12 12:07 UTC, Jitka Plesnikova
no flags Details | Diff

Description Jitka Plesnikova 2018-06-12 12:07:33 UTC
Created attachment 1450492 [details]
Fix for unescaped left brace

I am preparing upgrade to Perl 5.28. texinfo's tests fail during local rebuild with following errors:

diff -a -u -r formatting//diffs/staging_res/texi_cond/cond.2 formatting//out_parser/texi_cond/cond.2
--- formatting//diffs/staging_res/texi_cond/cond.2	2017-08-27 12:45:45.000000000 +0200
+++ formatting//out_parser/texi_cond/cond.2	2018-06-12 13:55:29.742494430 +0200
@@ -0,0 +1,2 @@
+Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/^\s+@([[:alnum:]][[:alnum:]\-]*)({ <-- HERE })?\s*/ at ../../tp/Texinfo/Parser.pm line 5481.
+Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/^\s+@([[:alnum:]][[:alnum:]\-]*)({ <-- HERE })?\s*(\@(c|comment)((\@|\s+).*)?)?/ at ../../tp/Texinfo/Parser.pm line 5485.

It is related to this change
https://metacpan.org/pod/release/XSAWYERX/perl-5.28.0-RC2/pod/perldelta.pod#Use-of-unescaped-%22%7B%22-immediately-after-a-%22(%22-in-regular-expression-patterns

The proposed fixed is attached. Verified with Perl 5.28 RC1.

Comment 1 Vitezslav Crhonek 2018-06-21 12:12:28 UTC
Looks fine, applied. Thanks!


Note You need to log in before you can comment on or make changes to this bug.