Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1590385

Summary: Refactor dht lookup code
Product: [Community] GlusterFS Reporter: Nithya Balachandran <nbalacha>
Component: distributeAssignee: Nithya Balachandran <nbalacha>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: high    
Version: mainlineCC: atumball, bugs
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-7.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1703897 1707393 (view as bug list) Environment:
Last Closed: 2019-05-11 11:42:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1703897, 1707393    

Description Nithya Balachandran 2018-06-12 14:19:18 UTC
Description of problem:
Refactor the dht lookup code in order to make it easier to maintain.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2018-06-12 14:24:47 UTC
REVIEW: https://review.gluster.org/20246 (cluster/dht:  refactor dht_lookup) posted (#1) for review on master by N Balachandran

Comment 2 Worker Ant 2018-06-14 07:09:47 UTC
REVIEW: https://review.gluster.org/20267 (cluster/dht: Minor code cleanup) posted (#1) for review on master by N Balachandran

Comment 3 Worker Ant 2018-06-20 02:40:18 UTC
COMMIT: https://review.gluster.org/20267 committed in master by "N Balachandran" <nbalacha> with a commit message- cluster/dht: Minor code cleanup

Removed extra variable.

Change-Id: If43c47f6630454aeadab357a36d061ec0b53cdb5
updates: bz#1590385
Signed-off-by: N Balachandran <nbalacha>

Comment 4 Worker Ant 2018-06-21 05:36:13 UTC
COMMIT: https://review.gluster.org/20246 committed in master by "Amar Tumballi" <amarts> with a commit message- cluster/dht:  refactor dht_lookup

The dht lookup code is getting difficult to maintain
due to its size. Refactoring the code will make it
easier to modify it in future.

Change-Id: Ic7cb5bf4f018504dfaa7f0d48cf42ab0aa34abdd
updates: bz#1590385
Signed-off-by: N Balachandran <nbalacha>

Comment 5 Worker Ant 2018-08-02 16:20:48 UTC
REVIEW: https://review.gluster.org/20622 (cluster/dht: refactor dht_lookup_cbk) posted (#1) for review on master by N Balachandran

Comment 6 Shyamsundar 2018-10-23 15:11:13 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 7 Nithya Balachandran 2018-10-29 02:58:27 UTC
Reopening as this is an umbrella BZ for many more changes to the rebalance process.

Comment 8 Worker Ant 2018-12-06 13:57:38 UTC
REVIEW: https://review.gluster.org/21816 (cluster/dht: refactor dht_lookup_cbk) posted (#1) for review on master by N Balachandran

Comment 9 Worker Ant 2018-12-26 12:41:37 UTC
REVIEW: https://review.gluster.org/21816 (cluster/dht: refactor dht_lookup_cbk) posted (#7) for review on master by N Balachandran

Comment 10 Nithya Balachandran 2018-12-26 12:56:32 UTC
Reopening this as there will be more changes.

Comment 11 Worker Ant 2019-03-25 10:29:50 UTC
REVIEW: https://review.gluster.org/22407 (cluster/dht: refactor dht lookup functions) posted (#1) for review on master by N Balachandran

Comment 12 Shyamsundar 2019-03-25 16:30:27 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-6.0, please open a new bug report.

glusterfs-6.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2019-March/000120.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 13 Worker Ant 2019-04-06 01:41:34 UTC
REVIEW: https://review.gluster.org/22407 (cluster/dht: refactor dht lookup functions) merged (#10) on master by N Balachandran

Comment 14 Worker Ant 2019-04-10 09:03:15 UTC
REVIEW: https://review.gluster.org/22542 (cluster/dht: Refactor dht lookup functions) posted (#1) for review on master by N Balachandran

Comment 15 Worker Ant 2019-04-25 04:12:37 UTC
REVIEW: https://review.gluster.org/22542 (cluster/dht: Refactor dht lookup functions) merged (#3) on master by Amar Tumballi

Comment 16 Nithya Balachandran 2019-04-29 03:21:31 UTC
Marking this Modified as I am done with the changes for now.