Spec URL: https://pagure.io/kata-ksm-throttler/blob/master/f/kata-ksm-throttler.spec SRPM URL: TBD Description: TBD Fedora Account System Username: lsm5
Spec URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-ksm-throttler/kata-ksm-throttler.spec SRPM URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-ksm-throttler/SRPMS/kata-ksm-throttler-1.0.0-1.gitaa4d33d.fc28.src.rpm Description: This project implements a Kernel Same-page Merging throttling daemon. Its goal is to regulate KSM by dynamically modifying the KSM sysfs entries, in order to minimize memory duplication as fast as possible while keeping the KSM daemon load low. Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=27608195 $ rpmlint -i kata-ksm-throttler.spec RPMS/* SRPMS/kata-ksm-throttler-1.0.0-1.gitaa4d33d.fc28.src.rpm 4 packages and 1 specfiles checked; 0 errors, 0 warnings.
Could you update the target Fedora release? What kind of testing will Red Hat do when they put this in Fedora? will you attach your test results to the BZ?
See https://bugzilla.redhat.com/show_bug.cgi?id=1590414#c2
Spec URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-ksm-throttler/kata-ksm-throttler.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/kata/fedora-rawhide-x86_64/00772640-kata-ksm-throttler/kata-ksm-throttler-1.0.0-2.gitaa4d33d.fc29.src.rpm * Sat Nov 10 2018 Lokesh Mandvekar <lsm5> - 1.3.1-1.git6e903fb - bump to v1.3.1 - built commit 6e903fb
Spec URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-ksm-throttler/kata-ksm-throttler.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/kata/fedora-rawhide-x86_64/00822518-kata-ksm-throttler/kata-ksm-throttler-1.3.1-1.git6e903fb.fc30.src.rpm * Sat Nov 10 2018 Lokesh Mandvekar <lsm5> - 1.3.1-1.git6e903fb - bump to v1.3.1 - built commit 6e903fb
Spec URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-ksm-throttler/kata-ksm-throttler.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/kata/fedora-rawhide-x86_64/00822858-kata-ksm-throttler/kata-ksm-throttler-1.3.1-2.git6e903fb.fc30.src.rpm
Spec URL: https://pagure.io/kata-rpm-reviews/raw/master/f/kata-ksm-throttler/kata-ksm-throttler.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/kata/fedora-rawhide-x86_64/00822858-kata-ksm-throttler/kata-ksm-throttler-1.3.1-2.git6e903fb.fc30.src.rpm
MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review: kata-ksm-throttler.src: E: unknown-key RSA#8055c25b (MD5 kata-ksm-throttler.x86_64: E: unknown-key RSA#8055c25b (MD5 kata-ksm-throttler-debuginfo.x86_64: E: useless-provides debuginfo(build-id) kata-ksm-throttler-debuginfo.x86_64: E: unknown-key RSA#8055c25b (MD5 kata-ksm-throttler-debugsource.x86_64: W: no-documentation kata-ksm-throttler-debugsource.x86_64: E: unknown-key RSA#8055c25b (MD5 4 packages and 1 specfiles checked; 5 errors, 1 warnings. All of the warnings seem irrelevant. MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
fedora-review also did not found any defects. Other than the exclusive architecture, looks good to me.
instead of excludearch, we have included exclusivearch: x86_64 since other arches aren't supported at this time afaik. Frantisek, thanks for the review and approval.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kata-ksm-throttler
kata-ksm-throttler seems to be in Fedora repos nowadays, so closing this