Spec URL: https://pagure.io/kata-proxy/blob/master/f/kata-proxy.spec SRPM URL: TBD Description: TBD Fedora Account System Username: lsm5
Spec URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-proxy/kata-proxy.spec SRPM URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-proxy/SRPMS/kata-proxy-1.0.0-1.gita69326b.fc28.src.rpm Description: %{summary} Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=27620973 $ rpmlint -i kata-proxy.spec RPMS/x86_64/kata-proxy-* SRPMS/kata-proxy-1.0.0-1.gita69326b.fc28.src.rpm 4 packages and 1 specfiles checked; 0 errors, 0 warnings.
Spec URL: https://pagure.io/kata-rpm-reviews/raw/master/f/kata-proxy/kata-proxy.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/kata/fedora-rawhide-x86_64/00822520-kata-proxy/kata-proxy-1.3.1-1.gitd364b2e.fc30.src.rpm * Sat Nov 10 2018 Lokesh Mandvekar <lsm5> - 1.3.1-1.gitd364b2e - bump to v1.3.1 - built commit d364b2e
Spec URL: https://pagure.io/kata-rpm-reviews/raw/master/f/kata-proxy/kata-proxy.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/kata/fedora-rawhide-x86_64/00822861-kata-proxy/kata-proxy-1.3.1-2.gitd364b2e.fc30.x86_64.rpm
This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: make See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT/X11 (BSD like)", "*No copyright* MPL (v2.0)", "BSD (3 clause)", "ISC", "*No copyright* Apache (v2.0)". 290 files have unknown license. Detailed output of licensecheck in /home/jcvenega/1590423-kata-proxy/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(cups- client, efivar-libs, qemu-block-gluster, rpm-plugin-selinux, abrt, ghc-transformers, libmediaart, libimagequant, giflib, libreoffice- graphicfilter, trousers, libdb-utils, tracker-miners, xorg-x11-font- utils, PackageKit-command-not-found, libcom_err, libseccomp, p11-kit, libabw, libvirt-daemon-driver-storage-iscsi, libmodman, argyllcms, parted, gnome-disk-utility, libdvdread, zstd, bluez-libs, libwebp, libxslt, system-config-printer-udev, perl-Encode, libverto-libev, python2-cryptography, libevdev, libgpg-error, lvm2-libs, perl-Digest- SHA, libzstd, qemu-system-ppc-core, libdazzle, avahi, lua-lpeg, symlinks, libcdr, cdparanoia-libs, e2fsprogs-libs, pulseaudio-libs, libdwarf, lcms2, qemu-guest-agent, annobin, ntfs-3g, libxcb, libyubikey, sssd-common-pac, python3-brlapi, openconnect, xcb-util- keysyms, m4, expat, libgphoto2, xcb-util, gvfs-fuse, udisks2-iscsi, python3-coverage, weechat, anaconda-widgets, http-parser, file-roller- nautilus, libeot, systemd-bootchart, dbusmenu-qt, ncurses-libs, libidn2, checkpolicy, libreport-plugin-logger, gnome-color-manager, fcoe-utils, xorg-x11-xkb-utils, ibus-hangul, perl-IO-Tty, NetworkManager-openvpn, libxkbfile, hplip-libs, libwvstreams, ghc- binary, freerdp-libs, xmlrpc-c-client, sane-backends-drivers-cameras, libwpg, libwpd, enchant2, libvirt-daemon-driver-qemu, perl-Time-HiRes, qemu-block-ssh, libwps, gssdp, gnome-calendar, libacl, xorg-x11-drv- ati, libSM, policycoreutils, mcelog, abrt-plugin-bodhi, libmusicbrainz5, ghc-unix, pptp, sane-backends-drivers-scanners, libXxf86misc, foomatic, minizip, colord-gtk, nspr, rpm-build, libvirt- daemon-driver-storage-sheepdog, libglvnd-gles, python3-audit, rpm- plugin-systemd-inhibit, gstreamer1, gom, gmime30, webkit2gtk3-plugin- process-gtk2, dbus-libs, libreoffice-gtk3, libreoffice-gtk2, cairo- gobject, gnome-screenshot, libkkc, gutenprint, usermode, qpdf-libs, linux-atm-libs, libedit, openssh, subversion-libs, openssl, python3-cairo, accountsservice, ghc-containers, isl, hfsplus-tools, gssproxy, libblockdev-btrfs, libatomic_ops, gupnp-av, librepo, gtk- update-icon-cache, python3-iscsi-initiator-utils, libvirt-daemon- driver-interface, NetworkManager, liblangtag, NetworkManager-glib, libdatrie, glade-libs, setuptool, libcryptui, guile, pcre-utf16, tree, gvfs-goa, pipewire, gnupg, cronie-anacron, libserf, xfsprogs, authselect, libcroco, telepathy-glib, plymouth-plugin-label, libisoburn, colord-libs, totem-pl-parser, gpgmepp, libgcab1, libzhuyin, gvnc, hypervfcopyd, cronie, libexttextcat, nettle, libcacard, elfutils, colord, libpipeline, pkcs11-helper, accountsservice-libs, gnome-system-monitor, findutils, popt, libsss_idmap, libraw1394, boost-atomic, folks, gnome-clocks, python3-dbus, iproute-tc, isomd5sum, spice-glib, woff2, dotconf, libXfont, PackageKit-glib, patch, sqlite-libs, lttng-ust, enchant, libXxf86dga, python2-smartcols, xdg-user-dirs-gtk, perl-Data-Dumper, libwayland-client, pinentry-gnome3, libsmbios, libipt, mdadm, gnome- calculator, device-mapper, python2-librepo, libXtst, xapian-core-libs, gnome-terminal, GeoIP, libsigc++20, python2-talloc, libXrandr, sssd- ldap, liba52, hplip, ghc-QuickCheck, crda, libical, sheepdog, qt5-qtdeclarative, libXfont2, libblockdev-loop, libssh2, NetworkManager-adsl, open-vm-tools-desktop, samba-dc-libs, xmlsec1-nss, libXcursor, iio-sensor-proxy, bridge-utils, procps-ng, plymouth-core-libs, telnet, simple-scan, libXpm, xorg-x11-drv-nouveau, bluez-obexd, zlib, libpeas, pam_krb5, gutenprint-cups, grub2-tools- efi, xdg-desktop-portal-gtk, libselinux, libassuan, sushi, cups- filters, iw, clutter-gtk, userspace-rcu, qemu-system-sh4-core, libblockdev-utils, libgudev, ibus-libpinyin, setroubleshoot-server, make, python3-markupsafe, libseccomp-devel, libnice, libsoup, glusterfs-api, fuse, perl-Net-SSLeay, perl-Filter, cups-libs, libappstream-glib, libsepol, efivar, gzip, keyutils, libipa_hbac, libfdisk, libdmx, openssl-libs, corosynclib, opencc, libreport-plugin- reportuploader, qemu-system-moxie-core, gavl, ipset, freerdp, unique, keybinder3, deltarpm, fuse-libs, xorg-x11-xauth, libglvnd-glx, gvfs- smb, libcue, libXrender, json-glib, libX11-xcb, libfontenc, libicu, libgsf, xorg-x11-drv-vmware, sssd-common, NetworkManager-openconnect, libgtop2, btrfs-progs, tracker, wvdial, sni-qt, mesa-libglapi, bolt, glx-utils, NetworkManager-vpnc-gnome, evolution-data-server, PackageKit, perl-MIME-Base64, ghc-time, wpa_supplicant, golang-github- cpuguy83-go-md2man, libstdc++, ppp, git, mpg123-libs, opus, ctags, git-core, libxklavier, traceroute, cyrus-sasl-plain, dyninst, libblockdev-crypto, libreoffice-pdfimport, rp-pppoe, libtheora, attr, mtr, gtksourceview3, libcanberra-gtk2, libcanberra-gtk3, mtdev, libmspack, systemd-udev, libXvMC, cheese-libs, libXmu, capstone, libreoffice-impress, jasper-libs, librbd1, device-mapper-libs, xorg-x11-xinit, gnome-initial-setup, pyliblzma, libffi, pcre-utf32, python2-hawkey, diffutils, chrony, time, mpfr, ghc-array, iputils, qt5-qtxmlpatterns, numactl-libs, libvirt-daemon-driver-nwfilter, tigervnc-server-minimal, gpgme, hypervvssd, xorg-x11-drv-openchrome, libmcpp, libibverbs, gdb-headless, ghc-ghc-boot-th, dleyna-core, qemu- block-nfs, libgovirt, libqmi-utils, libmbim-utils, psacct, lame-libs, gnome-bluetooth-libs, usbredir, ghostscript, libtirpc, iptables-libs, cryptsetup-libs, gnome-control-center, syslinux-extlinux, bind-libs, ghostscript-x11, lua-posix, libinput, libreport-cli, libpkgconf, python3-dmidecode, abrt-gui-libs, libosinfo, corosync, libreoffice- calc, libqmi, gawk, dmraid-events, pcsc-lite-libs, adwaita-gtk2-theme, libbasicobjects, baobab, rdma-core, vte291, libgweather, sssd-krb5, qemu-block-iscsi, ghc-regex-base, libgrss, httpd, perf, libsmbclient, pulseaudio-utils, rpm-sign-libs, libvdpau, compat-openssl10, abrt- addon-kerneloops, gnome-maps, openCOLLADA, xcb-util-renderutil, libwinpr, sssd-ad, libpinyin, freetype, logrotate, rdist, scl-utils, libdnet, ntfsprogs, abrt-libs, efibootmgr, libgdither, samba-common- libs, libpsl, qemu-system-or1k-core, python3-rpm, nautilus-sendto, fwupdate-libs, jimtcl, libuser, lz4-libs, graphviz, kexec-tools, boost-date-time, satyr, gts, pixman, gnome-font-viewer, xorg-x11-drv- vesa, libbluray, cifs-utils, libbabeltrace, librados-devel, vpnc, psmisc, net-snmp-libs, xorg-x11-drv-libinput, libsss_certmap, libblockdev-mpath, cairo, libgcc, libmng, poppler, libstemmer, djvulibre-libs, bison, ibus-libzhuyin, libconfig, ModemManager, abrt- gui, ibus-m17n, qemu-img, qt5-qtbase-gui, ghc-pretty, rtkit, orc, polkit, libuuid, libarchive, libfreehand, ibus-gtk3, ibus-gtk2, ghc- deepseq, qemu-system-aarch64-core, cryptsetup, udisks2, clucene- contribs-lib, paps-libs, tcp_wrappers, xz, libXcomposite, rpcbind, mtools, vim-minimal, harfbuzz-icu, libplist, xdg-user-dirs, glusterfs- libs, spice-server, gdk-pixbuf2, gupnp, libreport, libevent, redland, python2-cccolutils, tcpdump, gnome-characters, libblockdev-kbd, libblockdev, librdmacm, lua-socket, dconf, xz-libs, dbus-glib, PackageKit-gtk3-module, libdvdnav, libcap, libvirt-daemon-driver- storage-zfs, libwbclient, libvirt-daemon-driver-storage-gluster, numad, mod_http2, libthai, perl-NKF, fakeroot, gnome-session, nss- tools, adcli, iproute, python2-gpg, libsmartcols, gsound, fakeroot- libs, python3-hawkey, os-prober, ethtool, info, ghc-directory, qemu- system-alpha-core, libfprint, systemd-libs, cpio, libfdt, util-linux, libburn, krb5-libs, gnome-online-accounts, net-tools, enca, libblockdev-part, libpciaccess, clucene-core, libsss_autofs, kmod, NetworkManager-ssh-gnome, NetworkManager-pptp, libetonyek, plymouth, libgs, gnome-user-share, sssd-client, libgxps, systemd, jq, libpagemaker, webkit2gtk3-jsc, libxkbcommon, device-mapper-multipath- libs, yajl, lockdev, cups-filters-libs, poppler-utils, lpsolve, gnome- terminal-nautilus, xorg-x11-server-utils, gnupg2, ghc-parsec, gpgme- devel, cracklib, evince-libs, libepubgen, moreutils, libdnf, qemu- system-m68k-core, abrt-addon-pstoreoops, gnome-keyring, pulseaudio- libs-glib2, netpbm, lxpolkit, nm-connection-editor, python3-pyparted, libudisks2, gstreamer1-plugins-bad-free, python3-setools, clutter, zenity, rhythmbox, chkconfig, libgnome-keyring, hostname, iscsi- initiator-utils, librados2, libvirt-daemon-driver-storage-mpath, ShellCheck, pam, python2-cffi, openldap, libXft, evince-nautilus, ipcalc, NetworkManager-team, speex, libvirt-daemon-driver-storage- logical, ibus-wayland, neon, rest, libsamplerate, python2-lxml, samba- libs, boost-iostreams, geocode-glib, pakchois, subversion, zfs-fuse, systemtap-runtime, libusbmuxd, perl-Unicode-Normalize, sssd-kcm, libimobiledevice, lzop, NetworkManager-wwan, polkit-pkla-compat, jbig2dec-libs, libmtp, cyrus-sasl-lib, librevenge, libpath_utils, gjs, python3-gobject-base, gnome-settings-daemon, dnsmasq, geoclue2-libs, libXfixes, libblkid, libcdio, libsss_sudo, rsync, rpm, lua-libs, perl- Params-Util, authselect-libs, soundtouch, xorg-x11-drv-evdev, libpeas- gtk, libXinerama, libteam, vim-enhanced, libcmis, elfutils-libs, acl, libogg, qemu-system-lm32-core, gupnp-igd, libgee, libXxf86vm, mesa- libEGL, systemd-pam, perl-Storable, perl-Digest-MD5, gvfs-gphoto2, perl-Sort-Key, libvirt-daemon-driver-storage-rbd, libnfsidmap, nss- util, libsemanage, marisa, ghc-primitive, mozjs52, systemd-container, libcomps, file, libblockdev-fs, java-1.8.0-openjdk-headless, libnma, gettext, pcre2-utf32, soxr, espeak, libvirt-gobject, libutempter, libmetalink, slang, gvfs-afp, pulseaudio, e2fsprogs, libcdio-paranoia, grub2-tools-minimal, cpp, libksba, busybox, libwayland-server, virglrenderer, gdbm, osinfo-db-tools, libsndfile, libvisio, ruby-libs, bzip2-libs, sshpass, openssl-pkcs11, gnutls, device-mapper-persistent- data, python2-krbv, gd, libselinux-utils, perl-Scalar-List-Utils, dosfstools, rng-tools, gnome-abrt, libspectre, keyutils-libs, libproxy, libreoffice-math, libtimezonemap, ghc-base, glusterfs-fuse, anaconda-core, libatasmart, mlocate, tmux, file-libs, grub2-tools, avahi-glib, mokutil, libblockdev-swap, libnetfilter_conntrack, python3-gobject, libev, frei0r-plugins, fprintd-pam, libusbx, NetworkManager-openvpn-gnome, qrencode-libs, libICE, libgexiv2, drpm, createrepo_c-libs, grilo, speexdsp, upower, libreoffice-x11, nautilus, xcb-util-wm, diffstat, atk, docker-ce, dbxtool, alsa-lib, gstreamer1 -plugins-good-gtk, libwnck3, gtkmm24, libvirt-daemon-driver-storage- disk, brasero-libs, mesa-dri-drivers, sgpio, python3-abrt, gdbm-libs, fribidi, libgnomekbd, NetworkManager-ssh, ibus-rawcode, pciutils, libini_config, openssh-clients, libX11, celt051, htop, kyotocabinet- libs, python3-pwquality, gvfs-mtp, python3-cryptography, gnome- bluetooth, ghc-template-haskell, u2f-hidraw-policy, libnl3, libidn, grubby, python3-libreport, epiphany-runtime, libbytesize, qemu-block- rbd, python3-systemd, rpm-ostree-libs, libnl3-cli, ibus-libs, python2-libcomps, python2-pyyaml, audit-libs, bluez, gettext-libs, liborcus, libref_array, gvfs-afc, switcheroo-control, fwupd, raptor2, qemu-system-sparc-core, plymouth-plugin-two-step, sbc, qt-x11, libsane-hpaio, ghc-random, libhangul, bash, poppler-glib, libgpod, seahorse, libblockdev-lvm, utf8proc, ibus-kkc, lvm2, harfbuzz, ghc- syb, cups, dmraid, tokyocabinet, python3-wrapt, gvfs-client, NetworkManager-libnm, urlview, python2-libs, ibus-qt, gnome-boxes, lrzsz, libglvnd-egl, libunwind, dhcp-libs, dpkg, libtalloc, grep, hypervkvpd, libepoxy, perl-Variable-Magic, man-db, gedit, libvirt- daemon-driver-storage-core, libzapojit, mesa-libgbm, gnome-desktop3, timedatex, xdg-desktop-portal, python3-pycurl, sssd-nfs-idmap, rasqal, wireless-tools, libdb, passwd, cups-pk-helper, quota, kmod-libs, libdv, gutenprint-libs, libreoffice-writer, desktop-file-utils, libXdamage, xorg-x11-utils, libmwaw, libusal, gcc-gdb-plugin, dleyna- connector-dbus, gtkmm30, libgit2, gobject-introspection, libpwquality, fontconfig, patchutils, libblockdev-dm, ghc-mtl, evince-djvu, libkcapi-hmaccalc, libtar, libdaemon, qemu-system-s390x-core, qemu- lite-bin, tcl, flatpak, python3-librepo, pkgconf, vino, json-c, sed, sssd-ipa, perl-threads-shared, glib-networking, gdm, kpartx, libpng, sane-backends-libs, python3-pillow, cyrus-sasl, hardlink, libcollection, libgcrypt, cairomm, perl-Unicode-UTF8, nss-softokn, lasi, geoclue2, lsof, binutils, libnsl2, gnome-online-miners, twolame- libs, adwaita-qt4, adwaita-qt5, gnome-shell, xorg-x11-server-Xorg, usbmuxd, libmbim, perl-IO, libverto, glibmm24, libXScrnSaver, realmd, libmspub, ncurses, nfs-utils, graphite2, python3-kerberos, perl- version, libreport-plugin-kerneloops, gmp, sssd-krb5-common, volume_key-libs, qemu-system-cris-core, b43-fwcutter, alsa-plugins- pulseaudio, perl-interpreter, powerline, bluez-cups, chromium-libs- media, libcurl, gperftools-libs, coreutils, libcap-ng, gvfs, dbus-x11, pinentry, libvirt-daemon-driver-storage-scsi, libmpcdec, nautilus- extensions, qemu-common, gsm, boost-filesystem, libtevent, libchamplain, libglvnd, gnome-documents-libs, boost-system, libpcap, snappy, socat, clutter-gst3, libdrm, genisoimage, brotli, pcre2, shotwell, xmlrpc-c, perl-TermReadKey, cogl, rygel, python3-PyYAML, libvirt-glib, telepathy-logger, libssh, libmodulemd, GConf2, glibc, flatpak-libs, fipscheck, mactel-boot, bc, ghc-bytestring, gtk-vnc2, qemu-system-mips-core, wget, libijs, ghc-filepath, libreport-web, libgomp, libexif, libkadm5, libgusb, glib2, qemu-system-x86-core, startup-notification, pcre2-utf16, libmnl, libzmf, gdisk, nss, pcre, libchamplain-gtk, tcp_wrappers-libs, sane-backends, gstreamer1 -plugins-base, speech-dispatcher, pciutils-libs, libiptcdata, libmpc, libXi, file-roller, openjpeg2, flac-libs, libXt, libXv, rpm-libs, libreofficekit, libnfnetlink, libiec61883, libkcapi, device-mapper- event, libreport-plugin-bugzilla, qt5-qtbase, libpskc, ibus, jwhois, qemu-block-dmg, curl, qemu-system-nios2-core, yelp-libs, oniguruma, libdmapsharing, fipscheck-lib, python2-pycurl, dos2unix, paps, libqxp, abrt-tui, abrt-addon-xorg, libdhash, gnome-keyring-pam, sssd-proxy, totem, ghc-json, gc, python3-cups, libxshmfence, ncurses-c++-libs, ghc-text, libreport-plugin-systemd-journal, gstreamer1-plugins-ugly- free, unzip, gtk2, gtk3, libwayland-egl, libv4l, atkmm, npth, abrt- addon-coredump-helper, systemtap-client, libyaml, mercurial, libXau, gspell, xcb-util-image, m17n-lib, libblockdev-mdraid, glusterfs, exiv2-libs, libunistring, dleyna-server, qgnomeplatform, gstreamer1 -plugins-good, python2-rpm, libasyncns, qemu-block-curl, device- mapper-multipath, c-ares, xmlsec1-openssl, gfbgraph, NetworkManager- pptp-gnome, jansson, bind-utils, librsvg2, firefox, apr, libsss_nss_idmap, gupnp-dlna, trousers-lib, zip, webrtc-audio- processing, bcache-tools, libproxy-mozjs, libstaroffice, pinfo, bubblewrap, libtasn1, jbigkit-libs, libe-book, alsa-utils, sqlite, tar, sudo, speech-dispatcher-espeak, dhcp-client, fprintd, pinentry- gtk, gcc, dwz, xorg-x11-drv-qxl, gcr, ebtables, avahi-libs, pigz, libquvi, qemu-system-tricore-core, gvfs-archive, libqb, libao, perl- libs, systemtap-devel, lz4, kbd, mutt, libreoffice-core, libphodav, libwayland-cursor, openvpn, libpaper, chromium-libs, libwacom, lzo, pango, libss, aspell, mod_dnssd, dbus, polkit-libs, perl-threads, perl-Params-Validate, pangomm, mesa-libxatracker, nss-sysinit, LibRaw, nss-mdns, qemu-system-unicore32-core, python3-cffi, at-spi2-core, libvirt-daemon-driver-network, glibc-common, bind-export-libs, gnome- autoar, qemu-vanilla-bin, python3-libxml2, libnfs, stoken-libs, gnome- contacts, libiscsi, groff-base, libusb, mesa-libGL, abrt-addon-ccpp, libldb, bind-libs-lite, NetworkManager-vpnc, libvirt-daemon-driver- nodedev, libXres, libcanberra, PackageKit-gstreamer-plugin, wavpack, xorg-x11-drv-wacom, libsrtp, perl-Package-Stash-XS, samba-client-libs, which, boost-chrono, samba-client, libaio, lua-expat, libshout, libvirt-gconfig, brlapi, strace, createrepo_c, libreport-gtk, liboauth, lmdb-libs, libgpg-error-devel, xmlsec1, gnome-todo, isns- utils-libs, libwsman1, krb5-workstation, nmap-ncat, ykpers, qemu- system-xtensa-core, lksctp-tools, libgltf, usb_modeswitch, mythes, NetworkManager-wifi, qt, abrt-retrace-client, teamd, libvorbis, NetworkManager-openconnect-gnome, vconfig, pcre-cpp, python3-libselinux, libodfgen, liblouis, exiv2, iptables, lua, xorriso, qemu-user, ghc-regex-tdfa, libpeas-loader-python3, llvm-libs, gnome-logs, doxygen, pulseaudio-module-bluetooth, libvirt-libs, connect-proxy, passwdqc, libvirt-daemon-driver-secret, libattr, hyphen, gnupg2-smime, gnome-software, syslinux, libxcrypt, newt, iptstate, glib2-devel, libreport-plugin-ureport, radvd, python3-libs, glusterfs-cli, perl-PathTools, ipset-libs, plymouth-graphics-libs, mozjs38, gnome-menus, glusterfs-client-xlators, libreoffice-pyuno, libxml2, libgepub, libreoffice-ure, iscsi-initiator-utils-iscsiuio, cyrus-sasl-gssapi, mpage, libargon2, libnm-gtk, mousetweaks, libvirt- daemon, libsecret, p11-kit-trust, NetworkManager-bluetooth, augeas- libs, libsysfs, audit, abrt-dbus, boost-locale, gdk-pixbuf2-modules, at-spi2-atk, xen-libs, libisofs, nss-pem, vim-common, python2-kerberos, less, brltty, libvpx, evince, rpm-build-libs, libnghttp2, ostree-libs, totem-nautilus, libsolv, exempi, libxkbcommon-x11, chromium, libtdb, python3-gpg, libXdmcp, perl- Socket, qemu-system-microblaze-core, apr-util, libvisual, python3, python2, gpm-libs, xorg-x11-server-Xwayland, shared-mime-info, httpd- tools, SDL2, webkit2gtk3, libsigsegv, boost-thread, grilo-plugins, shadow-utils, libcgroup, libXaw, cheese, netcf-libs, libgdata, pulseaudio-module-x11, dmidecode, python3-libcomps, libjpeg-turbo, spice-gtk3, libmount, spice-vdagent, xorg-x11-drv-wacom-serial- support, xorg-x11-drv-fbdev, qemu-system-arm-core, libavc1394, lldpad, libtiff, python3-libsemanage, sg3_utils-libs, libnotify, ima-evm- utils, w3m, ghc-tf-random, python2-gobject-base, python3-pygit2, grub2 -tools-extra, openssh-server, mutter, taglib, libXext, mcpp, ModemManager-glib, dracut, ostree, device-mapper-event-libs, initscripts, hunspell, libieee1284, libndp, usbutils, bzip2, elfutils- libelf, nss-softokn-freebl, open-vm-tools, python3-smartcols, libtool- ltdl, readline, eog, yelp, xorg-x11-drv-intel, abrt-java-connector, passwdqc-lib), /usr/lib/.build-id/19(nss-tools, libxkbcommon-x11, perl-threads-shared, xorg-x11-server-Xorg, httpd, samba-dc-libs, perl- Encode, glibc, libgpg-error, frei0r-plugins, ruby-libs, policycoreutils, glusterfs-libs, libiptcdata, libdb-utils, dyninst, python3-libs, libcryptui, brltty, libreoffice-writer, util-linux, cyrus-sasl-lib, cups-libs, net-tools), /usr/libexec/kata-containers (kata-shim-bin, kata-proxy-bin, kata-runtime) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kata- proxy-debuginfo , kata-proxy-debugsource [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: kata-proxy-1.3.1-1.gitd364b2e.fc28.x86_64.rpm kata-proxy-debuginfo-1.3.1-1.gitd364b2e.fc28.x86_64.rpm kata-proxy-debugsource-1.3.1-1.gitd364b2e.fc28.x86_64.rpm kata-proxy-1.3.1-1.gitd364b2e.fc28.src.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: kata-proxy-debuginfo-1.3.1-1.gitd364b2e.fc28.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory kata-proxy-debuginfo.x86_64: W: invalid-url URL: https://github.com/kata-containers/proxy <urlopen error [Errno -2] Name or service not known> kata-proxy-debugsource.x86_64: W: invalid-url URL: https://github.com/kata-containers/proxy <urlopen error [Errno -2] Name or service not known> kata-proxy.x86_64: W: invalid-url URL: https://github.com/kata-containers/proxy <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Diff spec file in url and in SRPM --------------------------------- --- /home/jcvenega/1590423-kata-proxy/srpm/kata-proxy.spec 2018-11-20 11:45:32.940266611 -0600 +++ /home/jcvenega/1590423-kata-proxy/srpm-unpacked/kata-proxy.spec 2018-11-10 18:00:02.000000000 -0600 @@ -19,5 +19,5 @@ Name: kata-%{repo} Version: 1.3.1 -Release: 2.git%{shortcommit0}%{?dist} +Release: 1.git%{shortcommit0}%{?dist} ExclusiveArch: x86_64 URL: %{git0} @@ -30,12 +30,4 @@ License: ASL 2.0 -Provides: bundled(golang(github.com/davecgh/go-spew)) = v1.1.0 -Provides: bundled(golang(github.com/hashicorp/yamux)) = f5742cb6 -Provides: bundled(golang(github.com/pmezard/go-difflib)) = v1.0.0 -Provides: bundled(golang(github.com/sirupsen/logrus)) = v1.0.4 -Provides: bundled(golang(github.com/stretchr/testify)) = v1.2.1 -Provides: bundled(golang(golang.org/x/crypto)) = 13931e22f9e72ea58bb73048bc752b48c6d4d4ac -Provides: bundled(golang(golang.org/x/sys)) = 810d7000345868fc619eb81f46307107118f4ae1 - %description %{summary} @@ -69,7 +61,4 @@ %changelog -* Mon Nov 12 2018 Lokesh Mandvekar <lsm5> - 1.3.1-2.gitd364b2e -- bundled Provides - * Sat Nov 10 2018 Lokesh Mandvekar <lsm5> - 1.3.1-1.gitd364b2e - bump to v1.3.1 Requires -------- kata-proxy-debuginfo (rpmlib, GLIBC filtered): kata-proxy-debugsource (rpmlib, GLIBC filtered): kata-proxy (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) Provides -------- kata-proxy-debuginfo: debuginfo(build-id) kata-proxy-debuginfo kata-proxy-debuginfo(x86-64) kata-proxy-debugsource: kata-proxy-debugsource kata-proxy-debugsource(x86-64) kata-proxy: kata-proxy kata-proxy(x86-64) Source checksums ---------------- https://github.com/kata-containers/proxy/archive/d364b2eb390142179e4640ee402df9165dd0d67c/proxy-d364b2e.tar.gz : CHECKSUM(SHA256) this package : 20f77262afaf71a70d0efdd7d76f349d8d65336dc13c2de314611d4712d5faef CHECKSUM(SHA256) upstream package : 20f77262afaf71a70d0efdd7d76f349d8d65336dc13c2de314611d4712d5faef Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1590423 Buildroot used: fedora-28-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [-]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT/X11 (BSD like)", "*No copyright* MPL (v2.0)", "BSD (3 clause)", "ISC", "*No copyright* Apache (v2.0)". 290 files have unknown license. Detailed output of licensecheck in /home/jcvenega/1590423-kata-proxy/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(cups- client, efivar-libs, qemu-block-gluster, rpm-plugin-selinux, abrt, ghc-transformers, libmediaart, libimagequant, giflib, libreoffice- graphicfilter, trousers, libdb-utils, tracker-miners, xorg-x11-font- utils, PackageKit-command-not-found, libcom_err, libseccomp, p11-kit, libabw, libvirt-daemon-driver-storage-iscsi, libmodman, argyllcms, parted, gnome-disk-utility, libdvdread, zstd, bluez-libs, libwebp, libxslt, system-config-printer-udev, perl-Encode, libverto-libev, python2-cryptography, libevdev, libgpg-error, lvm2-libs, perl-Digest- SHA, libzstd, qemu-system-ppc-core, libdazzle, avahi, lua-lpeg, symlinks, libcdr, cdparanoia-libs, e2fsprogs-libs, pulseaudio-libs, libdwarf, lcms2, qemu-guest-agent, annobin, ntfs-3g, libxcb, libyubikey, sssd-common-pac, python3-brlapi, openconnect, xcb-util- keysyms, m4, expat, libgphoto2, xcb-util, gvfs-fuse, udisks2-iscsi, python3-coverage, weechat, anaconda-widgets, http-parser, file-roller- nautilus, libeot, systemd-bootchart, dbusmenu-qt, ncurses-libs, libidn2, checkpolicy, libreport-plugin-logger, gnome-color-manager, fcoe-utils, xorg-x11-xkb-utils, ibus-hangul, perl-IO-Tty, NetworkManager-openvpn, libxkbfile, hplip-libs, libwvstreams, ghc- binary, freerdp-libs, xmlrpc-c-client, sane-backends-drivers-cameras, libwpg, libwpd, enchant2, libvirt-daemon-driver-qemu, perl-Time-HiRes, qemu-block-ssh, libwps, gssdp, gnome-calendar, libacl, xorg-x11-drv- ati, libSM, policycoreutils, mcelog, abrt-plugin-bodhi, libmusicbrainz5, ghc-unix, pptp, sane-backends-drivers-scanners, libXxf86misc, foomatic, minizip, colord-gtk, nspr, rpm-build, libvirt- daemon-driver-storage-sheepdog, libglvnd-gles, python3-audit, rpm- plugin-systemd-inhibit, gstreamer1, gom, gmime30, webkit2gtk3-plugin- process-gtk2, dbus-libs, libreoffice-gtk3, libreoffice-gtk2, cairo- gobject, gnome-screenshot, libkkc, gutenprint, usermode, qpdf-libs, linux-atm-libs, libedit, openssh, subversion-libs, openssl, python3-cairo, accountsservice, ghc-containers, isl, hfsplus-tools, gssproxy, libblockdev-btrfs, libatomic_ops, gupnp-av, librepo, gtk- update-icon-cache, python3-iscsi-initiator-utils, libvirt-daemon- driver-interface, NetworkManager, liblangtag, NetworkManager-glib, libdatrie, glade-libs, setuptool, libcryptui, guile, pcre-utf16, tree, gvfs-goa, pipewire, gnupg, cronie-anacron, libserf, xfsprogs, authselect, libcroco, telepathy-glib, plymouth-plugin-label, libisoburn, colord-libs, totem-pl-parser, gpgmepp, libgcab1, libzhuyin, gvnc, hypervfcopyd, cronie, libexttextcat, nettle, libcacard, elfutils, colord, libpipeline, pkcs11-helper, accountsservice-libs, gnome-system-monitor, findutils, popt, libsss_idmap, libraw1394, boost-atomic, folks, gnome-clocks, python3-dbus, iproute-tc, isomd5sum, spice-glib, woff2, dotconf, libXfont, PackageKit-glib, patch, sqlite-libs, lttng-ust, enchant, libXxf86dga, python2-smartcols, xdg-user-dirs-gtk, perl-Data-Dumper, libwayland-client, pinentry-gnome3, libsmbios, libipt, mdadm, gnome- calculator, device-mapper, python2-librepo, libXtst, xapian-core-libs, gnome-terminal, GeoIP, libsigc++20, python2-talloc, libXrandr, sssd- ldap, liba52, hplip, ghc-QuickCheck, crda, libical, sheepdog, qt5-qtdeclarative, libXfont2, libblockdev-loop, libssh2, NetworkManager-adsl, open-vm-tools-desktop, samba-dc-libs, xmlsec1-nss, libXcursor, iio-sensor-proxy, bridge-utils, procps-ng, plymouth-core-libs, telnet, simple-scan, libXpm, xorg-x11-drv-nouveau, bluez-obexd, zlib, libpeas, pam_krb5, gutenprint-cups, grub2-tools- efi, xdg-desktop-portal-gtk, libselinux, libassuan, sushi, cups- filters, iw, clutter-gtk, userspace-rcu, qemu-system-sh4-core, libblockdev-utils, libgudev, ibus-libpinyin, setroubleshoot-server, make, python3-markupsafe, libseccomp-devel, libnice, libsoup, glusterfs-api, fuse, perl-Net-SSLeay, perl-Filter, cups-libs, libappstream-glib, libsepol, efivar, gzip, keyutils, libipa_hbac, libfdisk, libdmx, openssl-libs, corosynclib, opencc, libreport-plugin- reportuploader, qemu-system-moxie-core, gavl, ipset, freerdp, unique, keybinder3, deltarpm, fuse-libs, xorg-x11-xauth, libglvnd-glx, gvfs- smb, libcue, libXrender, json-glib, libX11-xcb, libfontenc, libicu, libgsf, xorg-x11-drv-vmware, sssd-common, NetworkManager-openconnect, libgtop2, btrfs-progs, tracker, wvdial, sni-qt, mesa-libglapi, bolt, glx-utils, NetworkManager-vpnc-gnome, evolution-data-server, PackageKit, perl-MIME-Base64, ghc-time, wpa_supplicant, golang-github- cpuguy83-go-md2man, libstdc++, ppp, git, mpg123-libs, opus, ctags, git-core, libxklavier, traceroute, cyrus-sasl-plain, dyninst, libblockdev-crypto, libreoffice-pdfimport, rp-pppoe, libtheora, attr, mtr, gtksourceview3, libcanberra-gtk2, libcanberra-gtk3, mtdev, libmspack, systemd-udev, libXvMC, cheese-libs, libXmu, capstone, libreoffice-impress, jasper-libs, librbd1, device-mapper-libs, xorg-x11-xinit, gnome-initial-setup, pyliblzma, libffi, pcre-utf32, python2-hawkey, diffutils, chrony, time, mpfr, ghc-array, iputils, qt5-qtxmlpatterns, numactl-libs, libvirt-daemon-driver-nwfilter, tigervnc-server-minimal, gpgme, hypervvssd, xorg-x11-drv-openchrome, libmcpp, libibverbs, gdb-headless, ghc-ghc-boot-th, dleyna-core, qemu- block-nfs, libgovirt, libqmi-utils, libmbim-utils, psacct, lame-libs, gnome-bluetooth-libs, usbredir, ghostscript, libtirpc, iptables-libs, cryptsetup-libs, gnome-control-center, syslinux-extlinux, bind-libs, ghostscript-x11, lua-posix, libinput, libreport-cli, libpkgconf, python3-dmidecode, abrt-gui-libs, libosinfo, corosync, libreoffice- calc, libqmi, gawk, dmraid-events, pcsc-lite-libs, adwaita-gtk2-theme, libbasicobjects, baobab, rdma-core, vte291, libgweather, sssd-krb5, qemu-block-iscsi, ghc-regex-base, libgrss, httpd, perf, libsmbclient, pulseaudio-utils, rpm-sign-libs, libvdpau, compat-openssl10, abrt- addon-kerneloops, gnome-maps, openCOLLADA, xcb-util-renderutil, libwinpr, sssd-ad, libpinyin, freetype, logrotate, rdist, scl-utils, libdnet, ntfsprogs, abrt-libs, efibootmgr, libgdither, samba-common- libs, libpsl, qemu-system-or1k-core, python3-rpm, nautilus-sendto, fwupdate-libs, jimtcl, libuser, lz4-libs, graphviz, kexec-tools, boost-date-time, satyr, gts, pixman, gnome-font-viewer, xorg-x11-drv- vesa, libbluray, cifs-utils, libbabeltrace, librados-devel, vpnc, psmisc, net-snmp-libs, xorg-x11-drv-libinput, libsss_certmap, libblockdev-mpath, cairo, libgcc, libmng, poppler, libstemmer, djvulibre-libs, bison, ibus-libzhuyin, libconfig, ModemManager, abrt- gui, ibus-m17n, qemu-img, qt5-qtbase-gui, ghc-pretty, rtkit, orc, polkit, libuuid, libarchive, libfreehand, ibus-gtk3, ibus-gtk2, ghc- deepseq, qemu-system-aarch64-core, cryptsetup, udisks2, clucene- contribs-lib, paps-libs, tcp_wrappers, xz, libXcomposite, rpcbind, mtools, vim-minimal, harfbuzz-icu, libplist, xdg-user-dirs, glusterfs- libs, spice-server, gdk-pixbuf2, gupnp, libreport, libevent, redland, python2-cccolutils, tcpdump, gnome-characters, libblockdev-kbd, libblockdev, librdmacm, lua-socket, dconf, xz-libs, dbus-glib, PackageKit-gtk3-module, libdvdnav, libcap, libvirt-daemon-driver- storage-zfs, libwbclient, libvirt-daemon-driver-storage-gluster, numad, mod_http2, libthai, perl-NKF, fakeroot, gnome-session, nss- tools, adcli, iproute, python2-gpg, libsmartcols, gsound, fakeroot- libs, python3-hawkey, os-prober, ethtool, info, ghc-directory, qemu- system-alpha-core, libfprint, systemd-libs, cpio, libfdt, util-linux, libburn, krb5-libs, gnome-online-accounts, net-tools, enca, libblockdev-part, libpciaccess, clucene-core, libsss_autofs, kmod, NetworkManager-ssh-gnome, NetworkManager-pptp, libetonyek, plymouth, libgs, gnome-user-share, sssd-client, libgxps, systemd, jq, libpagemaker, webkit2gtk3-jsc, libxkbcommon, device-mapper-multipath- libs, yajl, lockdev, cups-filters-libs, poppler-utils, lpsolve, gnome- terminal-nautilus, xorg-x11-server-utils, gnupg2, ghc-parsec, gpgme- devel, cracklib, evince-libs, libepubgen, moreutils, libdnf, qemu- system-m68k-core, abrt-addon-pstoreoops, gnome-keyring, pulseaudio- libs-glib2, netpbm, lxpolkit, nm-connection-editor, python3-pyparted, libudisks2, gstreamer1-plugins-bad-free, python3-setools, clutter, zenity, rhythmbox, chkconfig, libgnome-keyring, hostname, iscsi- initiator-utils, librados2, libvirt-daemon-driver-storage-mpath, ShellCheck, pam, python2-cffi, openldap, libXft, evince-nautilus, ipcalc, NetworkManager-team, speex, libvirt-daemon-driver-storage- logical, ibus-wayland, neon, rest, libsamplerate, python2-lxml, samba- libs, boost-iostreams, geocode-glib, pakchois, subversion, zfs-fuse, systemtap-runtime, libusbmuxd, perl-Unicode-Normalize, sssd-kcm, libimobiledevice, lzop, NetworkManager-wwan, polkit-pkla-compat, jbig2dec-libs, libmtp, cyrus-sasl-lib, librevenge, libpath_utils, gjs, python3-gobject-base, gnome-settings-daemon, dnsmasq, geoclue2-libs, libXfixes, libblkid, libcdio, libsss_sudo, rsync, rpm, lua-libs, perl- Params-Util, authselect-libs, soundtouch, xorg-x11-drv-evdev, libpeas- gtk, libXinerama, libteam, vim-enhanced, libcmis, elfutils-libs, acl, libogg, qemu-system-lm32-core, gupnp-igd, libgee, libXxf86vm, mesa- libEGL, systemd-pam, perl-Storable, perl-Digest-MD5, gvfs-gphoto2, perl-Sort-Key, libvirt-daemon-driver-storage-rbd, libnfsidmap, nss- util, libsemanage, marisa, ghc-primitive, mozjs52, systemd-container, libcomps, file, libblockdev-fs, java-1.8.0-openjdk-headless, libnma, gettext, pcre2-utf32, soxr, espeak, libvirt-gobject, libutempter, libmetalink, slang, gvfs-afp, pulseaudio, e2fsprogs, libcdio-paranoia, grub2-tools-minimal, cpp, libksba, busybox, libwayland-server, virglrenderer, gdbm, osinfo-db-tools, libsndfile, libvisio, ruby-libs, bzip2-libs, sshpass, openssl-pkcs11, gnutls, device-mapper-persistent- data, python2-krbv, gd, libselinux-utils, perl-Scalar-List-Utils, dosfstools, rng-tools, gnome-abrt, libspectre, keyutils-libs, libproxy, libreoffice-math, libtimezonemap, ghc-base, glusterfs-fuse, anaconda-core, libatasmart, mlocate, tmux, file-libs, grub2-tools, avahi-glib, mokutil, libblockdev-swap, libnetfilter_conntrack, python3-gobject, libev, frei0r-plugins, fprintd-pam, libusbx, NetworkManager-openvpn-gnome, qrencode-libs, libICE, libgexiv2, drpm, createrepo_c-libs, grilo, speexdsp, upower, libreoffice-x11, nautilus, xcb-util-wm, diffstat, atk, docker-ce, dbxtool, alsa-lib, gstreamer1 -plugins-good-gtk, libwnck3, gtkmm24, libvirt-daemon-driver-storage- disk, brasero-libs, mesa-dri-drivers, sgpio, python3-abrt, gdbm-libs, fribidi, libgnomekbd, NetworkManager-ssh, ibus-rawcode, pciutils, libini_config, openssh-clients, libX11, celt051, htop, kyotocabinet- libs, python3-pwquality, gvfs-mtp, python3-cryptography, gnome- bluetooth, ghc-template-haskell, u2f-hidraw-policy, libnl3, libidn, grubby, python3-libreport, epiphany-runtime, libbytesize, qemu-block- rbd, python3-systemd, rpm-ostree-libs, libnl3-cli, ibus-libs, python2-libcomps, python2-pyyaml, audit-libs, bluez, gettext-libs, liborcus, libref_array, gvfs-afc, switcheroo-control, fwupd, raptor2, qemu-system-sparc-core, plymouth-plugin-two-step, sbc, qt-x11, libsane-hpaio, ghc-random, libhangul, bash, poppler-glib, libgpod, seahorse, libblockdev-lvm, utf8proc, ibus-kkc, lvm2, harfbuzz, ghc- syb, cups, dmraid, tokyocabinet, python3-wrapt, gvfs-client, NetworkManager-libnm, urlview, python2-libs, ibus-qt, gnome-boxes, lrzsz, libglvnd-egl, libunwind, dhcp-libs, dpkg, libtalloc, grep, hypervkvpd, libepoxy, perl-Variable-Magic, man-db, gedit, libvirt- daemon-driver-storage-core, libzapojit, mesa-libgbm, gnome-desktop3, timedatex, xdg-desktop-portal, python3-pycurl, sssd-nfs-idmap, rasqal, wireless-tools, libdb, passwd, cups-pk-helper, quota, kmod-libs, libdv, gutenprint-libs, libreoffice-writer, desktop-file-utils, libXdamage, xorg-x11-utils, libmwaw, libusal, gcc-gdb-plugin, dleyna- connector-dbus, gtkmm30, libgit2, gobject-introspection, libpwquality, fontconfig, patchutils, libblockdev-dm, ghc-mtl, evince-djvu, libkcapi-hmaccalc, libtar, libdaemon, qemu-system-s390x-core, qemu- lite-bin, tcl, flatpak, python3-librepo, pkgconf, vino, json-c, sed, sssd-ipa, perl-threads-shared, glib-networking, gdm, kpartx, libpng, sane-backends-libs, python3-pillow, cyrus-sasl, hardlink, libcollection, libgcrypt, cairomm, perl-Unicode-UTF8, nss-softokn, lasi, geoclue2, lsof, binutils, libnsl2, gnome-online-miners, twolame- libs, adwaita-qt4, adwaita-qt5, gnome-shell, xorg-x11-server-Xorg, usbmuxd, libmbim, perl-IO, libverto, glibmm24, libXScrnSaver, realmd, libmspub, ncurses, nfs-utils, graphite2, python3-kerberos, perl- version, libreport-plugin-kerneloops, gmp, sssd-krb5-common, volume_key-libs, qemu-system-cris-core, b43-fwcutter, alsa-plugins- pulseaudio, perl-interpreter, powerline, bluez-cups, chromium-libs- media, libcurl, gperftools-libs, coreutils, libcap-ng, gvfs, dbus-x11, pinentry, libvirt-daemon-driver-storage-scsi, libmpcdec, nautilus- extensions, qemu-common, gsm, boost-filesystem, libtevent, libchamplain, libglvnd, gnome-documents-libs, boost-system, libpcap, snappy, socat, clutter-gst3, libdrm, genisoimage, brotli, pcre2, shotwell, xmlrpc-c, perl-TermReadKey, cogl, rygel, python3-PyYAML, libvirt-glib, telepathy-logger, libssh, libmodulemd, GConf2, glibc, flatpak-libs, fipscheck, mactel-boot, bc, ghc-bytestring, gtk-vnc2, qemu-system-mips-core, wget, libijs, ghc-filepath, libreport-web, libgomp, libexif, libkadm5, libgusb, glib2, qemu-system-x86-core, startup-notification, pcre2-utf16, libmnl, libzmf, gdisk, nss, pcre, libchamplain-gtk, tcp_wrappers-libs, sane-backends, gstreamer1 -plugins-base, speech-dispatcher, pciutils-libs, libiptcdata, libmpc, libXi, file-roller, openjpeg2, flac-libs, libXt, libXv, rpm-libs, libreofficekit, libnfnetlink, libiec61883, libkcapi, device-mapper- event, libreport-plugin-bugzilla, qt5-qtbase, libpskc, ibus, jwhois, qemu-block-dmg, curl, qemu-system-nios2-core, yelp-libs, oniguruma, libdmapsharing, fipscheck-lib, python2-pycurl, dos2unix, paps, libqxp, abrt-tui, abrt-addon-xorg, libdhash, gnome-keyring-pam, sssd-proxy, totem, ghc-json, gc, python3-cups, libxshmfence, ncurses-c++-libs, ghc-text, libreport-plugin-systemd-journal, gstreamer1-plugins-ugly- free, unzip, gtk2, gtk3, libwayland-egl, libv4l, atkmm, npth, abrt- addon-coredump-helper, systemtap-client, libyaml, mercurial, libXau, gspell, xcb-util-image, m17n-lib, libblockdev-mdraid, glusterfs, exiv2-libs, libunistring, dleyna-server, qgnomeplatform, gstreamer1 -plugins-good, python2-rpm, libasyncns, qemu-block-curl, device- mapper-multipath, c-ares, xmlsec1-openssl, gfbgraph, NetworkManager- pptp-gnome, jansson, bind-utils, librsvg2, firefox, apr, libsss_nss_idmap, gupnp-dlna, trousers-lib, zip, webrtc-audio- processing, bcache-tools, libproxy-mozjs, libstaroffice, pinfo, bubblewrap, libtasn1, jbigkit-libs, libe-book, alsa-utils, sqlite, tar, sudo, speech-dispatcher-espeak, dhcp-client, fprintd, pinentry- gtk, gcc, dwz, xorg-x11-drv-qxl, gcr, ebtables, avahi-libs, pigz, libquvi, qemu-system-tricore-core, gvfs-archive, libqb, libao, perl- libs, systemtap-devel, lz4, kbd, mutt, libreoffice-core, libphodav, libwayland-cursor, openvpn, libpaper, chromium-libs, libwacom, lzo, pango, libss, aspell, mod_dnssd, dbus, polkit-libs, perl-threads, perl-Params-Validate, pangomm, mesa-libxatracker, nss-sysinit, LibRaw, nss-mdns, qemu-system-unicore32-core, python3-cffi, at-spi2-core, libvirt-daemon-driver-network, glibc-common, bind-export-libs, gnome- autoar, qemu-vanilla-bin, python3-libxml2, libnfs, stoken-libs, gnome- contacts, libiscsi, groff-base, libusb, mesa-libGL, abrt-addon-ccpp, libldb, bind-libs-lite, NetworkManager-vpnc, libvirt-daemon-driver- nodedev, libXres, libcanberra, PackageKit-gstreamer-plugin, wavpack, xorg-x11-drv-wacom, libsrtp, perl-Package-Stash-XS, samba-client-libs, which, boost-chrono, samba-client, libaio, lua-expat, libshout, libvirt-gconfig, brlapi, strace, createrepo_c, libreport-gtk, liboauth, lmdb-libs, libgpg-error-devel, xmlsec1, gnome-todo, isns- utils-libs, libwsman1, krb5-workstation, nmap-ncat, ykpers, qemu- system-xtensa-core, lksctp-tools, libgltf, usb_modeswitch, mythes, NetworkManager-wifi, qt, abrt-retrace-client, teamd, libvorbis, NetworkManager-openconnect-gnome, vconfig, pcre-cpp, python3-libselinux, libodfgen, liblouis, exiv2, iptables, lua, xorriso, qemu-user, ghc-regex-tdfa, libpeas-loader-python3, llvm-libs, gnome-logs, doxygen, pulseaudio-module-bluetooth, libvirt-libs, connect-proxy, passwdqc, libvirt-daemon-driver-secret, libattr, hyphen, gnupg2-smime, gnome-software, syslinux, libxcrypt, newt, iptstate, glib2-devel, libreport-plugin-ureport, radvd, python3-libs, glusterfs-cli, perl-PathTools, ipset-libs, plymouth-graphics-libs, mozjs38, gnome-menus, glusterfs-client-xlators, libreoffice-pyuno, libxml2, libgepub, libreoffice-ure, iscsi-initiator-utils-iscsiuio, cyrus-sasl-gssapi, mpage, libargon2, libnm-gtk, mousetweaks, libvirt- daemon, libsecret, p11-kit-trust, NetworkManager-bluetooth, augeas- libs, libsysfs, audit, abrt-dbus, boost-locale, gdk-pixbuf2-modules, at-spi2-atk, xen-libs, libisofs, nss-pem, vim-common, python2-kerberos, less, brltty, libvpx, evince, rpm-build-libs, libnghttp2, ostree-libs, totem-nautilus, libsolv, exempi, libxkbcommon-x11, chromium, libtdb, python3-gpg, libXdmcp, perl- Socket, qemu-system-microblaze-core, apr-util, libvisual, python3, python2, gpm-libs, xorg-x11-server-Xwayland, shared-mime-info, httpd- tools, SDL2, webkit2gtk3, libsigsegv, boost-thread, grilo-plugins, shadow-utils, libcgroup, libXaw, cheese, netcf-libs, libgdata, pulseaudio-module-x11, dmidecode, python3-libcomps, libjpeg-turbo, spice-gtk3, libmount, spice-vdagent, xorg-x11-drv-wacom-serial- support, xorg-x11-drv-fbdev, qemu-system-arm-core, libavc1394, lldpad, libtiff, python3-libsemanage, sg3_utils-libs, libnotify, ima-evm- utils, w3m, ghc-tf-random, python2-gobject-base, python3-pygit2, grub2 -tools-extra, openssh-server, mutter, taglib, libXext, mcpp, ModemManager-glib, dracut, ostree, device-mapper-event-libs, initscripts, hunspell, libieee1284, libndp, usbutils, bzip2, elfutils- libelf, nss-softokn-freebl, open-vm-tools, python3-smartcols, libtool- ltdl, readline, eog, yelp, xorg-x11-drv-intel, abrt-java-connector, passwdqc-lib), /usr/lib/.build-id/19(nss-tools, libxkbcommon-x11, perl-threads-shared, xorg-x11-server-Xorg, httpd, samba-dc-libs, perl- Encode, glibc, libgpg-error, frei0r-plugins, ruby-libs, policycoreutils, glusterfs-libs, libiptcdata, libdb-utils, dyninst, python3-libs, libcryptui, brltty, libreoffice-writer, util-linux, cyrus-sasl-lib, cups-libs, net-tools), /usr/libexec/kata-containers (kata-shim-bin, kata-proxy-bin, kata-runtime) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [?]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [?]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kata- proxy-debuginfo , kata-proxy-debugsource [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. Kata proxy does not provide compatible check make target [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: kata-proxy-1.3.1-1.gitd364b2e.fc28.x86_64.rpm kata-proxy-debuginfo-1.3.1-1.gitd364b2e.fc28.x86_64.rpm kata-proxy-debugsource-1.3.1-1.gitd364b2e.fc28.x86_64.rpm kata-proxy-1.3.1-1.gitd364b2e.fc28.src.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: kata-proxy-debuginfo-1.3.1-1.gitd364b2e.fc28.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory kata-proxy-debuginfo.x86_64: W: invalid-url URL: https://github.com/kata-containers/proxy <urlopen error [Errno -2] Name or service not known> kata-proxy-debugsource.x86_64: W: invalid-url URL: https://github.com/kata-containers/proxy <urlopen error [Errno -2] Name or service not known> kata-proxy.x86_64: W: invalid-url URL: https://github.com/kata-containers/proxy <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Diff spec file in url and in SRPM --------------------------------- --- /home/jcvenega/1590423-kata-proxy/srpm/kata-proxy.spec 2018-11-20 11:45:32.940266611 -0600 +++ /home/jcvenega/1590423-kata-proxy/srpm-unpacked/kata-proxy.spec 2018-11-10 18:00:02.000000000 -0600 @@ -19,5 +19,5 @@ Name: kata-%{repo} Version: 1.3.1 -Release: 2.git%{shortcommit0}%{?dist} +Release: 1.git%{shortcommit0}%{?dist} ExclusiveArch: x86_64 URL: %{git0} @@ -30,12 +30,4 @@ License: ASL 2.0 -Provides: bundled(golang(github.com/davecgh/go-spew)) = v1.1.0 -Provides: bundled(golang(github.com/hashicorp/yamux)) = f5742cb6 -Provides: bundled(golang(github.com/pmezard/go-difflib)) = v1.0.0 -Provides: bundled(golang(github.com/sirupsen/logrus)) = v1.0.4 -Provides: bundled(golang(github.com/stretchr/testify)) = v1.2.1 -Provides: bundled(golang(golang.org/x/crypto)) = 13931e22f9e72ea58bb73048bc752b48c6d4d4ac -Provides: bundled(golang(golang.org/x/sys)) = 810d7000345868fc619eb81f46307107118f4ae1 - %description %{summary} @@ -69,7 +61,4 @@ %changelog -* Mon Nov 12 2018 Lokesh Mandvekar <lsm5> - 1.3.1-2.gitd364b2e -- bundled Provides - * Sat Nov 10 2018 Lokesh Mandvekar <lsm5> - 1.3.1-1.gitd364b2e - bump to v1.3.1 Requires -------- kata-proxy-debuginfo (rpmlib, GLIBC filtered): kata-proxy-debugsource (rpmlib, GLIBC filtered): kata-proxy (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) Provides -------- kata-proxy-debuginfo: debuginfo(build-id) kata-proxy-debuginfo kata-proxy-debuginfo(x86-64) kata-proxy-debugsource: kata-proxy-debugsource kata-proxy-debugsource(x86-64) kata-proxy: kata-proxy kata-proxy(x86-64) Source checksums ---------------- https://github.com/kata-containers/proxy/archive/d364b2eb390142179e4640ee402df9165dd0d67c/proxy-d364b2e.tar.gz : CHECKSUM(SHA256) this package : 20f77262afaf71a70d0efdd7d76f349d8d65336dc13c2de314611d4712d5faef CHECKSUM(SHA256) upstream package : 20f77262afaf71a70d0efdd7d76f349d8d65336dc13c2de314611d4712d5faef Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1590423 Buildroot used: fedora-28-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/kata/fedora-rawhide-x86_64/00827561-kata-proxy/kata-proxy-1.3.1-5.gitd364b2e.fc30.src.rpm Now built for all supported arches.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kata-proxy
kata-proxy seems to be in Fedora repos nowadays, so closing this