Bug 1590431 (FEDORA_KATA_QEMU_LITE) - Review Request: qemu-lite - OpenBIOS development utilities
Summary: Review Request: qemu-lite - OpenBIOS development utilities
Keywords:
Status: CLOSED NOTABUG
Alias: FEDORA_KATA_QEMU_LITE
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Frantisek Kluknavsky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FEDORA_KATA_TRACKER
TreeView+ depends on / blocked
 
Reported: 2018-06-12 15:07 UTC by Lokesh Mandvekar
Modified: 2018-11-22 13:22 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-11-22 13:22:18 UTC
Type: ---
Embargoed:
lsm5: fedora-review?


Attachments (Terms of Use)

Description Lokesh Mandvekar 2018-06-12 15:07:42 UTC
Spec URL: https://pagure.io/qemu-lite/blob/master/f/qemu-lite.spec
SRPM URL: TBD
Description: TBD
Fedora Account System Username: lsm5

Comment 1 Lokesh Mandvekar 2018-06-27 05:32:33 UTC
Spec URL: https://pagure.io/kata-rpm-reviews/blob/master/f/qemu-lite/qemu-lite.spec
SRPM URL: https://pagure.io/kata-rpm-reviews/blob/master/f/qemu-lite/SRPMS/qemu-lite-2.11.0-1.git6ba2bfb.fc28.src.rpm

Description: 
QEMU is a generic and open source machine & userspace emulator and
virtualizer.

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=27892664

$ rpmlint qemu-lite.spec RPMS/x86_64/qemu-lite-* SRPMS/qemu-lite-2.11.0-1.git6ba2bfb.fc28.src.rpm 
qemu-lite-bin.x86_64: W: summary-not-capitalized C bin components for the qemu-lite package.
qemu-lite-bin.x86_64: W: summary-ended-with-dot C bin components for the qemu-lite package.
qemu-lite-bin.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/virtfs-lite-proxy-helper
qemu-lite-bin.x86_64: W: no-documentation
qemu-lite-bin.x86_64: W: no-manual-page-for-binary qemu-lite-ga
qemu-lite-bin.x86_64: W: no-manual-page-for-binary qemu-lite-pr-helper
qemu-lite-bin.x86_64: W: no-manual-page-for-binary qemu-lite-system-x86_64
qemu-lite-bin.x86_64: W: no-manual-page-for-binary virtfs-lite-proxy-helper
qemu-lite-data.x86_64: W: summary-not-capitalized C data components for the qemu-lite package.
qemu-lite-data.x86_64: W: summary-ended-with-dot C data components for the qemu-lite package.
qemu-lite-data.x86_64: E: arch-dependent-file-in-usr-share /usr/share/qemu-lite/qemu/openbios-ppc
qemu-lite-data.x86_64: E: statically-linked-binary /usr/share/qemu-lite/qemu/openbios-ppc
qemu-lite-data.x86_64: E: missing-PT_GNU_STACK-section /usr/share/qemu-lite/qemu/openbios-ppc
qemu-lite-data.x86_64: E: arch-dependent-file-in-usr-share /usr/share/qemu-lite/qemu/openbios-sparc32
qemu-lite-data.x86_64: E: statically-linked-binary /usr/share/qemu-lite/qemu/openbios-sparc32
qemu-lite-data.x86_64: E: missing-PT_GNU_STACK-section /usr/share/qemu-lite/qemu/openbios-sparc32
qemu-lite-data.x86_64: E: arch-dependent-file-in-usr-share /usr/share/qemu-lite/qemu/openbios-sparc64
qemu-lite-data.x86_64: E: statically-linked-binary /usr/share/qemu-lite/qemu/openbios-sparc64
qemu-lite-data.x86_64: E: missing-PT_GNU_STACK-section /usr/share/qemu-lite/qemu/openbios-sparc64
qemu-lite-data.x86_64: E: arch-dependent-file-in-usr-share /usr/share/qemu-lite/qemu/palcode-clipper
qemu-lite-data.x86_64: W: unstripped-binary-or-object /usr/share/qemu-lite/qemu/palcode-clipper
qemu-lite-data.x86_64: E: statically-linked-binary /usr/share/qemu-lite/qemu/palcode-clipper
qemu-lite-data.x86_64: E: arch-dependent-file-in-usr-share /usr/share/qemu-lite/qemu/s390-ccw.img
qemu-lite-data.x86_64: E: shared-lib-without-dependency-information /usr/share/qemu-lite/qemu/s390-ccw.img
qemu-lite-data.x86_64: W: executable-stack /usr/share/qemu-lite/qemu/s390-ccw.img
qemu-lite-data.x86_64: E: arch-dependent-file-in-usr-share /usr/share/qemu-lite/qemu/s390-netboot.img
qemu-lite-data.x86_64: E: shared-lib-without-dependency-information /usr/share/qemu-lite/qemu/s390-netboot.img
qemu-lite-data.x86_64: W: executable-stack /usr/share/qemu-lite/qemu/s390-netboot.img
qemu-lite-data.x86_64: E: arch-dependent-file-in-usr-share /usr/share/qemu-lite/qemu/u-boot.e500
qemu-lite-data.x86_64: E: statically-linked-binary /usr/share/qemu-lite/qemu/u-boot.e500
qemu-lite-data.x86_64: E: missing-PT_GNU_STACK-section /usr/share/qemu-lite/qemu/u-boot.e500
qemu-lite-data.x86_64: W: no-documentation
qemu-lite.src: W: spelling-error %description -l en_US virtualizer -> visualizer
3 packages and 1 specfiles checked; 19 errors, 14 warnings.

Comment 2 Lokesh Mandvekar 2018-06-27 14:43:56 UTC
Seems these rpmlint errors are present on the default qemu package as well, so maybe we can overlook these??

Comment 3 Neal Gompa 2018-11-17 11:17:39 UTC
Why do we need this verses just using our regular qemu package? QEMU in Fedora 28 is newer than this qemu-lite, and it's very possible that the changes for kata containers may be already in place there.

Adding QEMU maintainer as CC, because I think he should weigh in here on what we should do with this...

Comment 4 Jose Carlos Venegas Munoz 2018-11-20 23:03:32 UTC
Hi, 
Today Kata uses some packages as part of its CI:
qemu-lite: qemu with additional patches to improve boot time and memory usage.
qemu-vanilla: This is a qemu that is not modified. The idea is that yes, kata could work with default qemu package from a distro.

I think it is ok as intial work to use qemu from vedora, to avoid add an additional package to maintain. Be aware qemu with a lot of features enabled may decrease the boot time or memory footprint.

But as part of a initial work we could test the current qemu version for f28 and f29 and request any change or patch is needed to the qemu package.

Comment 5 Jose Carlos Venegas Munoz 2018-11-21 15:08:55 UTC
I just tested Kata with the packaged version of fedora 28 (2.11) and fedora 29 (3.0.0) and the docker integration seems to work well.

200 Passed | 1 Failed.

Comment 6 Neal Gompa 2018-11-21 20:49:19 UTC
Lokesh, I think we should not package this then. It's not strictly necessary, and if we need another qemu flavor in the main qemu package, we should talk to the qemu package maintainer to add it.


Note You need to log in before you can comment on or make changes to this bug.