Bug 1591389 - Drop cockpit message in /etc/issue
Summary: Drop cockpit message in /etc/issue
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-release
Version: 28
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Stephen Gallagher
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2018-06-14 15:19 UTC by Martin Pitt
Modified: 2018-10-02 13:04 UTC (History)
9 users (show)

Fixed In Version: fedora-release-29-0.15.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2018-10-02 13:04:44 UTC
Type: Bug

Attachments (Terms of Use)

Description Martin Pitt 2018-06-14 15:19:08 UTC
Description of problem: On Fedora Server, /etc/issue currently shows a static message about Cockpit. This is often wrong (didn't react to running vs. disabled), not very user friendly (showing raw IPv6 addresses, for example), and it says "Admin Console", but the currently preferred term is "Web Console".

This got replaced with a dynamic /etc/issue.d/cockpit snippet in recent Cockpit 170. Cockpit also generates a dynamic /etc/motd.d/cockpit snippet now, which should soon be shown for SSH logins (see bug 1591381), but this is independent from cleaning up /etc/issue.

This was recently discussed on server@. Start of thread [1], Conclusion [2]. In short, this will replace the old static Cockpit message in /etc/issue, which was  wrong (didn't react to running vs. disabled) and not very user friendly (showing raw IPv6 addresses, for example).

This should remove this special case from fedora-release, and leave the cockpit message to the cockpit package.

[1] https://lists.fedoraproject.org/archives/list/server%40lists.fedoraproject.org/thread/55SWJA6ERCC3ZPAGEQFJK5EGAXTFX7OJ/
[2] https://lists.fedoraproject.org/archives/list/server@lists.fedoraproject.org/message/HZKVNY2C2DMOCKRLLBL6YR3V4L5BY2SR/

Comment 1 Stephen Gallagher 2018-06-14 15:39:09 UTC
Assigning this to Matthew Miller, since he's working on changes in this area already. Matthew: since this was the only reason for a custom issue file for the editions, you can eliminate this logic entirely and simplify the variant handling.

Comment 2 Matthew Miller 2018-06-14 15:43:26 UTC
Yeah, that definitely helps simplify.

Comment 3 Martin Pitt 2018-10-02 13:00:39 UTC
Can this still land for Fedora 29?

Comment 4 Stephen Gallagher 2018-10-02 13:04:44 UTC
So because I reassigned this to Matthew, I forgot about it and didn’t update it when this landed. This is already fixed in F29.

Note You need to log in before you can comment on or make changes to this bug.