Spec URL: http://people.parinux.org/~seyman/fedora/perl-Lingua-EN-PluralToSingular/perl-Lingua-EN-PluralToSingular.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Lingua-EN-PluralToSingular/perl-Lingua-EN-PluralToSingular-0.19-1.fc28.src.rpm Description: This converts words denoting a plural in the English language into words denoting a singular noun. Fedora Account System Username: eseyman Rpmlint Output: 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
There are two minor issues. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: make See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 12 files have unknown license. Detailed output of licensecheck in /home/mavit/src/fedora/1592135-perl-Lingua- EN-PluralToSingular/licensecheck.txt [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Lingua(perl-Lingua-Stem-Ru, perl- Snowball-Norwegian, perl-Lingua-EN-Numbers-Easy, perl-Lingua-EN- Alphabet-Shaw, perl-Lingua-Stem, perl-Lingua-StopWords, perl-Lingua- Preferred, perl-Lingua-PT-Stemmer, perl-Lingua-Stem-It, perl-Lingua- EN-Number-IsOrdinal, perl-Lingua-EN-FindNumber, perl-Lingua-EN- Inflect-Phrase, perl-Lingua-EN-Numbers-Ordinate, perl-Lingua-EN- Inflect, perl-Lingua-EN-Sentence, perl-Snowball-Swedish, perl-Lingua- Translit, perl-Lingua-Identify, perl-Lingua-EN-Syllable, perl-Lingua- Stem-Snowball-Da, perl-Lingua-Stem-Fr, perl-Lingua-EN-Words2Nums, perl-Lingua-Flags, perl-Lingua-EN-Fathom, perl-Lingua-EN-Numbers), /usr/share/perl5/vendor_perl/Lingua/EN(perl-Lingua-EN-Numbers- Ordinate, perl-Lingua-EN-Inflect, perl-Lingua-EN-Sentence, perl- Lingua-EN-Number-IsOrdinal, perl-Lingua-EN-Words2Nums, perl-Lingua-EN- FindNumber, perl-Lingua-EN-Numbers-Easy, perl-Lingua-EN-Alphabet-Shaw, perl-Lingua-EN-Fathom, perl-Lingua-EN-Inflect-Phrase, perl-Lingua-EN- Syllable, perl-Lingua-EN-Numbers) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [?]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: perl-Lingua-EN-PluralToSingular-0.19-1.fc29.noarch.rpm perl-Lingua-EN-PluralToSingular-0.19-1.fc29.src.rpm perl-Lingua-EN-PluralToSingular.noarch: W: no-manual-page-for-binary singular 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory perl-Lingua-EN-PluralToSingular.noarch: W: invalid-url URL: https://metacpan.org/release/Lingua-EN-PluralToSingular <urlopen error [Errno -2] Name or service not known> perl-Lingua-EN-PluralToSingular.noarch: W: no-manual-page-for-binary singular 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Diff spec file in url and in SRPM --------------------------------- --- /home/mavit/src/fedora/1592135-perl-Lingua-EN-PluralToSingular/srpm/perl-Lingua-EN-PluralToSingular.spec 2018-06-17 20:35:46.000000000 +0100 +++ /home/mavit/src/fedora/1592135-perl-Lingua-EN-PluralToSingular/srpm-unpacked/perl-Lingua-EN-PluralToSingular.spec 2018-06-17 13:30:13.000000000 +0100 @@ -6,5 +6,5 @@ URL: https://metacpan.org/release/Lingua-EN-PluralToSingular -Source0: https://cpan.metacpan.org/authors/id/B/BK/BKB/Lingua-EN-PluralToSingular-%{version}.tar.gz +Source0: http://www.cpan.org/authors/id/B/BK/BKB/Lingua-EN-PluralToSingular-%{version}.tar.gz BuildArch: noarch Requires -------- perl-Lingua-EN-PluralToSingular (rpmlib, GLIBC filtered): /usr/bin/perl perl(:MODULE_COMPAT_5.26.2) perl(Exporter) perl(Lingua::EN::PluralToSingular) perl(lib) perl(strict) perl(warnings) Provides -------- perl-Lingua-EN-PluralToSingular: perl(Lingua::EN::PluralToSingular) perl-Lingua-EN-PluralToSingular Source checksums ---------------- https://cpan.metacpan.org/authors/id/B/BK/BKB/Lingua-EN-PluralToSingular-0.19.tar.gz : CHECKSUM(SHA256) this package : c71b6c1aec01aae9c42aef0d9f147a437e91a7cc5cea6e4abbc35440638f299e CHECKSUM(SHA256) upstream package : c71b6c1aec01aae9c42aef0d9f147a437e91a7cc5cea6e4abbc35440638f299e Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1592135 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Peter Oliver from comment #1) > > Issues: > ======= > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: make > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 Fixed. > - If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. I've submitted my request to upstream's bug tracker. https://github.com/benkasminbullock/Lingua-EN-PluralToSingular/issues/19 I've also included a comment in the spec file to that effect. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Lingua-EN-PluralToSingular/perl-Lingua-EN-PluralToSingular.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Lingua-EN-PluralToSingular/perl-Lingua-EN-PluralToSingular-0.19-2.fc28.src.rpm
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Lingua-EN-PluralToSingular
perl-Lingua-EN-PluralToSingular-0.19-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6dd6585318
perl-Lingua-EN-PluralToSingular-0.19-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6dd6585318
perl-Lingua-EN-PluralToSingular-0.19-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.