Bug 1592324 - oc cp panics trying to copy file from elasticsearch pod
Summary: oc cp panics trying to copy file from elasticsearch pod
Keywords:
Status: CLOSED DUPLICATE of bug 1584555
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: oc
Version: 3.10.0
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
: 3.10.0
Assignee: Juan Vallejo
QA Contact: Xingxing Xia
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-18 12:38 UTC by Mike Fiedler
Modified: 2018-06-20 02:10 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-20 02:10:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1584555 0 medium CLOSED oc cp gets panic when pod-side path has too many ../ 2021-02-22 00:41:40 UTC

Internal Links: 1584555

Description Mike Fiedler 2018-06-18 12:38:00 UTC
Description of problem:

# oc cp -c elasticsearch $POD:../../../etc/elasticsearch/secret/admin-cert .    
tar: Removing leading `../../../' from member names
panic: runtime error: slice bounds out of range

goroutine 1 [running]:
github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd.untarAll(0x446d880, 0xc4205790f8, 0x7ffee06996e1, 0x1, 0x7ffee06996b4, 0x2c, 0x0, 0x0)
        /builddir/build/BUILD/atomic-openshift-git-0.ccd325f/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/cp.go:349 +0x7e5
github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd.copyFromPod(0x44b1d60, 0xc42096fb90, 0xc420645180, 0x446e600, 0xc42000e020, 0x0, 0x0, 0x7ffee069968c, 0x27, 0x7ffee06996b4, ...)
        /builddir/build/BUILD/atomic-openshift-git-0.ccd325f/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/cp.go:241 +0x37c
github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd.runCopy(0x44b1d60, 0xc42096fb90, 0xc420645180, 0x446e600, 0xc42000e018, 0x446e600, 0xc42000e020, 0xc420d2e340, 0x2, 0x4, ...)
        /builddir/build/BUILD/atomic-openshift-git-0.ccd325f/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/cp.go:135 +0x35b
github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd.NewCmdCp.func1(0xc420645180, 0xc420d2e340, 0x2, 0x4)
        /builddir/build/BUILD/atomic-openshift-git-0.ccd325f/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/cp.go:73 +0x89
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).execute(0xc420645180, 0xc420d2e280, 0x4, 0x4, 0xc420645180, 0xc420d2e280)
        /builddir/build/BUILD/atomic-openshift-git-0.ccd325f/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:757 +0x2c1
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc420ae7900, 0xc42000e020, 0xc420ae7900, 0xc4202214a0)
        /builddir/build/BUILD/atomic-openshift-git-0.ccd325f/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:843 +0x334
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).Execute(0xc420ae7900, 0x2, 0xc420ae7900)
        /builddir/build/BUILD/atomic-openshift-git-0.ccd325f/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:791 +0x2b
main.main()
        /builddir/build/BUILD/atomic-openshift-git-0.ccd325f/_output/local/go/src/github.com/openshift/origin/cmd/oc/oc.go:42 +0x334



Version-Release number of selected component (if applicable): 

# oc version
oc v3.10.0-0.67.0
kubernetes v1.10.0+b81c8f8
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://ip-172-31-46-133.us-west-2.compute.internal:8443
openshift v3.10.0-0.67.0
kubernetes v1.10.0+b81c8f8


How reproducible:  always
  

Steps to Reproduce:
1.   deploy logging
2.   oc cp -c elasticsearch $POD:../../../etc/elasticsearch/secret/admin-cert .


Actual results:

panic (see above)

Comment 1 Juan Vallejo 2018-06-18 17:01:37 UTC
This is happening due to path shortcuts ("../../../") not being handled properly during the untar process.

Origin PR: https://github.com/openshift/origin/pull/20034
Upstream PR: https://github.com/kubernetes/kubernetes/pull/65189

Comment 2 Mike Fiedler 2018-06-19 14:58:59 UTC
Moving to MODIFIED until a puddle is available to QA

Comment 3 Xingxing Xia 2018-06-20 02:06:25 UTC
Same as bug 1584555

Comment 4 Xingxing Xia 2018-06-20 02:10:09 UTC

*** This bug has been marked as a duplicate of bug 1584555 ***


Note You need to log in before you can comment on or make changes to this bug.