Spec URL: https://jplesnik.fedorapeople.org/perl-Crypt-OpenSSL-Guess/perl-Crypt-OpenSSL-Guess.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Crypt-OpenSSL-Guess/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.src.rpm Description: Crypt::OpenSSL::Guess provides helpers to guess OpenSSL include path on any platforms. Fedora Account System Username: jplesnik
Spec files differ. I will use a standalone one for this review. URL and Source0 addresses are Ok. Source archive (SHA-256: aa6b18e38cb852cbad80a58cd90c395b40819d4d01e0ab37e7703149094d7167) is original. Ok. Summary is Ok. Description is Ok. License verified from lib/Crypt/OpenSSL/Guess.pm, README.md and LICENSE. Ok. No XS code, noarch BuildArch is Ok. TODO: Recommend or suggest `openssl'. The Perl code executes "openssl" program and without it it's pointless. All tests pass. Ok. $ rpmlint perl-Crypt-OpenSSL-Guess.spec ../SRPMS/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.src.rpm ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm drwxr-xr-x 2 root root 0 Jun 18 17:28 /usr/share/doc/perl-Crypt-OpenSSL-Guess -rw-r--r-- 1 root root 434 Apr 16 05:16 /usr/share/doc/perl-Crypt-OpenSSL-Guess/Changes -rw-r--r-- 1 root root 2557 Apr 16 05:16 /usr/share/doc/perl-Crypt-OpenSSL-Guess/README.md drwxr-xr-x 2 root root 0 Jun 18 17:28 /usr/share/licenses/perl-Crypt-OpenSSL-Guess -rw-r--r-- 1 root root 18412 Apr 16 05:16 /usr/share/licenses/perl-Crypt-OpenSSL-Guess/LICENSE -rw-r--r-- 1 root root 2100 Jun 18 17:28 /usr/share/man/man3/Crypt::OpenSSL::Guess.3pm.gz drwxr-xr-x 2 root root 0 Jun 18 17:28 /usr/share/perl5/vendor_perl/Crypt drwxr-xr-x 2 root root 0 Jun 18 17:28 /usr/share/perl5/vendor_perl/Crypt/OpenSSL -rw-r--r-- 1 root root 7804 Apr 16 05:16 /usr/share/perl5/vendor_perl/Crypt/OpenSSL/Guess.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.2) 1 perl(Exporter) >= 5.57 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: A typo in __requires_exclude definition (a pipe character out of condition) erroneously filters all autogenerated dependencies. $ rpm -q --provides -p ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(Crypt::OpenSSL::Guess) = 0.11 1 perl-Crypt-OpenSSL-Guess = 0.11-1.fc29 Binary provides are Ok. The package builds in F29 (https://koji.fedoraproject.org/koji/taskinfo?taskID=27704623). Ok. Otherwise the package is in line with Fedira and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items and provide a new spec file. Resolution: Package NOT approved.
Updated files are on the same links.
Difference in the spec file: --- perl-Crypt-OpenSSL-Guess.spec.old 2018-06-18 15:55:31.000000000 +0200 +++ perl-Crypt-OpenSSL-Guess.spec 2018-06-19 09:46:46.000000000 +0200 @@ -23,8 +23,9 @@ BuildRequires: perl(Test::More) >= 0.98 Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) Requires: perl(Exporter) >= 5.57 +Recommends: openssl -%global __requires_exclude %{?__requires_exclude}|perl\\(Exporter\\)\\s*$ +%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}perl\\(Exporter\\)\\s*$ %description Crypt::OpenSSL::Guess provides helpers to guess OpenSSL include path on any > TODO: Recommend or suggest `openssl'. The Perl code executes "openssl" program > and without it it's pointless. Ok. $ rpmlint perl-Crypt-OpenSSL-Guess.spec ../SRPMS/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.src.rpm ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. > FIX: A typo in __requires_exclude definition (a pipe character out of > condition) erroneously filters all autogenerated dependencies. $ rpm -q --requires -p ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.2) 1 perl(:VERSION) >= 5.8.1 1 perl(Config) 1 perl(Exporter) >= 5.57 1 perl(ExtUtils::MM) 1 perl(File::Spec) 1 perl(strict) 1 perl(Symbol) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm Binary dependencies resolvable. Ok. Resolution: Package APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Crypt-OpenSSL-Guess
Thank you for the review and the repository.