Spec URL: http://people.parinux.org/~seyman/fedora/perl-ReadonlyX/perl-ReadonlyX.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-ReadonlyX/perl-ReadonlyX-1.04-1.fc28.src.rpm Description: ReadonlyX is a near-drop-in replacement for Readonly, the popular facility for creating non-modifiable variables. This is useful for configuration files, headers, etc. It can also be useful as a development and debugging tool for catching updates to variables that should not be changed. Fedora Account System Username: eseyman
Source file is ok Summary is ok Description is ok All tests passed License is not clear to me. TODO: Artistic 2.0 is mention only in META.* ReadonlyX.pm, README.md and LICENSE are under Perl license (GPL+ or Artistic) The Perl license should be probably also listed in License tag URL and Source0 FIX: Please update URL and source0 to the new location: URL: https://metacpan.org/release/ReadonlyX/ Source0: https://cpan.metacpan.org/authors/id/S/SA/SANKO/ReadonlyX-%{version}.tar.gz BuildRequires TODO: Please add version condition for perl(Module::Build::Tiny) >= 0.035 BR 'perl' could be removed, because perl binary is in perl-interpreter $ rpm -qp --requires perl-ReadonlyX-1.04-1.fc29.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.26.2) 1 perl(strict) 1 perl(vars) 1 perl(:VERSION) >= 5.8.0 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Add run-requires 'perl(Storable)' - lib/ReadonlyX.pm:96 $ rpm -qp --provides perl-ReadonlyX-1.04-1.fc29.noarch.rpm | sort | uniq -c 1 perl(ReadonlyX) = 1.04 1 perl-ReadonlyX = 1.04-1.fc29 Binary provides are Ok. $ rpmlint ./perl-ReadonlyX* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Resolution: Not approved
(In reply to Jitka Plesnikova from comment #1) > > The Perl license should be probably also listed in License tag I remember realizing this when building the package but forgot to fix it. I've changed the License field to GPL+ or Artistic > URL and Source0 > FIX: Please update URL and source0 to the new location: > URL: https://metacpan.org/release/ReadonlyX/ > Source0: > https://cpan.metacpan.org/authors/id/S/SA/SANKO/ReadonlyX-%{version}.tar.gz Doh. Fixed. > TODO: Please add version condition for perl(Module::Build::Tiny) >= 0.035 > BR 'perl' could be removed, because perl binary is in perl-interpreter Done. > FIX: Add run-requires 'perl(Storable)' - lib/ReadonlyX.pm:96 Done. Spec URL: http://people.parinux.org/~seyman/fedora/perl-ReadonlyX/perl-ReadonlyX.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-ReadonlyX/perl-ReadonlyX-1.04-2.fc28.src.rpm
> License is not clear to me. > TODO: Artistic 2.0 is mention only in META.* > ReadonlyX.pm, README.md and LICENSE are under Perl license (GPL+ or > Artistic) > The Perl license should be probably also listed in License tag -License: Artistic 2.0 +License: GPL+ or Artistic Fixed > URL and Source0 -URL: http://search.cpan.org/dist/ReadonlyX/ -Source0: http://www.cpan.org/authors/id/S/SA/SANKO/ReadonlyX-%{version}.tar.gz +URL: https://metacpan.org/release/ReadonlyX/ +Source0: https://cpan.metacpan.org/authors/id/S/SA/SANKO/ReadonlyX-%{version}.tar.gz Fixed > > BuildRequires > TODO: Please add version condition for perl(Module::Build::Tiny) >= 0.035 > BR 'perl' could be removed, because perl binary is in perl-interpreter -BuildRequires: perl(Module::Build::Tiny) +BuildRequires: perl(Module::Build::Tiny) >= 0.035 BuildRequires: perl(strict) -BuildRequires: perl Fixed > FIX: Add run-requires 'perl(Storable)' - lib/ReadonlyX.pm:96 +Requires: perl(Storable) $ rpm -qpR perl-ReadonlyX-1.04-2.fc29.noarch.rpm | grep Storable perl(Storable) Fixed The package looks good now. Resolution: Approved
Thank you, Jitka. I've requested the repo.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-ReadonlyX
perl-ReadonlyX-1.04-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d0bfaf3f7c
perl-ReadonlyX-1.04-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-d0bfaf3f7c
perl-ReadonlyX-1.04-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.