Bug 1592971 - iasl segmentation fault
Summary: iasl segmentation fault
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: iasl
Version: 28
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Al Stone
QA Contact: Fedora Extras Quality Assurance
URL: https://bugs.acpica.org/show_bug.cgi?...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-19 18:06 UTC by Ludovic Hirlimann [:Paul-muadib]
Modified: 2018-07-19 18:05 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-19 17:47:03 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
file that fails to compile (1.03 MB, text/x-csrc)
2018-06-19 18:06 UTC, Ludovic Hirlimann [:Paul-muadib]
no flags Details
strace leading to the segmentation fault (77.65 KB, text/plain)
2018-06-19 18:09 UTC, Ludovic Hirlimann [:Paul-muadib]
no flags Details

Description Ludovic Hirlimann [:Paul-muadib] 2018-06-19 18:06:54 UTC
Created attachment 1453007 [details]
file that fails to compile

Description of problem:

Following the recipe at https://delta-xi.net/#056 I'm trying to compile a dsl file :
[ludovic@saraan patch_lenovo_sleep]$ iasl -ve -tc dsdt.dsl

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20180508
Copyright (c) 2000 - 2018 Intel Corporation

iASL: Segmentation Fault
iASL: Terminating
[ludovic@saraan patch_lenovo_sleep]$ 

Version-Release number of selected component (if applicable):
acpica-tools-20180508-2.fc28.x86_64

How reproducible:
Always

Steps to Reproduce:

see website above

Actual results:

iasl segments

Expected results:

the file is compiled.

Additional info:

Comment 1 Ludovic Hirlimann [:Paul-muadib] 2018-06-19 18:09:02 UTC
Created attachment 1453009 [details]
strace leading to the segmentation fault

Adding the output of strace.

Comment 2 Richard W.M. Jones 2018-06-19 18:40:25 UTC
Did coredumpctl or abrt or something capture the core dump from the
crash?  Getting the stack trace would be more helpful.

$ coredumpctl
> gdb
> t a a bt

FWIW I could not reproduce the problem locally with the
input file using:

$ rpm -qf /usr/bin/iasl
acpica-tools-20180105-3.fc28.x86_64

Also we'll need to know which version of iasl this is.

Comment 3 Ludovic Hirlimann [:Paul-muadib] 2018-06-19 18:46:55 UTC
[ludovic@saraan patch_lenovo_sleep]$ rpm -qf /usr/bin/iasl
acpica-tools-20180508-2.fc28.x86_64


coredumpctl doesn't show the crash. I'm not familiar enough with abrt. let me know what I need to set to have a dump usable for you.

Comment 4 Richard W.M. Jones 2018-06-19 19:28:59 UTC
acpica-tools-20180105-3.fc28.x86_64
vs
acpica-tools-20180508-2.fc28.x86_64

I would say the most obvious thing to try is upgrading to
the same version as me.

However if it still crashes then you should be able to get
a core dump this way.

(1) As root, run:

# echo core.%p > /proc/sys/kernel/core_pattern
# dnf debuginfo-install iasl

(2) As normal user, run:

$ ulimit -c unlimited
$ iasl -ve -tc dsdt.dsl

You should find a core.<PID> file.  Do NOT attach it, it's not
interesting.  But you can use it to get a stack trace which is
interesting like this:

$ gdb /usr/bin/iasl core.<PID>
(gdb) t a a bt

Comment 5 Ludovic Hirlimann [:Paul-muadib] 2018-06-19 19:42:06 UTC
(In reply to Richard W.M. Jones from comment #4)
> acpica-tools-20180105-3.fc28.x86_64
> vs
> acpica-tools-20180508-2.fc28.x86_64
> 
> I would say the most obvious thing to try is upgrading to
> the same version as me.

so I've enabled testing, did a dnf clean all and -3 still doesn't show up.

I'll get a dump when I get -3.

Thanks

Comment 6 Richard W.M. Jones 2018-06-19 19:50:25 UTC
> acpica-tools-20180105-3.fc28.x86_64
> vs
> acpica-tools-20180508-2.fc28.x86_64

I wasn't looking at the versions closely enough.  Your version
is actually much later than mine.

I've retested using the newer version and I can reproduce the
segfault locally too.

The stack trace is:

Thread 1 (process 3582):
#0  0x0000555555594979 in LdNamespace1Begin (Op=0x7ffff6ee1f18, 
    Level=<optimized out>, Context=0x555555957430)
    at ../../../source/compiler/aslload.c:791
#1  0x00005555555a844b in TrWalkParseTree (Op=<optimized out>, 
    Op@entry=0x7ffff63d3e78, Visitation=Visitation@entry=3, 
    DescendingCallback=DescendingCallback@entry=0x555555593da0 <LdNamespace1Begin>, 
    AscendingCallback=AscendingCallback@entry=0x555555593ca0 <LdCommonNamespaceEnd>, Context=Context@entry=0x555555957430)
    at ../../../source/compiler/asltree.c:858
#2  0x0000555555594aa0 in LdLoadNamespace (RootOp=0x7ffff63d3e78)
    at ../../../source/compiler/aslload.c:118
#3  0x000055555558d394 in CmDoCompile ()
    at ../../../source/compiler/aslcompile.c:258
#4  0x00005555555a6094 in AslDoOneFile (Filename=<optimized out>)
    at ../../../source/compiler/aslstartup.c:453
#5  0x0000555555572d8f in main (argc=<optimized out>, argv=<optimized out>)
    at ../../../source/compiler/aslmain.c:154

Comment 7 Richard W.M. Jones 2018-06-19 20:17:33 UTC
Since it seems to be a clear upstream regression you
might be better off asking on the upstream bugzilla:
https://www.acpica.org/community

Comment 8 Ludovic Hirlimann [:Paul-muadib] 2018-06-19 23:26:48 UTC
(In reply to Richard W.M. Jones from comment #7)
> Since it seems to be a clear upstream regression you
> might be better off asking on the upstream bugzilla:
> https://www.acpica.org/community

I have filed https://bugs.acpica.org/show_bug.cgi?id=1452 with them. Any chance that you've kept the compiled version and that you could share it with me ?

Comment 9 Ludovic Hirlimann [:Paul-muadib] 2018-06-26 07:51:06 UTC
https://bugs.acpica.org/show_bug.cgi?id=1452#c9

Comment 10 Richard W.M. Jones 2018-06-26 11:12:58 UTC
OK when next version comes out we can upgrade it easily enough.
If you want to become a co-maintainer of this package so you can
update it yourself, see:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers

Comment 11 Al Stone 2018-07-08 22:51:35 UTC
(In reply to Richard W.M. Jones from comment #10)
> OK when next version comes out we can upgrade it easily enough.
> If you want to become a co-maintainer of this package so you can
> update it yourself, see:
> https://fedoraproject.org/wiki/Join_the_package_collection_maintainers

There is no iasl package, and I am the acpica-tools maintainer.  I am currently in the process of building and uploading the 20180629 version of ACPICA.  It should be available in rawhide tomorrow, and f28, f27 within a few days.

According to upstream, it should be fixed at that point.

Please note that we probably need to remove the iasl component; there is no longer an independent package of that name and that tool is included in acpica-tools.

Comment 12 Fedora Update System 2018-07-09 15:03:46 UTC
acpica-tools-20180629-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6ae1ae32c4

Comment 13 Fedora Update System 2018-07-09 15:04:02 UTC
acpica-tools-20180629-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-dd24bb2c8b

Comment 14 Fedora Update System 2018-07-11 19:17:00 UTC
acpica-tools-20180629-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-dd24bb2c8b

Comment 15 Fedora Update System 2018-07-11 23:41:26 UTC
acpica-tools-20180629-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6ae1ae32c4

Comment 16 Fedora Update System 2018-07-19 17:47:03 UTC
acpica-tools-20180629-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2018-07-19 18:05:01 UTC
acpica-tools-20180629-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.