Bug 1593337 - Perform LINK fop under locks
Summary: Perform LINK fop under locks
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: GlusterFS
Classification: Community
Component: sharding
Version: mainline
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-20 15:09 UTC by Krutika Dhananjay
Modified: 2019-07-05 10:55 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-07-05 10:55:46 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Krutika Dhananjay 2018-06-20 15:09:33 UTC
Description of problem:

With https://review.gluster.org/#/q/status:merged+project:glusterfs+branch:master+topic:ref-1568521 in, where fops that might decrement link count - such as UNLINK and RENAME - rely on file link count before cleaning up shards, which is determined under locks, it is important for LINK also to acquire locks to prevent inconsistencies stemming from premature deletion of shards while the inode continues to exist.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Yaniv Kaul 2019-04-22 14:13:07 UTC
Status?

Comment 2 Krutika Dhananjay 2019-04-22 15:15:36 UTC
I don't plan to fix this anytime soon. It's a good bug to fix for beginners as it provides some amount of exposure to the way shard and locks translators work.
I'll keep this and any other not-so-urgent bzs raised in future reserved for using to mentor someone.

Comment 3 Amar Tumballi 2019-07-05 10:55:46 UTC
As per Comment#2


Note You need to log in before you can comment on or make changes to this bug.