Bug 1593351 - mount.glusterfs incorrectly reports "getfattr not found"
Summary: mount.glusterfs incorrectly reports "getfattr not found"
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: fuse
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-20 15:54 UTC by John Mulligan
Modified: 2018-10-23 15:12 UTC (History)
1 user (show)

Fixed In Version: glusterfs-5.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-23 15:12:07 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description John Mulligan 2018-06-20 15:54:08 UTC
Description of problem:

While debugging a failure to mount a gluster volume I was briefly misled by the warning message:
"WARNING: getfattr not found, certain checks will be skipped.."

I did have getfattr installed, however my minimal OS install did not include 'which'. The 'which' command is not as portable and can be replaced by 'command -v'  (see also  https://stackoverflow.com/a/677212 )

Version-Release number of selected component (if applicable):
Tested on 4.2dev-0.99.git1058185


How reproducible:
Always

Steps to Reproduce:
1. Uninstall which if it installed on the system
2. Ensure getfattr tool is installed on the system
3. Run mount.gluterfs (with any options)


Actual results:
Command prints "WARNING: getfattr not found, certain checks will be skipped.." even though the getfattr tool is available.


Expected results:
Command prints "WARNING: getfattr not found, certain checks will be skipped.." only if the getfattr tool is not present.

Comment 1 Worker Ant 2018-06-20 17:40:31 UTC
REVIEW: https://review.gluster.org/20336 (fuse: avoid using the which command) posted (#1) for review on master by John Mulligan

Comment 2 Worker Ant 2018-06-21 05:44:54 UTC
COMMIT: https://review.gluster.org/20336 committed in master by "Amar Tumballi" <amarts> with a commit message- fuse: avoid using the which command

In mount.glusterfs avoid using the which tool as it may not exist
on minimal system installs. Use the "command -v" builtin as
it is expected to be more portable.
Remove a extra semicolon while we're at it.

Change-Id: Ib682ed4955d5bad1beb94b65d10f4c44e9490767
fixes: bz#1593351
Signed-off-by: John Mulligan <jmulligan>

Comment 3 Shyamsundar 2018-10-23 15:12:07 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.