Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1593579

Summary:	all engine utilities should return 0 on printing help
Product:	[oVirt] ovirt-engine	Reporter:	Lucie Leistnerova <lleistne>
Component:	General	Assignee:	Asaf Rachmani <arachman>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ivana Saranova <isaranov>
Severity:	low	Docs Contact:
Priority:	medium
Version:	4.2.4	CC:	bugs, lsvaty
Target Milestone:	ovirt-4.3.0	Flags:	rule-engine: ovirt-4.3+
Target Release:	4.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.3.0_alpha	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-13 07:48:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lucie Leistnerova 2018-06-21 07:03:18 UTC

Description of problem:
Return value of some scripts when using --help is 1 instead of common 0.

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.4.4-0.1.el7_3.noarch

How reproducible: always


Steps to Reproduce:
1. run
# engine-setup --help
# echo $?
# engine-cleanup --help
# echo $?

Actual results: 1


Expected results: 0


Additional info:
The same is for 
/usr/share/ovirt-engine/setup/bin/ovirt-engine-rename
/usr/share/ovirt-engine/setup/bin/ovirt-engine-provisiondb
/usr/share/ovirt-engine/setup/bin/ovirt-engine-remove
and maybe more

Some scripts are correct and return 0 e.g.
engine-backup
engine-config
engine-vacuum
/usr/share/ovirt-engine/setup/bin/ovirt-engine-upgrade-check
/usr/share/ovirt-engine/bin/ovirt-engine-crypto-tool.sh

Comment 1 Ivana Saranova 2018-08-27 13:29:26 UTC

Return value of all the listed scripts when using --help is 0 as expected. If anyone finds another script returning 1 when using --help, feel free to reopen this bug.

Verified: ovirt-engine-4.3.0-0.0.master.20180822092825.git251acd2.el7.noarch

Comment 2 Sandro Bonazzola 2018-11-02 14:32:02 UTC

This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 3 Sandro Bonazzola 2018-11-02 15:04:55 UTC

Closed by mistake, moving back to qa -> verified

Comment 4 Sandro Bonazzola 2019-02-13 07:48:08 UTC

This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.