Bug 1594263 - python-terminado FTBFS on Python 3.7
Summary: python-terminado FTBFS on Python 3.7
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-terminado
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON37
TreeView+ depends on / blocked
 
Reported: 2018-06-22 13:15 UTC by Miro Hrončok
Modified: 2018-06-27 14:28 UTC (History)
3 users (show)

Fixed In Version: python-terminado-0.8.1-4.fc29
Clone Of:
Environment:
Last Closed: 2018-06-27 14:28:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github jupyter terminado issues 58 0 None None None 2018-06-22 13:26:29 UTC

Description Miro Hrončok 2018-06-22 13:15:47 UTC
https://koji.fedoraproject.org/koji/taskinfo?taskID=27753761

python-terminado-0.8.1-3.fc29

fedpkg build --target=f29-python



+ /usr/bin/python3 -m pytest -v
============================= test session starts ==============================
platform linux -- Python 3.7.0rc1, pytest-3.6.1, py-1.5.3, pluggy-0.6.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /builddir/build/BUILD/terminado-0.8.1, inifile:
collecting ... collected 8 items
terminado/tests/basic_test.py::CommonTests::test_basic PASSED            [ 12%]
terminado/tests/basic_test.py::CommonTests::test_basic_command PASSED    [ 25%]
terminado/tests/basic_test.py::NamedTermTests::test_max_terminals PASSED [ 37%]
terminado/tests/basic_test.py::NamedTermTests::test_namespace PASSED     [ 50%]
terminado/tests/basic_test.py::NamedTermTests::test_new PASSED           [ 62%]
terminado/tests/basic_test.py::SingleTermTests::test_single_process PASSED [ 75%]
terminado/tests/basic_test.py::UniqueTermTests::test_max_terminals FAILED [ 87%]
terminado/tests/basic_test.py::UniqueTermTests::test_unique_processes PASSED [100%]
=================================== FAILURES ===================================
______________________ UniqueTermTests.test_max_terminals ______________________
self = <terminado.tests.basic_test.UniqueTermTests testMethod=test_max_terminals>
    @tornado.testing.gen_test
    def test_max_terminals(self):
        tms = yield self.get_term_clients(['/unique'] * MAX_TERMS)
>       pids = yield self.get_pids(tms)
terminado/tests/basic_test.py:228: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib/python3.7/site-packages/tornado/gen.py:1099: in run
    value = future.result()
/usr/lib/python3.7/site-packages/tornado/gen.py:1107: in run
    yielded = self.gen.throw(*exc_info)
terminado/tests/basic_test.py:121: in get_pids
    pid = yield tm.get_pid()
/usr/lib/python3.7/site-packages/tornado/gen.py:1099: in run
    value = future.result()
/usr/lib/python3.7/site-packages/tornado/gen.py:1107: in run
    yielded = self.gen.throw(*exc_info)
terminado/tests/basic_test.py:87: in get_pid
    (stdout, extra) = yield self.read_stdout()
/usr/lib/python3.7/site-packages/tornado/gen.py:1099: in run
    value = future.result()
/usr/lib/python3.7/site-packages/tornado/gen.py:1113: in run
    yielded = self.gen.send(value)
terminado/tests/basic_test.py:74: in read_stdout
    stdout = "".join([msg[1] for msg in msglist if msg[0] == 'stdout'])
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.0 = <list_iterator object at 0xf52ad34c>
>   stdout = "".join([msg[1] for msg in msglist if msg[0] == 'stdout'])
E   TypeError: 'NoneType' object is not subscriptable
terminado/tests/basic_test.py:74: TypeError
------------------------------ Captured log call -------------------------------
autoreload.py              123 WARNING  tornado.autoreload started more than once in the same process
=============================== warnings summary ===============================
terminado/tests/basic_test.py::TestTermClient
  cannot collect test class 'TestTermClient' because it has a __init__ constructor
-- Docs: http://doc.pytest.org/en/latest/warnings.html
=============== 1 failed, 7 passed, 1 warnings in 35.68 seconds ================


This blocks python-notebook

Comment 1 Petr Viktorin (pviktori) 2018-06-27 14:17:27 UTC
I haven't been able to find the root cause :(

But, switching to nosetests seems to work around the issue: https://src.fedoraproject.org/rpms/python-terminado/pull-request/2

Comment 2 Miro Hrončok 2018-06-27 14:28:43 UTC
Thank You!


Note You need to log in before you can comment on or make changes to this bug.