Bug 1594579 - demo_content.yaml contains VirtualMachinePreset instead of VirtualMachineInstancePreset
Summary: demo_content.yaml contains VirtualMachinePreset instead of VirtualMachineInst...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Build
Version: 1.1
Hardware: Unspecified
OS: Unspecified
high
urgent
Target Milestone: ---
: 1.1
Assignee: Fabian Deutsch
QA Contact: Lukas Bednar
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-24 15:57 UTC by Nelly Credi
Modified: 2018-11-08 14:25 UTC (History)
4 users (show)

Fixed In Version: kubevirt-0.6.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-08 14:25:45 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Nelly Credi 2018-06-24 15:57:11 UTC
Description of problem:
demo_content.yaml contains VirtualMachinePreset instead of VirtualMachineInstancePreset

Version-Release number of selected component (if applicable):
kubevirt/0.7.0/14.a6de7bc

How reproducible:
100%

Steps to Reproduce:
1.the manifest is under /usr/share/kubevirt/manifests/release/
2.try to apply it with oc command
3.

Actual results:
yaml has:
# Virtual Machine Presets
apiVersion: kubevirt.io/v1alpha2
kind: VirtualMachinePreset

error: unable to recognize \"STDIN\": no matches for kind \"VirtualMachinePreset\" in version \"kubevirt.io/v1alpha2\"", "stderr_lines": ["+ set -o pipefail", "++ rpm -ql kubevirt-manifests", "++ grep 'manifests$'", "+ manifests_dir=/usr/share/kubevirt/manifests", "+ '[' -d /usr/share/kubevirt/manifests ']'", "+ for manifest in '\"release/kubevirt.yaml\"' '\"release/demo-content.yaml\"'", "+ sed -e 's|\"/virt-\\([^\"]*\\)\"|\"/usr/bin/virt-\\1\"|' -e 

Expected results:
yaml should have:
# Virtual Machine Presets
apiVersion: kubevirt.io/v1alpha2
kind: VirtualMachineInstancePreset

oc apply -f should work

Additional info:

Comment 1 Fabian Deutsch 2018-07-03 12:13:34 UTC
Upstream fix https://github.com/kubevirt/kubevirt/pull/1264

Please review

Comment 2 Nelly Credi 2018-07-03 17:28:10 UTC
lgtm & it already got merged anyway :)

Comment 4 Nelly Credi 2018-08-01 10:57:45 UTC
I dont see this yaml in the environment anymore
and there is this card:
https://trello.com/c/JX8wqEkM/137-5-ship-presets-epic-deployment

so should we have this yaml in D/S builds?
as part of the kubevirt-manifests rpm?
should it get extracted on deployment?

Comment 5 Nelly Credi 2018-08-01 11:08:27 UTC
discussed with Lukas.
Since the yaml is ok now, ill mark this bug as verified
and open a bug for kubevirt apb, which doesnt deploy presets

one thing to consider though is changing the name of this manifest to something more meaningful


Note You need to log in before you can comment on or make changes to this bug.