Bug 1594622
| Summary: | The error info is misleading when creating snapshot with the specified format is not qcow2 | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Tingting Mao <timao> |
| Component: | qemu-kvm-rhev | Assignee: | Kevin Wolf <kwolf> |
| Status: | CLOSED NOTABUG | QA Contact: | Tingting Mao <timao> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 7.6 | CC: | chaoyang, juzhang, michen, ngu, pingl, timao, virt-maint |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-12-13 20:38:48 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tingting Mao
2018-06-25 03:04:03 UTC
Re-tested steps: 1. Create base image # qemu-img create -f raw base.img 10G Formatting 'base.img', fmt=raw size=10737418240 2. Create snapshot specifying format not qcow2 # qemu-img create -b base.img -f raw sn qemu-img: sn: Backing file not supported for file format 'raw' # qemu-img create -b base.img -f luks sn qemu-img: sn: Backing file not supported for file format 'luks' According the test result, change the title to the new one. Thanks for pingl's correction. Low priority low hanging fruit, probably worth fixing upstream and inheriting in a rebase. The thing that is not supported is attaching a backing file to a raw image. I don't see what's wrong with the error message. The suggested alternative "Snapshot not supported" I would understand as: "You cannot take a snapshot of a raw image". This is wrong, because you can snapshot a raw image when you attach it as a backing file to a qcow2 image. So I think the current error message is actually better. (In reply to Kevin Wolf from comment #7) > The thing that is not supported is attaching a backing file to a raw image. > I don't see what's wrong with the error message. Hi Kevin, Thanks for your info at first. However, what confuses me is that in our daily work, we call the base image (i.e.'base.img' in this case) as 'backing file' while for new image created based on the 'base.img' is 'snapshot|overlay'. So the error info seems like that 'base.img' is not supported for file format 'raw|luks'. Please correct me if there is something wrong, and thanks in advance. But the error message doesn't say that something is not supported for the backing file, but it says that having a backing file is not supported for the overlay image format. The case that you seem to understand would be phrased like "$FORMAT is not supported for backing files" or "Cannot use $FORMAT for backing files". Note that this is "$FOO not supported for backing files", not "backing files not supported for $FOO". > # qemu-img create -b base.img sn
> qemu-img: sn: Backing file not supported for file format 'raw'
Hi Kevin,
If we don't specify the image format for sn, the default image format is raw. Although the command failed as expected, but it is not easy to know the reason from the error message. QEMU should bring up an intuitionisticly hint such as "snapshot is not supported for the file format 'raw'" or "snapshot is only supported for the file format qcow2"
(In reply to Kevin Wolf from comment #9) > But the error message doesn't say that something is not supported for the > backing file, but it says that having a backing file is not supported for > the overlay image format. > > The case that you seem to understand would be phrased like "$FORMAT is not > supported for backing files" or "Cannot use $FORMAT for backing files". Note > that this is "$FOO not supported for backing files", not "backing files not > supported for $FOO". Kevin asked for my opinion in reviewing this case and error message. After carefully considering the alternatives, I agree with him that the current error message is correct and the alternative would be technically misleading and could confuse some people as well. So given this is a low priority issue, it's not worth spending too much time on it and I'm closing this BZ. I hope you understand. Thanks. |