Spec URL: https://thofmann.fedorapeople.org/tiny-dnn/tiny-dnn.spec SRPM URL: https://thofmann.fedorapeople.org/tiny-dnn/tiny-dnn-1.0.0-0.a3.2.fc27.src.rpm Description: tiny-dnn is a C++14 implementation of deep learning. It is suitable for deep learning on limited computational resource, embedded systems and IoT devices. Fedora Account System Username: thofmann koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=27859344 COPR: https://copr.fedorainfracloud.org/coprs/thofmann/tiny-dnn/
- Why provide an empty main package? You should probably only provide -devel - It needs gcc-c++ as a BR Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "BSL (v1.0) BSD (3 clause)", "Unknown or generated", "MIT/X11 (BSD like)", "SIL (v1.1)", "BSD (3 clause)", "MIT/X11 (BSD like) BSL". 430 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/tiny-dnn/review- tiny-dnn/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in tiny- dnn-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: tiny-dnn-1.0.0-0.a3.2.fc29.noarch.rpm tiny-dnn-devel-1.0.0-0.a3.2.fc29.noarch.rpm tiny-dnn-1.0.0-0.a3.2.fc29.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Spec URL: https://thofmann.fedorapeople.org/tiny-dnn/tiny-dnn.spec SRPM URL: https://thofmann.fedorapeople.org/tiny-dnn/tiny-dnn-1.0.0-0.a3.3.fc28.src.rpm Thanks for reviewing! Changes: - Add missing BR: gcc-c++ - Only provide devel subpackage - Remove BuildArch: noarch (should not be used for header only libs) - Add virtual provide for tiny-dnn-static (following guidelines for header only libs) For the last two points, also see https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Header_Only_Libraries.
Everything seems good, package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/tiny-dnn
tiny-dnn-1.0.0-0.a3.2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9da7461032
tiny-dnn-1.0.0-0.a3.3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-bcdef7516b
tiny-dnn-1.0.0-0.a3.2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9da7461032
tiny-dnn-1.0.0-0.a3.3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-bcdef7516b
tiny-dnn-1.0.0-0.a3.2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
tiny-dnn-1.0.0-0.a3.3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.