The spec is based on rackspace/php-opencloud which this package supersedes. It however lives in a new namespace, does not conflict with the old package and should therefore be a seperate, new package.

 - You're shipping the source files of the docs instead of building them with python3-sphinx. Unfortunately it requires also sphinxcontrib.phpdomain which is not yet packaged: https://pypi.org/project/sphinxcontrib-phpdomain

   It would be very quick to package with: pyp2rpm -b3 -p2 sphinxcontrib-phpdomain  > python-sphinxcontrib-phpdomain (Just fix the Requires generated with rich dependencies). I'll review it quickly.

   Then:

BuildRequires: python3dist(sphinx)
BuildRequires: python3dist(sphinxcontrib-phpdomain)

   And:

%build

# generate html docs 
PYTHONPATH=${PWD} sphinx-build-3 doc html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}


 - Once the doc are built, you need to unbundle the fonts:

html/_static/fonts/FontAwesome.otf
html/_static/fonts/Inconsolata-Bold.ttf
html/_static/fonts/Inconsolata.ttf
html/_static/fonts/Lato-Bold.ttf
html/_static/fonts/Lato-Regular.ttf
html/_static/fonts/RobotoSlab-Bold.ttf
html/_static/fonts/RobotoSlab-Regular.ttf
html/_static/fonts/fontawesome-webfont.eot
html/_static/fonts/fontawesome-webfont.svg
html/_static/fonts/fontawesome-webfont.ttf
html/_static/fonts/fontawesome-webfont.woff

   Use:

BuildRequires:  fontawesome-fonts
BuildRequires:  fontawesome-fonts-web
BuildRequires:  lato-fonts
BuildRequires:  google-roboto-slab-fonts
BuildRequires:  levien-inconsolata-fonts

   And then use symbolic links where appropriate in %build:

# Unbundle fonts
pushd html/_static/fonts/
for file in FontAwesome*; do
    rm -f $file
    ln -s /usr/share/fonts/fontawesome/$file $file
done
for file in fontawesome*; do
    rm -f $file
    ln -s /usr/share/fonts/fontawesome/$file $file
done
for file in Lato*; do
    rm -f $file
    ln -s /usr/share/fonts/lato/$file $file
done
for file in RobotoSlab*; do
    rm -f $file
    ln -s /usr/share/fonts/google-roboto-slab/$file $file
done
for file in Inconsolata*; do
    rm -f $file
    ln -s /usr/share/fonts/levien-inconsolata/$file $file
done
popd

(Inconsolata is only available in the latest version on F29, keep the original files for < F29)





Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "BSD (unspecified)", "SIL (v1.1)", "Unknown or
     generated". 712 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/php-opencloud-openstack
     /review-php-opencloud-openstack/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

PHP:
[x]: Run phpci static analyze on all php files.
     Note: phpCompatInfo version 5.0.12 DB version 1.32.0 built Apr 27 2018
     06:12:44 CEST static analyze results in /home/bob/packaging/review
     /php-opencloud-openstack/review-php-opencloud-openstack/phpci.log


Rpmlint
-------
Checking: php-opencloud-openstack-3.0.5-1.fc29.noarch.rpm
          php-opencloud-openstack-doc-3.0.5-1.fc29.noarch.rpm
          php-opencloud-openstack-3.0.5-1.fc29.src.rpm
php-opencloud-openstack.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader
php-opencloud-openstack.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
php-opencloud-openstack-doc.noarch: E: version-control-internal-file /usr/share/doc/php-opencloud-openstack-doc/doc/.gitignore
php-opencloud-openstack-doc.noarch: E: version-control-internal-file /usr/share/doc/php-opencloud-openstack-doc/doc/api-docs/.gitignore
php-opencloud-openstack-doc.noarch: W: spurious-executable-perm /usr/share/doc/php-opencloud-openstack-doc/doc/conf.py
php-opencloud-openstack-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/php-opencloud-openstack-doc/doc/make.bat
php-opencloud-openstack.src: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader
php-opencloud-openstack.src: W: spelling-error %description -l en_US usr -> use, us, user
php-opencloud-openstack.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
3 packages and 0 specfiles checked; 2 errors, 7 warnings.

Thanks for the detailed walkthrough! Review Request for sphinxcontrib-phpdomain is incoming

Spec URL: https://copr-be.cloud.fedoraproject.org/results/lorbus/php-opencloud-openstack/fedora-rawhide-x86_64/00772826-php-opencloud-openstack/php-opencloud-openstack.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lorbus/php-opencloud-openstack/fedora-rawhide-x86_64/00772826-php-opencloud-openstack/php-opencloud-openstack-3.0.5-1.fc29.src.rpm

Description:
php-opencloud/openstack is an SDK which allows PHP developers to easily connect
to OpenStack APIs in a simple and idiomatic way. This binding is specifically
designed for OpenStack APIs, but other provider SDKs are available. Multiple
OpenStack services, and versions of services, are supported.

Fedora Account System Username: lorbus

You also need to put these as Requires too so the fonts are found when the package is installed:

Requires: fontawesome-fonts
Requires: fontawesome-fonts-web
Requires: lato-fonts
Requires: google-roboto-slab-fonts
%if 0%{?fedora} >= 29
Requires: levien-inconsolata-fonts
%endif


Package otherwise approved.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-opencloud-openstack