Bug 1596152

the option is not effective anyway as there are other frontend validations

(Originally by michal.skrivanek)

The patch was not back-ported for 4.2.5, so changing back to ASSIGNED.

patch: https://code.engineering.redhat.com/gerrit/#/c/144708/

new patch link: https://code.engineering.redhat.com/gerrit/#/c/145190/

Tried to verify on:
ovirt-engine-4.2.6-0.1.el7ev.noarch
ovirt-engine-setup-plugin-ovirt-engine-4.2.6-0.1.el7ev.noarch
ovirt-engine-setup-4.2.6-0.1.el7ev.noarch
ovirt-engine-setup-plugin-ovirt-engine-common-4.2.6-0.1.el7ev.noarch
rhvm-setup-plugins-4.2.11-1.el7ev.noarch
ovirt-engine-setup-base-4.2.6-0.1.el7ev.noarch

Steps:
1. Tried to CPU pin a VM in the web admin UI.
2. Tried to pin a VM to host(with allow manual migration).
3. Pin a VM to host(without migration).
3a. Tried to set the host with the VM running into maintenance.
4. Connect to the engine via SSH
4a. Run:
# su - postgres
# psql -d engine
engine=# select * from vdc_options where option_name = 'CpuPinMigrationEnabled';

Results:
As said in comment #1 (for steps 1-3):
In steps 1-2 I couldn't pin the CPU of the VM in the UI.
In step 3, the host couldn't enter into maintenance mode due to the VM.
In step 4:
 option_id |      option_name       | option_value | version 
-----------+------------------------+--------------+---------
         2 | CpuPinMigrationEnabled | false        | general
(1 row)

(In reply to Sharon Gratch from comment #10)
> Hi Michal,
> 
> The only relevant result in QE's verification for this fix is step 4:
> The value of "CpuPinMigrationEnabled" is still set to false.
> 
> I checked content of [1] and see that the patch [2] was merged as required,
> i.e. the overridden of CpuPinMigrationEnabled to false in config.py file was
> removed.

 These are internal links to internal builds, do not belong to a public comment

> Any idea why installing rhv 4.2.6 doesn't override the value of
> CpuPinMigrationEnabled parameter to true as done in upstream? 
> Maybe we should explicitly set it to true instead of removing the overridden?

Well, do you see any override incase it’s already false? We’ll need to fix it differently for existing setups...
I’d actually suggest to just remove that option from ovirt-engine altogether. It’s useless on its own anyway

Verified on:
ovirt-engine-4.2.6.4-0.1.el7ev.noarch
rhvm-setup-plugins-4.2.11-1.el7ev.noarch
ovirt-engine-setup-plugin-ovirt-engine-4.2.6.4-0.1.el7ev.noarch
ovirt-engine-setup-4.2.6.4-0.1.el7ev.noarch
ovirt-engine-setup-plugin-ovirt-engine-common-4.2.6.4-0.1.el7ev.noarch
ovirt-engine-setup-base-4.2.6.4-0.1.el7ev.noarch

Steps:
1. Connect to the engine via SSH
2. Run:
# su - postgres
# psql -d engine
engine=# select * from vdc_options where option_name = 'CpuPinMigrationEnabled';

Results:
 option_id | option_name | option_value | version 
-----------+-------------+--------------+---------
(0 rows)

Steve,

This old doc text is obsolete and should be changed to something like:
Remove the config parameter called "CpuPinMigrationEnabled" (appears on DB in vdc_options table) in downstream and upstream installations. 
This change was done to support High Performance VM live migration (BZ 1457250)

The same text as for upstream bz - https://bugzilla.redhat.com/show_bug.cgi?id=1596151

Sharon, what I understand from your note is:

* High Performance Virtual Machine live migration is enabled by default (i.e. if you don't specify CpuPinMigrationEnabled is "false", it is "true" by default). 
* If you want to disable this parameter then you specify it as "false"?

Does the same thing apply to this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1611968

From Sharon's doc text: The same text as for upstream bz - https://bugzilla.redhat.com/show_bug.cgi?id=1596151

Does this mean that I should edit the doc text in 1596151?

(In reply to Steve Goodman from comment #16)
> Sharon, what I understand from your note is:
> 
> * High Performance Virtual Machine live migration is enabled by default
> (i.e. if you don't specify CpuPinMigrationEnabled is "false", it is "true"
> by default). 
> * If you want to disable this parameter then you specify it as "false"?
> 
> Does the same thing apply to this bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=1611968

Not exactly, this bug was just for removing the CpuPinMigrationEnabled config parameter from the downstream installation scripts. The same removal was done for upstream installation as well (BZ 1596151) but since there was a special reference to this parameter from the downstream installation, we also needed this fix.
This removal was done as a pre-requisite for High Performance vms migration feature.

(In reply to Steve Goodman from comment #17)
> From Sharon's doc text: The same text as for upstream bz -
> https://bugzilla.redhat.com/show_bug.cgi?id=1596151
> 
> Does this mean that I should edit the doc text in 1596151?

I think you should verify the phrasing for doc text of BZ 1596151 but the content there is ok. It handles the CpuPinMigrationEnabled config parameter removal from upstream.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:2627